[Hub Generated] Review request for Microsoft.KeyVault to add version stable/7.3 #18028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @maorleger Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.KeyVault/stable/7.3/rbac.json#L476 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.KeyVault/stable/7.3/rbac.json#L518 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.KeyVault/stable/7.3/rbac.json#L530 |
|
| The operation 'CreateCertificate' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.KeyVault/stable/7.3/certificates.json#L458 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
In operation RoleDefinitions_Delete, example for parameter scope: / starts with a forward slash and the path template: /{scope}/providers/Microsoft.Authorization/roleDefinitions/{roleDefinitionName} contains a forward slash before the parameter starts. This will cause double forward slashes in the request url. Thus making it incorrect. Url: Microsoft.KeyVault/stable/7.3/rbac.json#L31:17 ExampleUrl: stable/7.3/examples/DeleteRoleDefinition-example.json#L38:11 |
|
Missing required property: scope Url: Microsoft.KeyVault/stable/7.3/rbac.json#L38:11 ExampleUrl: stable/7.3/examples/DeleteRoleDefinition-example.json#L4:14 |
|
In operation RoleDefinitions_Get, example for parameter scope: / starts with a forward slash and the path template: /{scope}/providers/Microsoft.Authorization/roleDefinitions/{roleDefinitionName} contains a forward slash before the parameter starts. This will cause double forward slashes in the request url. Thus making it incorrect. Url: Microsoft.KeyVault/stable/7.3/rbac.json#L132:14 ExampleUrl: stable/7.3/examples/GetRoleDefinition-example.json#L139:11 |
|
Missing required property: scope Url: Microsoft.KeyVault/stable/7.3/rbac.json#L139:11 ExampleUrl: stable/7.3/examples/GetRoleDefinition-example.json#L4:14 |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 10 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:stable/7.3/backuprestore.json compared with base:stable/7.2/backuprestore.json
- current:stable/7.3/backuprestore.json compared with base:preview/7.2-preview/backuprestore.json
- current:stable/7.3/certificates.json compared with base:stable/7.2/certificates.json
- current:stable/7.3/certificates.json compared with base:preview/7.2-preview/certificates.json
- current:stable/7.3/common.json compared with base:stable/7.2/common.json
- current:stable/7.3/common.json compared with base:preview/7.2-preview/common.json
- current:stable/7.3/keys.json compared with base:stable/7.2/keys.json
- current:stable/7.3/keys.json compared with base:preview/7.2-preview/keys.json
- current:stable/7.3/rbac.json compared with base:stable/7.2/rbac.json
- current:stable/7.3/rbac.json compared with base:preview/7.2-preview/rbac.json
- current:stable/7.3/secrets.json compared with base:stable/7.2/secrets.json
- current:stable/7.3/secrets.json compared with base:preview/7.2-preview/secrets.json
- current:stable/7.3/securitydomain.json compared with base:stable/7.2/securitydomain.json
- current:stable/7.3/securitydomain.json compared with base:preview/7.2-preview/securitydomain.json
- current:stable/7.3/storage.json compared with base:stable/7.2/storage.json
- current:stable/7.3/storage.json compared with base:preview/7.2-preview/storage.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
Hi @maorleger, Your PR has some issues. Please fix the CI sequentially by following the order of
|
heaths
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Paths and versions look right, and OpenAPI Hub Diff between 7.3 and 7.3-preview (in main) shows no diffs.
* add exclusion for known spellcheck issue * collapse cspell ignore for keyvault's storage.json
|
Note to maintainers e.g., @lmazuel @kurtzeborn: the 2 errors are consummate errors. One is a validation bug, and the other is a red herring (the double slash one) because of how KV treats a path parameter as optional, which validation doesn't understand (and, arguably, is a violation of REST API guidelines but it's always been that way). |
maorleger
requested review from
BlackRider97 and
weidongxu-microsoft
and removed request for
a team
lmazuel
approved these changes
Mar 21, 2022
25 tasks
6 tasks
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
…stable/7.3 (Azure#18028) * Adds base for updating Microsoft.KeyVault from version preview/7.3-preview to version 7.3 * Updates readme * Updates API version in new specs and examples * [KeyVault] - Add exclusion for known spellcheck issue (Azure#18031) * add exclusion for known spellcheck issue * collapse cspell ignore for keyvault's storage.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
This PR migrates 7.3-preview to stable
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.