-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIR and SIG architecture #17853
PIR and SIG architecture #17853
Conversation
Hi, @kangsun-ctrl Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
1041 - AddedPropertyInResponse
|
The new version has a new property 'architecture' in response that was not found in the old version. New: Microsoft.Compute/stable/2021-11-01/compute.json#L11867:7 Old: Microsoft.Compute/stable/2021-11-01/compute.json#L11855:7 |
1045 - AddedOptionalProperty
|
The new version has a new optional property 'architecture' that was not found in the old version. New: Microsoft.Compute/stable/2021-10-01/gallery.json#L2181:7 Old: Microsoft.Compute/stable/2021-10-01/gallery.json#L2181:7 |
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/1d7ce851071426c6b1b48c4747f913a3b4fadb21/specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01", "details":"Command failed: node /home/vsts/work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.25/common/temp/node_modules/.pnpm/@Azure+oad@0.9.3/node_modules/autorest/dist/app.js /tmp/readme.oad.old.md --tag=oad-default-tag --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp |
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions\n - file:///home/vsts/work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/compute/resource-manager/Microsoft.Compute/stable/2021-07-01/compute.json:14558:4 ( |
|
ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions\n - file:///home/vsts/work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specific" |
️⚠️
LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- compute/resource-manager/readme.md tag:package-2021-04-01
- compute/resource-manager/readme.md tag:package-2021-11-01
- compute/resource-manager/readme.md tag:package-2021-08-01
- compute/resource-manager/readme.md tag:package-2021-10-01
- compute/resource-manager/readme.md tag:package-2021-07-01
- compute/resource-manager/readme.md tag:package-2021-06-01-preview
- Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- compute/resource-manager/readme.md tag:package-2021-04-01
- compute/resource-manager/readme.md tag:package-2021-11-01
- compute/resource-manager/readme.md tag:package-2021-08-01
- compute/resource-manager/readme.md tag:package-2021-10-01
- compute/resource-manager/readme.md tag:package-2021-07-01
- compute/resource-manager/readme.md tag:package-2021-06-01-preview
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
D5001 - XmsExamplesRequired |
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Location: Microsoft.Compute/stable/2021-04-01/compute.json#L36 |
D5001 - XmsExamplesRequired |
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Location: Microsoft.Compute/stable/2021-07-01/compute.json#L36 |
D5001 - XmsExamplesRequired |
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Location: Microsoft.Compute/stable/2021-07-01/compute.json#L36 |
D5001 - XmsExamplesRequired |
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Location: Microsoft.Compute/stable/2021-07-01/compute.json#L36 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L1748 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L1748 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L1929 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L1929 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L2111 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L2111 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L2263 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2020-09-30/gallery.json#L2263 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L1754 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L1754 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L1948 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L1948 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L2130 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L2130 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L2282 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-07-01/gallery.json#L2282 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L1772 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L1772 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2069 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2069 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2251 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2251 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2418 |
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Compute/stable/2021-10-01/gallery.json#L2418 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-04-01/compute.json#L49 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-04-01/compute.json#L100 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2021-11-01 |
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️❌
ModelValidation: 185 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
- compute/resource-manager/readme.md#package-2021-11-01
- compute/resource-manager/readme.md#package-2021-11-01-only
- compute/resource-manager/readme.md#package-2021-08-01
- compute/resource-manager/readme.md#package-2021-10-01
- compute/resource-manager/readme.md#package-2021-10-01-only
- compute/resource-manager/readme.md#package-2021-07-01
- compute/resource-manager/readme.md#package-2021-07-01-only
- compute/resource-manager/readme.md#package-2021-06-01-preview
- compute/resource-manager/readme.md#package-2021-04-01
- compute/resource-manager/readme.md#package-2021-04-01-only
- compute/resource-manager/readme.md#package-2021-03-01
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
NewApiVersionRequired reason: |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
LGTM |
@ArcturusZhang could you help merge? |
@ArcturusZhang ready for merging. Please merge |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
We have a model collision issue on tag |
Hi @kangsun-ctrl, Your PR has some issues. Please fix the CI sequentially by following the order of
|
It turns out that we have to fix it in this PR because the package that is reporting errors has already been released, and we cannot remove it. |
* save * save * add some missing x-ms-identifiers * add more x-ms-identifiers * add more x-ms-identifiers Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
* save * save * add some missing x-ms-identifiers * add more x-ms-identifiers * add more x-ms-identifiers Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.