DiskRP swagger changes for TVM and CVM of version 2021-08-01 #16671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshulsolanki21
requested review from
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee,
madewithsmiles,
MS-syh2qs and
Sandido
as code owners
|
Hi, @anshulsolanki21 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
ghost
added
the
|
Hi @anshulsolanki21, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Nov 4, 2021
This was referenced Nov 9, 2021
|
@ArcturusZhang can we suppress spellcheck for secureVMdiskEncryptionSetId? |
… dev/ansolan/tvmcvmswagger
lakmeedee
reviewed
Nov 17, 2021
specification/compute/resource-manager/Microsoft.Compute/stable/2021-08-01/disk.json
Outdated
Show resolved
Hide resolved
chetmaddula
reviewed
Nov 23, 2021
| }, | ||
| { | ||
| "value": "ConfidentialVM_DiskEncryptedWithPlatformKey", | ||
| "description": "Indicates Confidential VM disk with both OS disk blob and VM guest state blob encrypted with a platform managed key" |
There was a problem hiding this comment.
don't mention blobs.. both Os disk and VM guest state encrypted
There was a problem hiding this comment.
same for all other additions.. remove any references to blob
There was a problem hiding this comment.
removed blob references:
also modified descriptions for "ImportSecure" and "SecurityDataUri", please help review that too
chetmaddula
reviewed
Nov 23, 2021
specification/compute/resource-manager/Microsoft.Compute/stable/2021-08-01/disk.json
Outdated
Show resolved
Hide resolved
chetmaddula
reviewed
Nov 23, 2021
specification/compute/resource-manager/Microsoft.Compute/stable/2021-08-01/disk.json
Outdated
Show resolved
Hide resolved
chetmaddula
reviewed
Nov 23, 2021
specification/compute/resource-manager/Microsoft.Compute/stable/2021-08-01/disk.json
Outdated
Show resolved
Hide resolved
chetmaddula
approved these changes
Nov 24, 2021
haagha
pushed a commit
that referenced
this pull request
Dec 16, 2021
* DiskRP swagger changes for TVM and CVM of version 2021-08-01 * adding examples for CVM * fix errors * fix errors * fix unreferences example file * fix for: additional properties not allowed error * fix spell check error * fix spell check for secureVMDiskEncryptionSetId property * fix prettier check * addressing comment * addressing comments
ArcturusZhang
pushed a commit
that referenced
this pull request
Dec 28, 2021
* new folder and files added for diskRP 2021-08-01 * Adding Location header to LRO responses examples * Add supportedCapabilities in SnapshotUpdateProperties model (#16768) * Add supportedCapabilities in SnapshotUpdateProperties model * Add an example for update acceleratedNetwork on snapshots * Fix example model * clean up * DiskRP swagger changes for TVM and CVM of version 2021-08-01 (#16671) * DiskRP swagger changes for TVM and CVM of version 2021-08-01 * adding examples for CVM * fix errors * fix errors * fix unreferences example file * fix for: additional properties not allowed error * fix spell check error * fix spell check for secureVMDiskEncryptionSetId property * fix prettier check * addressing comment * addressing comments * DiskRP Swagger changes for Remote Restore Point scenarios (#16636) * RRP changes * Fix prettier * including communityGallery.json in package * suppress bodytoplevelproperties Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: LU WU <laurawu19@gmail.com> Co-authored-by: anshulsolanki21 <73930854+anshulsolanki21@users.noreply.github.com> Co-authored-by: sukodava <78733210+sukodava@users.noreply.github.com>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* new folder and files added for diskRP 2021-08-01 * Adding Location header to LRO responses examples * Add supportedCapabilities in SnapshotUpdateProperties model (Azure#16768) * Add supportedCapabilities in SnapshotUpdateProperties model * Add an example for update acceleratedNetwork on snapshots * Fix example model * clean up * DiskRP swagger changes for TVM and CVM of version 2021-08-01 (Azure#16671) * DiskRP swagger changes for TVM and CVM of version 2021-08-01 * adding examples for CVM * fix errors * fix errors * fix unreferences example file * fix for: additional properties not allowed error * fix spell check error * fix spell check for secureVMDiskEncryptionSetId property * fix prettier check * addressing comment * addressing comments * DiskRP Swagger changes for Remote Restore Point scenarios (Azure#16636) * RRP changes * Fix prettier * including communityGallery.json in package * suppress bodytoplevelproperties Co-authored-by: Theodore Chang <thchan@microsoft.com> Co-authored-by: LU WU <laurawu19@gmail.com> Co-authored-by: anshulsolanki21 <73930854+anshulsolanki21@users.noreply.github.com> Co-authored-by: sukodava <78733210+sukodava@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.