Moving API version 2021-07-01 for Microsoft.Solutions from RPaaSMaster to main. #16641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vayada
requested review from
ArcturusZhang,
BigCat20196,
msyyc,
qiaozha and
RAY-316
as code owners
|
Hi, @vayada Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L42 |
|
| Based on the response model schema, operation 'jitRequests_ListBySubscription' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L813 |
|
| Based on the response model schema, operation 'jitRequests_ListByResourceGroup' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L849 |
|
| Sku Model definition 'Sku' is not valid. A Sku model must have 'name' property. It can also have 'tier', 'size', 'family', 'capacity' as optional properties. Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L1336 |
|
| Guid used in model definition 'UserAssignedIdentity' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: common-types/resource-management/v3/managedidentity.json#L21 |
|
| Guid used in model definition 'ManagedServiceIdentity' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: common-types/resource-management/v3/managedidentity.json#L53 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: common-types/resource-management/v2/types.json#L359 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L1174 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: jitAccessEnabled Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L1711 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create or update managed application Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L223 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List managed application definitions Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L509 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Lists applications Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L590 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create or update jit request Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L669 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create or update jit request Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L728 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List jit requests Location: Microsoft.Solutions/stable/2021-07-01/managedapplications.json#L855 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=263274&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]
Breaking Changes Tracking
️✔️azure-sdk-for-go - resources/mgmt/2021-07-01/managedapplications - v59.1.0️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-managedapplication - first release️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-managedapplication [View full logs] [Release SDK Changes]info [Changelog] - Initial Release
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-11-09 11:44:56 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-solutions" cmderr [generate.py] 2021-11-09 11:44:56 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-11-09 11:44:56 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.39 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/solutions/azure-resourcemanager-solutions --java.namespace=com.azure.resourcemanager.solutions --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/solutions/resource-manager/readme.md cmderr [generate.py] 2021-11-09 11:45:31 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-11-09 11:45:31 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-11-09 11:45:31 INFO [POM][Skip] pom already has module azure-resourcemanager-solutions cmderr [generate.py] 2021-11-09 11:45:31 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-11-09 11:45:31 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-11-09 11:45:31 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-solutions [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-solutions-1.0.0-beta.1-sources.jar
- azure-resourcemanager-solutions-1.0.0-beta.1.jar
- azure-resourcemanager-solutions-1.0.0-beta.1-javadoc.jar
cmderr [Inst] 2021-11-09 11:47:30 DEBUG Got artifact_id: azure-resourcemanager-solutions cmderr [Inst] 2021-11-09 11:47:30 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-11-09 11:47:30 DEBUG Got artifact: azure-resourcemanager-solutions-1.0.0-beta.1-sources.jar cmderr [Inst] 2021-11-09 11:47:30 DEBUG Got artifact: azure-resourcemanager-solutions-1.0.0-beta.1.jar cmderr [Inst] 2021-11-09 11:47:30 DEBUG Match jar package: azure-resourcemanager-solutions-1.0.0-beta.1.jar cmderr [Inst] 2021-11-09 11:47:30 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16641/azure-sdk-for-java/azure-resourcemanager-solutions/azure-resourcemanager-solutions-1.0.0-beta.1.jar\" -o azure-resourcemanager-solutions-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-solutions -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-solutions-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️resources/mgmt/2021-07-01/managedapplications [View full logs] [Release SDK Changes]info [Changelog] This is a new package
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/solutions/resource-manager/readme.md
️✔️@azure/arm-managedapplications [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/applicationClient.js → ./dist/arm-managedapplications.js... cmderr [npmPack] created ./dist/arm-managedapplications.js in 336ms
This was referenced Nov 2, 2021
|
Hi @leni-msft , Can you please suggest how to fix required validation errors related to Python sdk generation? It mentions about the conflict but I am not sure how to fix that as I am not bringing azure-core 1.6.0 with my swagger change. |
|
@msyyc please help check the python sdk failure. |
Fixed. |
|
@leni-msft @msyyc has fixed it. Can you please check this now and merge if no comments. |
leni-msft
approved these changes
Nov 9, 2021
This was referenced Nov 9, 2021
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…r to main. (Azure#16641) * Moving 2021-07-01 from RPaaSMaster to Main. * Update readme.md * Update readme.python.md Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is moving api version 2021-07-01 for Microsoft.Solutions from RPSaaSMaster to main.
Submission PR for this api version in RPSaaSmaster is as follows: https://github.com/Azure/azure-rest-api-specs-pr/pull/4999
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.