Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cplat 2021 10 03 #16512

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

grizzlytheodore
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @grizzlytheodore Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully, please wait for status update in this comment.

    1 similar comment
    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully, please wait for status update in this comment.

    @ghost ghost added the Compute label Oct 22, 2021
    @grizzlytheodore grizzlytheodore merged commit 9418429 into feature/cplat-2021-10-01 Oct 22, 2021
    @grizzlytheodore grizzlytheodore deleted the feature/cplat-2021-10-03 branch December 2, 2021 17:56
    grizzlytheodore added a commit that referenced this pull request Dec 2, 2021
    * update new api version branch with base
    
    * change 2021-10-03 to 2021-10-01
    ArcturusZhang pushed a commit that referenced this pull request Feb 9, 2022
    * Feature/cplat 2021 10 03 (#16512)
    
    * update new api version branch with base
    
    * change 2021-10-03 to 2021-10-01
    
    * Update readme.md
    
    * fix folder structure
    
    * add community gallery
    
    * Feature/cplat 2021 10 03 (#16512)
    
    * update new api version branch with base
    
    * change 2021-10-03 to 2021-10-01
    
    * Update readme.md
    
    * fix folder structure
    
    * add community gallery
    
    * remove sharedGallery and communityGallery
    
    * Gallery 10-01 change (community gallery, CVM) (#16824)
    
    * add new api version 2020-09-30 for gallery.json
    
    * add support for api change, sharing profile related
    
    * update, change post to patch
    
    * fix model validation error
    
    * fix typo
    
    * add shared gallery api
    
    * update
    
    * fix typo
    
    * update
    
    * update
    
    * update
    
    * chagne new api version to preview
    
    * update readme.md and nit
    
    * remove some required field and make groups readonly
    
    * add swagger support for Grace's and Tim's work
    
    * error fix
    
    * error fix
    
    * change api version name to 2020-09-30 withour 'preview'
    
    * update
    
    * fix typo
    
    * address pr comment
    
    * set modelAsString to true for gallery sharing-related enum
    
    * update, fix merge
    
    * remove duplicate entry
    
    * shared gallery, change id to identifier.uniqueId
    
    * fix typo
    
    * update, remove x-ms-azure-resource for shared gallery
    
    * change name of Permissions to avoid SDK code build error
    
    * update
    
    * add new line
    
    * correct reset
    
    * update
    
    * save
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * update
    
    * resolve CI error
    
    * update
    
    * Edge zone (#17097)
    
    * added target extended locations to the caps gallery schema and added an example file
    
    * fixed a comma
    
    * Update readme.md
    
    * Rename specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/gallery/CreateOrUpdateASimpleGalleryImageVersionWithTargetExtendedLocations.json to specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/examples/gallery/CreateOrUpdateASimpleGalleryImageVersionWithTargetExtendedLocations.json
    
    * Update readme.md
    
    * update
    
    * address comment
    
    * resolve CI
    
    Co-authored-by: Andrew Sager <asager@microsoft.com>
    Co-authored-by: Theodore Chang <thchan@microsoft.com>
    
    * save (#17600)
    
    Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com>
    Co-authored-by: Andrew Sager <asager@microsoft.com>
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022
    * Feature/cplat 2021 10 03 (Azure#16512)
    
    * update new api version branch with base
    
    * change 2021-10-03 to 2021-10-01
    
    * Update readme.md
    
    * fix folder structure
    
    * add community gallery
    
    * Feature/cplat 2021 10 03 (Azure#16512)
    
    * update new api version branch with base
    
    * change 2021-10-03 to 2021-10-01
    
    * Update readme.md
    
    * fix folder structure
    
    * add community gallery
    
    * remove sharedGallery and communityGallery
    
    * Gallery 10-01 change (community gallery, CVM) (Azure#16824)
    
    * add new api version 2020-09-30 for gallery.json
    
    * add support for api change, sharing profile related
    
    * update, change post to patch
    
    * fix model validation error
    
    * fix typo
    
    * add shared gallery api
    
    * update
    
    * fix typo
    
    * update
    
    * update
    
    * update
    
    * chagne new api version to preview
    
    * update readme.md and nit
    
    * remove some required field and make groups readonly
    
    * add swagger support for Grace's and Tim's work
    
    * error fix
    
    * error fix
    
    * change api version name to 2020-09-30 withour 'preview'
    
    * update
    
    * fix typo
    
    * address pr comment
    
    * set modelAsString to true for gallery sharing-related enum
    
    * update, fix merge
    
    * remove duplicate entry
    
    * shared gallery, change id to identifier.uniqueId
    
    * fix typo
    
    * update, remove x-ms-azure-resource for shared gallery
    
    * change name of Permissions to avoid SDK code build error
    
    * update
    
    * add new line
    
    * correct reset
    
    * update
    
    * save
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * update
    
    * resolve CI error
    
    * update
    
    * Edge zone (Azure#17097)
    
    * added target extended locations to the caps gallery schema and added an example file
    
    * fixed a comma
    
    * Update readme.md
    
    * Rename specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/gallery/CreateOrUpdateASimpleGalleryImageVersionWithTargetExtendedLocations.json to specification/compute/resource-manager/Microsoft.Compute/stable/2021-10-01/examples/gallery/CreateOrUpdateASimpleGalleryImageVersionWithTargetExtendedLocations.json
    
    * Update readme.md
    
    * update
    
    * address comment
    
    * resolve CI
    
    Co-authored-by: Andrew Sager <asager@microsoft.com>
    Co-authored-by: Theodore Chang <thchan@microsoft.com>
    
    * save (Azure#17600)
    
    Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com>
    Co-authored-by: Andrew Sager <asager@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants