Merging ConnectedVMwarevSphere changes from azure-rest-api-specs-pr private repo... #16088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subbartt
requested review from
00Kai0,
ArcturusZhang,
jsntcy,
msyyc,
qiaozha and
RAY-316
as code owners
|
Hi, @subbartt Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'HybridIdentityMetadataModel'. Consider using the plural form of 'HybridIdentityMetadata' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L3080 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'HybridIdentityMetadataModel'. Consider using the plural form of 'HybridIdentityMetadata' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L3146 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'HybridIdentityMetadataModel'. Consider using the plural form of 'HybridIdentityMetadata' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L3201 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'HybridIdentityMetadataModel'. Consider using the plural form of 'HybridIdentityMetadata' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L3258 |
|
| The child tracked resource, 'hybridIdentityMetadata' with immediate parent 'VirtualMachine', must have a list by immediate parent operation. Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L6261 |
|
| The child tracked resource, 'extensions' with immediate parent 'VirtualMachine', must have a list by immediate parent operation. Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L6341 |
|
| The child tracked resource, 'guestAgents' with immediate parent 'VirtualMachine', must have a list by immediate parent operation. Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L6627 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L285 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L611 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L937 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L1263 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L1589 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L1922 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L2403 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L2729 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cpuHotAddEnabled Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L4420 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cpuHotRemoveEnabled Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L4425 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: memoryHotAddEnabled Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L4430 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: skipShutdown Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L4862 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L5867 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: autoUpgradeMinorVersion Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L6422 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: autoUpgradeMinorVersion Location: Microsoft.ConnectedVMwarevSphere/preview/2020-10-01-preview/connectedvmware.json#L6470 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi @subbartt, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Sep 19, 2021
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @subbartt your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
subbartt
added
the
DoNotMerge
…into dev/subbart/connectedvmwaremerge
subbartt
removed
the
DoNotMerge
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@subbartt, thanks for including the very helpful context. I've looked at the changes. Some of the changes you are making here (removing two resource type endpoints, adding properties to existing resource types) require a new API version. To get ARM review on a new API version, you will need to make a new PR and ensure that the first commit is the unchanged previous API version files (the ones from the private repo). |
mentat9
added
the
ARMChangesRequested
|
Hi @subbartt, Your PR has some issues. Please fix the CI sequentially by following the order of
|
@mentat9 , adding new properties already PR in private repo and merged today https://github.com/Azure/azure-rest-api-specs-pr/pull/4931. Also after discussing with team internally we have decided not to remove any endpoints. Now both private repo swagger and public repo swagger are exactly the same ( except few lint fixes). |
subbartt
removed
the
ARMChangesRequested
mentat9
added
ARMSignedOff
|
@mentat9 , can you please help merge the PR? we are good to merge and move onto next steps. |
ARM team doesn't approve or merge PRs. The SDK owners and assignee @akning-ms will move it forward. |
This was referenced Oct 1, 2021
Closed
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Oct 1, 2021
…om azure-rest-api-specs-pr private repo... (#1943) Create to sync Azure/azure-rest-api-specs#16088 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/connectedvmware?expand=1)
jovannikolov-msft
pushed a commit
to jovannikolov-msft/azure-rest-api-specs
that referenced
this pull request
Dec 1, 2021
…rivate repo... (Azure#16088) * Merging connectedvmware swagger from pr branch * minor updates * minor update * fixing lint warnings * updates * sync latest from private repo * copy examples from private repo
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…rivate repo... (Azure#16088) * Merging connectedvmware swagger from pr branch * minor updates * minor update * fixing lint warnings * updates * sync latest from private repo * copy examples from private repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Microsoft.ConnectedVMwarevSphere is in private preview and we are targeting for public preview by Oct end. All the changes are already ARM approved and signed off. This PR is to merge those changes to the public repo to get ready for the public preview. Here are the approved changes https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/connectedvmware. All the changes are exactly same as https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/connectedvmware which are already ARM reviewed and approved. There were few lint issues were fixed and hybridmetadata resource we are not using to public preview.
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
Oct end 2021
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
Oct end 2021
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.