Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Rename types for better SDK code #16039

Merged
merged 12 commits into from
Sep 28, 2021
Merged

[Search] Rename types for better SDK code #16039

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fffc0b8
Rename types for better SDK code
Mohit-Chakraborty Sep 14, 2021
d543551
Merge remote-tracking branch 'origin/main' into mohitc/SearchSdkRenames
Mohit-Chakraborty Sep 14, 2021
52fd4a9
Rename Speller and Captions search options
Mohit-Chakraborty Sep 15, 2021
95c74c1
Reorder parameters to have consistency across APIs
Mohit-Chakraborty Sep 15, 2021
9cd36f7
Remove 'SearchIndexer' prefix from projection selectors
Mohit-Chakraborty Sep 20, 2021
5c34638
Change enum name AdlsGen2->AzureDataLakeStorageGen2
Mohit-Chakraborty Sep 21, 2021
964d6b3
move additional .NET SDK renames to the REST spec
Mohit-Chakraborty Sep 23, 2021
67ac832
Revert changes in KnowledgeStore which has GAed
Mohit-Chakraborty Sep 23, 2021
d034a2e
Revert changes in CustomEntityLookupSkill which has GAed
Mohit-Chakraborty Sep 23, 2021
12451c8
Revert changes in SIKSBlobProjectionSelector which has GAed
Mohit-Chakraborty Sep 23, 2021
7c332cd
Revert changes in SearchIndexerDataSourceType which has GAed
Mohit-Chakraborty Sep 23, 2021
64569c4
Rename ignoreResetRequirements->skipIndexerResetRequirementForCache
Mohit-Chakraborty Sep 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move additional .NET SDK renames to the REST spec
  • Loading branch information
@Mohit-Chakraborty
Mohit-Chakraborty committed Sep 23, 2021
commit 964d6b3c7759d9d2c5f3ee02b02d126ab4eb0258
5 changes: 4 additions & 1 deletion specification/search/data-plane/Azure.Search/preview/2021-04-30-Preview/searchservice.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7569,6 +7569,7 @@
"description": "Base type for describing any cognitive service resource attached to a skillset."
},
"SearchIndexerKnowledgeStore": {
"x-ms-client-name" : "KnowledgeStore",
"properties": {
"storageConnectionString": {
"type": "string",
Expand All @@ -7593,6 +7594,7 @@
"description": "Definition of additional projections to azure blob, table, or files, of enriched data."
},
"SearchIndexerKnowledgeStoreProjection": {
"x-ms-client-name" : "KnowledgeStoreProjection",
"properties": {
"tables": {
"type": "array",
Expand Down Expand Up @@ -7622,6 +7624,7 @@
"description": "Container object for various projection selectors."
},
"SearchIndexerKnowledgeStoreProjectionSelector": {
"x-ms-client-name" : "KnowledgeStoreProjectionSelector",
"properties": {
"referenceKeyName": {
"type": "string",
Expand Down Expand Up @@ -7650,7 +7653,7 @@
"description": "Abstract class to share properties between concrete selectors."
},
"SearchIndexerKnowledgeStoreBlobProjectionSelector": {
"x-ms-client-name" : "KnowledgeStoreBlobProjectionSelector",
"x-ms-client-name" : "KnowledgeStoreStorageProjectionSelector",
"properties": {
"storageContainer": {
"x-ms-client-name" : "storageContainerName",
Expand Down