Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new API version 2021-08-01 for Data Share #16021

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Add new API version 2021-08-01 for Data Share #16021

merged 1 commit into from
Sep 14, 2021

Conversation

zachcmadsen
Copy link
Contributor

@zachcmadsen zachcmadsen commented Sep 13, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @zachcmadsen Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 13, 2021

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
    Rule Message
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DataShare/stable/2019-11-01/DataShare.json#L993:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DataShare/stable/2019-11-01/DataShare.json#L1043:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L999:5
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L1049:5
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Accounts_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L67
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'ConsumerInvitations_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L359
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'DataSets_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L457
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'DataSetMappings_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L732
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Invitations_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L1091
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'ProviderShareSubscriptions_GetByShare' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L1740
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Shares_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L1857
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'ShareSubscriptions_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L2507
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'SynchronizationSettings_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L2742
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Triggers_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L2991
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Accounts_Create' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L108
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'DataSets_Create' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L512
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'DataSetMappings_Create' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L787
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Invitations_Create' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L1146
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Shares_Create' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L1905
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'ShareSubscriptions_Create' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L2555
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'SynchronizationSettings_Create' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L2797
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Triggers_Create' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L3046
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Accounts_Update' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2020-09-01/DataShare.json#L213
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Accounts_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L67
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'ConsumerInvitations_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L359
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'DataSets_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L457
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'DataSetMappings_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L735
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Invitations_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L1094
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'ProviderShareSubscriptions_GetByShare' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L1743
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Shares_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L1860
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'ShareSubscriptions_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L2510
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'SynchronizationSettings_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L2745
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Triggers_Get' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L2994
    R4009 - RequiredReadOnlySystemData The property systemData in the response of operation:'Accounts_Create' is not read only. Please add the readonly for the systemData.
    Location: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L108
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 32 Warnings warning [Detail]
    The following breaking changes are detected by comparison with latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ADLSGen2StorageAccountDataSet' removed or renamed?
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L3244:3
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L3162:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ADLSGen2StorageAccountDataSetMapping' removed or renamed?
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L3244:3
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L3162:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'BlobStorageAccountDataSet' removed or renamed?
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L3244:3
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L3162:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'BlobStorageAccountDataSetMapping' removed or renamed?
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L3244:3
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L3162:3
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4636:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4878:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L6738:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L6803:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4537:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4777:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4636:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4878:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4636:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4878:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4636:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4878:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4636:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4878:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4636:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4878:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4636:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4878:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4636:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4878:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4636:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4878:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4636:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4878:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4576:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4817:9
    ⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'AdlsGen2StorageAccount, BlobStorageAccount' from the old version.
    New: Microsoft.DataShare/stable/2021-08-01/DataShare.json#L4636:9
    Old: Microsoft.DataShare/preview/2020-10-01-preview/DataShare.json#L4878:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 13, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-datashare - 1.0.0
    ️✔️azure-sdk-for-go - datashare/mgmt/2019-11-01/datashare - v57.2.0
    ️✔️azure-sdk-for-go - preview/datashare/mgmt/2018-11-01-preview/datashare - v57.2.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9572eff. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datashare/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.DataShare [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9572eff. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-datashare [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group EmailRegistrationsOperations
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9572eff. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️datashare/mgmt/2019-11-01/datashare [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `ActivationAttemptsExhausted`
      info	[Changelog] - New const `ActivationPending`
      info	[Changelog] - New const `Activated`
      info	[Changelog] - New function `EmailRegistrationsClient.RegisterEmailSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `EmailRegistrationsClient.RegisterEmailPreparer(context.Context, string) (*http.Request, error)`
      info	[Changelog] - New function `PossibleRegistrationStatusValues() []RegistrationStatus`
      info	[Changelog] - New function `EmailRegistrationsClient.RegisterEmail(context.Context, string) (EmailRegistration, error)`
      info	[Changelog] - New function `EmailRegistrationsClient.RegisterEmailResponder(*http.Response) (EmailRegistration, error)`
      info	[Changelog] - New function `EmailRegistrationsClient.ActivateEmailPreparer(context.Context, string, EmailRegistration) (*http.Request, error)`
      info	[Changelog] - New function `EmailRegistrationsClient.ActivateEmailSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `EmailRegistrationsClient.ActivateEmail(context.Context, string, EmailRegistration) (EmailRegistration, error)`
      info	[Changelog] - New function `EmailRegistration.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `NewEmailRegistrationsClientWithBaseURI(string, string) EmailRegistrationsClient`
      info	[Changelog] - New function `NewEmailRegistrationsClient(string) EmailRegistrationsClient`
      info	[Changelog] - New function `EmailRegistrationsClient.ActivateEmailResponder(*http.Response) (EmailRegistration, error)`
      info	[Changelog] - New struct `EmailRegistration`
      info	[Changelog] - New struct `EmailRegistrationsClient`
      info	[Changelog] - New field `FillGapWithZero` in struct `OperationMetaMetricSpecification`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 20 additive change(s).
      info	[Changelog]
    • ️✔️preview/datashare/mgmt/2018-11-01-preview/datashare [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New field `FillGapWithZero` in struct `OperationMetaMetricSpecification`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
      info	[Changelog]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    Copy link
    Contributor

    @j5lim j5lim left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    It's just to merge an already approved private repo pr. Approved from ARM side.

    @j5lim j5lim added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 13, 2021
    @chunyu3 chunyu3 merged commit 9572eff into Azure:main Sep 14, 2021
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    Co-authored-by: Zach Madsen <zachmadsen@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants