[Hub Generated] Review request for Microsoft.Security to add version preview/2021-07-01-preview #15857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @kerend Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"readme":"security/resource-manager/readme.md", "tag":"package-composite-v1", "details":"Error: Semantic validation failed. There was some errors" |
|
"readme":"security/resource-manager/readme.md", "tag":"package-composite-v2", "details":"Error: Semantic validation failed. There was some errors" |
|
"readme":"security/resource-manager/readme.md", "tag":"package-composite-v3", "details":"Error: Plugin prechecker reported failure." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @kerend, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Aug 30, 2021
This was referenced Aug 30, 2021
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @kerend your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
| }, | ||
| "/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.Security/customAssessmentAutomations": { | ||
| "get": { | ||
| "summary": "List custom assessment automations", |
There was a problem hiding this comment.
Define x-ms-paging on collection API. Currently even if you don't need/support paging, by declaring the paging constructs, you can enable paging in future with out introducing a new api version.
There was a problem hiding this comment.
Comment applicable in other places too.
RamyasreeChakka
added
ARMSignedOff
|
@kerend - Reviewed delta changes from previous api version. Changes LGTM. Approved with some suggestions. |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
This was referenced Sep 22, 2021
25 tasks
Hardell
pushed a commit
to Hardell/azure-rest-api-specs
that referenced
this pull request
Sep 27, 2021
…preview/2021-07-01-preview (Azure#15857) * Adds base for updating Microsoft.Security from version preview/2021-05-01-preview to version 2021-07-01-preview * Updates readme * Updates API version in new specs and examples * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * .
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…preview/2021-07-01-preview (Azure#15857) * Adds base for updating Microsoft.Security from version preview/2021-05-01-preview to version 2021-07-01-preview * Updates readme * Updates API version in new specs and examples * . * . * . * . * . * . * . * . * . * . * . * . * . * . * . * .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.