[HDInsight] Onboard a new api version 2021-06-01 for HDInsight #15815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 27, 2021 15:30
…review change efficiently
…as required, Add 201 schema for private endpoint connection put response, and modify resource definition
… in the result and change some properties to CamelCase style
|
Hi, @aim-for-better Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Based on the response model schema, operation 'PrivateLinkResources_ListByCluster' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.HDInsight/stable/2021-06-01/privateLinkResources.json#L38 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: primary Location: Microsoft.HDInsight/stable/2021-06-01/cluster.json#L2128 |
The following errors/warnings exist before current PR submission:
Only 23 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.HDInsight/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.HDInsight/stable/2021-06-01/operations.json#L37 |
| 'PUT' operation 'Extensions_EnableMonitoring' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.HDInsight/stable/2021-06-01/extensions.json#L48 |
|
| 'PUT' operation 'Extensions_EnableAzureMonitor' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.HDInsight/stable/2021-06-01/extensions.json#L190 |
|
| 'DELETE' operation 'Extensions_DisableMonitoring' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.HDInsight/stable/2021-06-01/extensions.json#L141 |
|
| 'DELETE' operation 'Extensions_DisableAzureMonitor' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.HDInsight/stable/2021-06-01/extensions.json#L283 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.HDInsight/stable/2021-06-01/cluster.json#L1372 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.HDInsight/stable/2021-06-01/cluster.json#L1613 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.HDInsight/stable/2021-06-01/applications.json#L459 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.HDInsight/stable/2021-06-01/operations.json#L82 |
|
| A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Clusters_Create' Request Model: 'ClusterCreateParametersExtended' Response Model: 'Cluster' Location: Microsoft.HDInsight/stable/2021-06-01/cluster.json#L38 |
|
| A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Extensions_EnableMonitoring' Request Model: 'ClusterMonitoringRequest' Response Model: '' Location: Microsoft.HDInsight/stable/2021-06-01/extensions.json#L38 |
|
| A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Extensions_EnableAzureMonitor' Request Model: 'AzureMonitorRequest' Response Model: '' Location: Microsoft.HDInsight/stable/2021-06-01/extensions.json#L180 |
|
| A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Extensions_Create' Request Model: 'Extension' Response Model: '' Location: Microsoft.HDInsight/stable/2021-06-01/extensions.json#L322 |
|
| Based on the response model schema, operation 'Locations_ListUsages' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.HDInsight/stable/2021-06-01/locations.json#L77 |
|
| 200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'Extensions_EnableMonitoring', Response code: '200' Location: Microsoft.HDInsight/stable/2021-06-01/extensions.json#L79 |
|
| 200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'Extensions_EnableAzureMonitor', Response code: '200' Location: Microsoft.HDInsight/stable/2021-06-01/extensions.json#L221 |
|
| 200/201 Responses of long running operations must have a schema definition for return type. OperationId: 'Extensions_Create', Response code: '200' Location: Microsoft.HDInsight/stable/2021-06-01/extensions.json#L366 |
|
| OperationId should contain the verb: 'updateclusteridentitycertificate' in:'Clusters_UpdateIdentityCertificate'. Consider updating the operationId Location: Microsoft.HDInsight/stable/2021-06-01/cluster.json#L694 |
|
| OperationId should contain the verb: 'validatecreaterequest' in:'Locations_ValidateClusterCreateRequest'. Consider updating the operationId Location: Microsoft.HDInsight/stable/2021-06-01/locations.json#L248 |
|
| OperationId should contain the verb: 'configurations' in:'Configurations_List'. Consider updating the operationId Location: Microsoft.HDInsight/stable/2021-06-01/configurations.json#L42 |
|
| OperationId should contain the verb: '{configurationname}' in:'Configurations_Update'. Consider updating the operationId Location: Microsoft.HDInsight/stable/2021-06-01/configurations.json#L84 |
|
| The child tracked resource, 'azureasyncoperations' with immediate parent 'Cluster', must have a list by immediate parent operation. Location: Microsoft.HDInsight/stable/2021-06-01/cluster.json#L1973 |
|
| The child tracked resource, 'azureasyncoperations' with immediate parent 'Application', must have a list by immediate parent operation. Location: Microsoft.HDInsight/stable/2021-06-01/cluster.json#L1973 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The JSON file has a circular reference. readme: specification/hdinsight/resource-manager/readme.md json: Microsoft.HDInsight/stable/2021-06-01/scriptActions.json |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 13 Errors, 608 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.0)
- current:stable/2021-06-01/applications.json compared with base:stable/2018-06-01-preview/applications.json
- current:stable/2021-06-01/applications.json compared with base:preview/2015-03-01-preview/applications.json
- current:stable/2021-06-01/cluster.json compared with base:stable/2018-06-01-preview/cluster.json
- current:stable/2021-06-01/cluster.json compared with base:preview/2015-03-01-preview/cluster.json
- current:stable/2021-06-01/configurations.json compared with base:stable/2018-06-01-preview/configurations.json
- current:stable/2021-06-01/configurations.json compared with base:preview/2015-03-01-preview/configurations.json
- current:stable/2021-06-01/extensions.json compared with base:stable/2018-06-01-preview/extensions.json
- current:stable/2021-06-01/extensions.json compared with base:preview/2015-03-01-preview/extensions.json
- current:stable/2021-06-01/locations.json compared with base:stable/2018-06-01-preview/locations.json
- current:stable/2021-06-01/locations.json compared with base:preview/2015-03-01-preview/locations.json
- current:stable/2021-06-01/operations.json compared with base:stable/2018-06-01-preview/operations.json
- current:stable/2021-06-01/operations.json compared with base:preview/2015-03-01-preview/operations.json
- current:stable/2021-06-01/scriptActions.json compared with base:stable/2018-06-01-preview/scriptActions.json
- current:stable/2021-06-01/scriptActions.json compared with base:preview/2015-03-01-preview/scriptActions.json
- current:stable/2021-06-01/virtualMachines.json compared with base:stable/2018-06-01-preview/virtualMachines.json
- current:stable/2021-06-01/virtualMachines.json compared with base:preview/2015-03-01-preview/virtualMachines.json
Only 23 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with latest preview version:
Only 23 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 1 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"hdinsight/resource-manager/readme.md", "tag":"package-2021-06", "details":"Error: Plugin prechecker reported failure." |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
"readme":"hdinsight/resource-manager/readme.md", "tag":"package-2018-06-preview", "details":"Error: Plugin prechecker reported failure." |
|
"readme":"hdinsight/resource-manager/readme.md", "tag":"package-2015-03-preview", "details":"Error: Plugin prechecker reported failure." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=252941&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
️✔️azure-sdk-for-go - hdinsight/mgmt/2018-06-01/hdinsight - v57.2.0❌azure-sdk-for-go - preview/hdinsight/mgmt/2015-03-01-preview/hdinsight - v57.2.0+ Field `VMSizeFilters` of struct `CapabilitiesResult` has been removed + Field `VMSizes` of struct `CapabilitiesResult` has been removed + Field `Vmsizes` of struct `VMSizeCompatibilityFilter` has been removed + Field `autorest.Response` of struct `Extension` has been removed + Function `ExtensionClient.CreateSender` return value(s) have been changed from `(*http.Response, error)` to `(ExtensionCreateFuture, error)` + Function `ExtensionClient.Create` return value(s) have been changed from `(autorest.Response, error)` to `(ExtensionCreateFuture, error)` + Function `ExtensionClient.DeleteSender` return value(s) have been changed from `(*http.Response, error)` to `(ExtensionDeleteFuture, error)` + Function `ExtensionClient.Delete` return value(s) have been changed from `(autorest.Response, error)` to `(ExtensionDeleteFuture, error)` + Function `ExtensionClient.GetResponder` return value(s) have been changed from `(Extension, error)` to `(ClusterMonitoringResponse, error)` + Function `ExtensionClient.Get` return value(s) have been changed from `(Extension, error)` to `(ClusterMonitoringResponse, error)` + Struct `OperationResource` has been removed + Type of `Usage.CurrentValue` has been changed from `*int32` to `*int64` + Type of `Usage.Limit` has been changed from `*int32` to `*int64` + Type of `VersionSpec.IsDefault` has been changed from `*string` to `*bool`
❌azure-sdk-for-python-track2 - track2_azure-mgmt-hdinsight - 8.0.0+ Model CapabilitiesResult no longer has parameter vmsize_filters + Model CapabilitiesResult no longer has parameter vmsizes + Parameter location of model Cluster is now required + Parameter location of model TrackedResource is now required
️❌ azure-sdk-for-net failed [Detail]
warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/hdinsight/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
❌Microsoft.Azure.Management.HDInsight [View full logs] [Release SDK Changes]cmdout [msbuild] 2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,35): error CS0722: 'Tier': static types cannot be used as return types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] 2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,40): error CS0721: 'Tier': static types cannot be used as parameters [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] 2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,35): error CS0722: 'Tier': static types cannot be used as return types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] 2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,40): error CS0721: 'Tier': static types cannot be used as parameters [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] 2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,35): error CS0722: 'Tier': static types cannot be used as return types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] 2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,40): error CS0721: 'Tier': static types cannot be used as parameters [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] 2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,35): error CS0722: 'Tier': static types cannot be used as return types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] 2>/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,40): error CS0721: 'Tier': static types cannot be used as parameters [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,35): error CS0722: 'Tier': static types cannot be used as return types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,40): error CS0721: 'Tier': static types cannot be used as parameters [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,35): error CS0722: 'Tier': static types cannot be used as return types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,40): error CS0721: 'Tier': static types cannot be used as parameters [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,35): error CS0722: 'Tier': static types cannot be used as return types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,40): error CS0721: 'Tier': static types cannot be used as parameters [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,35): error CS0722: 'Tier': static types cannot be used as return types [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Customizations/Models/ClusterCreateParameters.cs(132,40): error CS0721: 'Tier': static types cannot be used as parameters [/home/vsts/work/1/s/azure-sdk-for-net/sdk/hdinsight/Microsoft.Azure.Management.HDInsight/src/Microsoft.Azure.Management.HDInsight.csproj] error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️hdinsight/mgmt/2018-06-01/hdinsight [View full logs] [Release SDK Changes]info [Changelog] No exported changes
- Only show 60 items here, please refer to log for details.
️✔️preview/hdinsight/mgmt/2015-03-01-preview/hdinsight [View full logs] Breaking Change Detectedinfo [Changelog] - New function `ExtensionsClient.GetAzureMonitorStatusSender(*http.Request) (*http.Response, error)` info [Changelog] - New function `*VirtualMachinesRestartHostsFuture.UnmarshalJSON([]byte) error` info [Changelog] - New function `VirtualMachinesClient.ListHosts(context.Context, string, string) (ListHostInfo, error)` info [Changelog] - New function `KafkaRestProperties.MarshalJSON() ([]byte, error)` info [Changelog] - New struct `AaddsResourceDetails` info [Changelog] - New struct `AsyncOperationResult` info [Changelog] - New struct `AzureMonitorRequest` info [Changelog] - New struct `AzureMonitorResponse` info [Changelog] - New struct `AzureMonitorSelectedConfigurations` info [Changelog] - New struct `AzureMonitorTableConfiguration` info [Changelog] - New struct `ClusterCreateRequestValidationParameters` info [Changelog] - New struct `ClusterCreateValidationResult` info [Changelog] - New struct `ClustersUpdateIdentityCertificateFuture` info [Changelog] - New struct `ComputeIsolationProperties` info [Changelog] - New struct `Dimension` info [Changelog] - New struct `ExcludedServicesConfig` info [Changelog] - New struct `ExtensionCreateFuture` info [Changelog] - New struct `ExtensionDeleteFuture` info [Changelog] - New struct `ExtensionsClient` info [Changelog] - New struct `ExtensionsDisableAzureMonitorFuture` info [Changelog] - New struct `ExtensionsEnableAzureMonitorFuture` info [Changelog] - New struct `HostInfo` info [Changelog] - New struct `ListHostInfo` info [Changelog] - New struct `MetricSpecifications` info [Changelog] - New struct `NameAvailabilityCheckRequestParameters` info [Changelog] - New struct `NameAvailabilityCheckResult` info [Changelog] - New struct `OperationProperties` info [Changelog] - New struct `ServiceSpecification` info [Changelog] - New struct `UpdateClusterIdentityCertificateParameters` info [Changelog] - New struct `VMSizeProperty` info [Changelog] - New struct `ValidationErrorInfo` info [Changelog] - New struct `VirtualMachinesClient` info [Changelog] - New struct `VirtualMachinesRestartHostsFuture` info [Changelog] - New field `ConfigurationOverride` in struct `KafkaRestProperties` info [Changelog] - New field `Saskey` in struct `StorageAccount` info [Changelog] - New field `Fileshare` in struct `StorageAccount` info [Changelog] - New field `PrivateIPAddress` in struct `ApplicationGetEndpoint` info [Changelog] - New field `Description` in struct `OperationDisplay` info [Changelog] - New field `ComputeIsolationProperties` in struct `ClusterCreateProperties` info [Changelog] - New field `VMSizeProperties` in struct `BillingResponseListResult` info [Changelog] - New field `VMSizesWithEncryptionAtHost` in struct `BillingResponseListResult` info [Changelog] - New field `ComputeIsolationSupported` in struct `VMSizeCompatibilityFilter` info [Changelog] - New field `OsType` in struct `VMSizeCompatibilityFilter` info [Changelog] - New field `ESPApplied` in struct `VMSizeCompatibilityFilter` info [Changelog] - New field `VMSizes` in struct `VMSizeCompatibilityFilter` info [Changelog] - New field `PrivateIPAddress` in struct `ConnectivityEndpoint` info [Changelog] - New field `VmsizeFilters` in struct `CapabilitiesResult` info [Changelog] - New field `Vmsizes` in struct `CapabilitiesResult` info [Changelog] - New field `PrivateIPAddress` in struct `ApplicationGetHTTPSEndpoint` info [Changelog] - New field `Properties` in struct `Operation` info [Changelog] - New field `ClusterHdpVersion` in struct `ClusterGetProperties` info [Changelog] - New field `ExcludedServicesConfig` in struct `ClusterGetProperties` info [Changelog] - New field `ComputeIsolationProperties` in struct `ClusterGetProperties` info [Changelog] - New field `StorageProfile` in struct `ClusterGetProperties` info [Changelog] - New field `TenantID` in struct `ClusterIdentityUserAssignedIdentitiesValue` info [Changelog] - New field `VMGroupName` in struct `Role` info [Changelog] - New field `EncryptDataDisks` in struct `Role` info [Changelog] info [Changelog] Total 13 breaking change(s), 146 additive change(s). info [Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-09-14 09:18:07 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-hdinsight;1.0.0-beta.4;1.0.0-beta.5" cmderr [generate.py] 2021-09-14 09:18:07 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.5" cmderr [generate.py] 2021-09-14 09:18:07 INFO autorest --version=3.6.0 --use=@autorest/java@4.0.37 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/hdinsight/azure-resourcemanager-hdinsight --java.namespace=com.azure.resourcemanager.hdinsight --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/hdinsight/resource-manager/readme.md cmderr [generate.py] 2021-09-14 09:18:51 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-hdinsight cmderr [generate.py] 2021-09-14 09:18:51 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-09-14 09:18:51 INFO [POM][Skip] pom already has module azure-resourcemanager-hdinsight cmderr [generate.py] 2021-09-14 09:18:51 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-09-14 09:18:51 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-09-14 09:18:51 INFO [POM][Skip] pom already has module sdk/hdinsight cmderr [generate.py] 2021-09-14 09:18:51 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-hdinsight [View full logs] [Release SDK Changes]- pom.xml
- azure-resourcemanager-hdinsight-1.0.0-beta.5-sources.jar
- azure-resourcemanager-hdinsight-1.0.0-beta.5-javadoc.jar
- azure-resourcemanager-hdinsight-1.0.0-beta.5.jar
cmderr [Inst] 2021-09-14 09:22:10 DEBUG Got artifact_id: azure-resourcemanager-hdinsight cmderr [Inst] 2021-09-14 09:22:10 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-09-14 09:22:10 DEBUG Got artifact: azure-resourcemanager-hdinsight-1.0.0-beta.5-sources.jar cmderr [Inst] 2021-09-14 09:22:10 DEBUG Got artifact: azure-resourcemanager-hdinsight-1.0.0-beta.5-javadoc.jar cmderr [Inst] 2021-09-14 09:22:10 DEBUG Got artifact: azure-resourcemanager-hdinsight-1.0.0-beta.5.jar cmderr [Inst] 2021-09-14 09:22:10 DEBUG Match jar package: azure-resourcemanager-hdinsight-1.0.0-beta.5.jar cmderr [Inst] 2021-09-14 09:22:10 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15815/azure-sdk-for-java/azure-resourcemanager-hdinsight/azure-resourcemanager-hdinsight-1.0.0-beta.5.jar\" -o azure-resourcemanager-hdinsight-1.0.0-beta.5.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-hdinsight -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-hdinsight-1.0.0-beta.5.jar -Dpackaging=jar -DgeneratePom=true ```"}
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-hdinsight [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Model ClusterCreateParametersExtended has a new parameter zones info [Changelog] - Model Cluster has a new parameter zones info [Changelog] - Model Cluster has a new parameter system_data info [Changelog] - Model ClusterCreateProperties has a new parameter private_link_configurations info [Changelog] - Model VmSizeCompatibilityFilterV2 has a new parameter compute_isolation_supported info [Changelog] - Model VmSizeCompatibilityFilterV2 has a new parameter esp_applied info [Changelog] - Model Application has a new parameter system_data info [Changelog] - Model ClusterCreateRequestValidationParameters has a new parameter zones info [Changelog] - Model ApplicationProperties has a new parameter private_link_configurations info [Changelog] - Model ClusterGetProperties has a new parameter private_endpoint_connections info [Changelog] - Model ClusterGetProperties has a new parameter private_link_configurations info [Changelog] - Added operation group PrivateLinkResourcesOperations info [Changelog] - Added operation group PrivateEndpointConnectionsOperations info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Parameter location of model Cluster is now required info [Changelog] - Parameter location of model TrackedResource is now required info [Changelog] - Model CapabilitiesResult no longer has parameter vmsizes info [Changelog] - Model CapabilitiesResult no longer has parameter vmsize_filters
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/hdinsight/resource-manager/readme.md
️✔️@azure/arm-hdinsight [View full logs] [Release SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/hDInsightManagementClient.js → ./dist/arm-hdinsight.js... cmderr [npmPack] created ./dist/arm-hdinsight.js in 574ms
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️hdinsight [View full logs] [Release Schema Changes]
|
Hi, @aim-for-better your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi @aim-for-better, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Aug 27, 2021
This was referenced Aug 27, 2021
aim-for-better
force-pushed
the
Onboard20210601ForHDInsight
branch
2 times, most recently
from
78d8e2d
to
adbbf88
Compare
aim-for-better
force-pushed
the
Onboard20210601ForHDInsight
branch
from
adbbf88
to
1485883
Compare
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
The remain ci errors are not required, and some are expected. |
|
@aim-for-better Reviewed the delta changes from previous API version. Changes LGTM. Signing off from ARM side. Please follow up with breaking change team for breaking change approval. |
RamyasreeChakka
added
ARMSignedOff
Hi @RamyasreeChakka Thanks~ |
|
We are still on the breaking change review step. |
JeffreyRichter
added
the
Approved-BreakingChange
|
Hi @jianyexi could you please help merge this PR? |
|
@zhenglaizhang help with the APIDocPreivew failure |
|
Hi @zhenglaizhang Thanks for your quick response. I checked the history and found that that operation id is expected. @jianyexi let us merge this PR firstly. I will follow up the doc generation step. |
jianyexi
suggested changes
Sep 14, 2021
specification/common-types/resource-management/v2/privatelinks.json
Outdated
Show resolved
Hide resolved
….json and define PrivateLinkResource and PrivateLinkResourceResult in our own file
aim-for-better
force-pushed
the
Onboard20210601ForHDInsight
branch
from
ed0d0d8
to
406d086
Compare
jianyexi
approved these changes
Sep 14, 2021
This was referenced Sep 14, 2021
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Sep 14, 2021
…1 for HDInsight (#1904) Create to sync Azure/azure-rest-api-specs#15815 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/hdinsight?expand=1)
This was referenced Oct 8, 2021
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…#15815) * Just copied the existing version file into this new directory per to review change efficiently * Support az, private link feature ,fix S360 R2026 and roundtrip error * reuse private link resource in common type, and mark some properties as required, Add 201 schema for private endpoint connection put response, and modify resource definition * Fix missing objec type in 2021-06-01' * Update location get capability api: remove vmsizes and vmsizes_filter in the result and change some properties to CamelCase style * Update readme.md to change 2021-06 to default tag * Removed the non reference object ClusterListRuntimeScriptActionDetailResult * Fix CI error * revert the change in common-types/resource-management/v2/privatelinks.json and define PrivateLinkResource and PrivateLinkResourceResult in our own file Co-authored-by: Zhenyu Zhou <zhezhou@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.