-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-monitor-modelerfour-issue-in-sdk-generation #15785
base: main
Are you sure you want to change the base?
Conversation
Hi, @qiaozha Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R4037 - MissingTypeObject |
The schema 'ActionGroupV2' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L431 |
R4037 - MissingTypeObject |
The schema 'webhookProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-10-01/activityLogAlerts_API.json#L438 |
AutoRest exception |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-07", "details":"swagger-document/compose - FAILED" |
AutoRest exception |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-07", "details":"Error: '$.definitions.Resource.properties.id.description' has incompatible values (---Azure resource Id, --->- Fully qualified resource ID for the resource. Ex - /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/resourceProviderNamespace/resourceType/resourceName)." |
AutoRest exception |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2019-03", "details":"swagger-document/compose - FAILED" |
AutoRest exception |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2019-03", "details":"Error: '$.definitions.Resource.properties.id.description' has incompatible values (---Azure resource Id, --->- Fully qualified resource ID for the resource. Ex - /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/resourceProviderNamespace/resourceType/resourceName)." |
The following errors/warnings exist before current PR submission:
Only 27 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/alertrules/{ruleName}/incidents/{incidentName}' Location: Microsoft.Insights/stable/2016-03-01/alertRulesIncidents_API.json#L39 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/alertrules/{ruleName}/incidents' Location: Microsoft.Insights/stable/2016-03-01/alertRulesIncidents_API.json#L88 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/actionGroups/{actionGroupName}' Location: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L39 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.insights/actionGroups' Location: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L213 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/actionGroups' Location: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L249 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/actionGroups/{actionGroupName}/subscribe' Location: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L288 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/{resourceUri}/providers/microsoft.insights/metricNamespaces' Location: Microsoft.Insights/preview/2017-12-01-preview/metricNamespaces_API.json#L36 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.insights/privateLinkScopes' Location: Microsoft.Insights/preview/2019-10-17-preview/privateLinkScopes_API.json#L40 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/privateLinkScopes' Location: Microsoft.Insights/preview/2019-10-17-preview/privateLinkScopes_API.json#L70 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/privateLinkScopes/{scopeName}' Location: Microsoft.Insights/preview/2019-10-17-preview/privateLinkScopes_API.json#L103 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/privateLinkScopeOperationStatuses/{asyncOperationId}' Location: Microsoft.Insights/preview/2019-10-17-preview/privateLinkScopes_API.json#L260 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/alertrules/{ruleName}/incidents/{incidentName}' Location: Microsoft.Insights/stable/2016-03-01/alertRulesIncidents_API.json#L39 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/microsoft.insights/alertrules/{ruleName}/incidents' Location: Microsoft.Insights/stable/2016-03-01/alertRulesIncidents_API.json#L88 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/actionGroups/{actionGroupName}' Location: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json#L39 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.insights/actionGroups' Location: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json#L213 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/actionGroups' Location: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json#L249 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/actionGroups/{actionGroupName}/subscribe' Location: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json#L288 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/activityLogAlerts/{activityLogAlertName}' Location: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L39 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/microsoft.insights/activityLogAlerts' Location: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L213 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/activityLogAlerts' Location: Microsoft.Insights/stable/2017-04-01/activityLogAlerts_API.json#L249 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/{resourceUri}/providers/microsoft.insights/metricNamespaces' Location: Microsoft.Insights/preview/2017-12-01-preview/metricNamespaces_API.json#L36 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2016-03-01/alertRulesIncidents_API.json#L39 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2016-03-01/alertRulesIncidents_API.json#L88 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L39 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L213 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L249 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2019-06-01/actionGroups_API.json#L288 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/monitor/resource-manager/readme.md tag: specification/monitor/resource-manager/readme.md#tag-package-2021-04 |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
[Staging] SDK Track2 Validation: 9 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
PreCheck/DuplicateSchema |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-07", "details":"Duplicate Schema named Resource -- properties.kind: undefined => "$ref":"#/components/schemas/schemas:596", "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported, the resource provider must validate and persist this value.", "readOnly":true, properties.etag: undefined => "$ref":"#/components/schemas/schemas:597", "description":"The etag field is not required. If it is provided in the response body, it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19), If-Match (section 14.24), If-None-Match (section 14.26), and If-Range (section 14.27) header fields. ", "readOnly":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
PreCheck/DuplicateSchema |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-07", "details":"Duplicate Schema named ErrorResponse -- properties.code: "$ref":"#/components/schemas/schemas:66", "description":"Error code" =>, properties.message: "$ref":"#/components/schemas/schemas:67", "description":"Error message indicating why the operation failed." =>, properties.error: undefined => "description":"The error object.", "$ref":"#/components/schemas/schemas:955", title: undefined => "Error response" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
AutorestCore/Exception |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-07", "details":"Error: Plugin prechecker reported failure." |
PreCheck/DuplicateSchema |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-04", "details":"Duplicate Schema named Resource -- properties.kind: undefined => "$ref":"#/components/schemas/schemas:596", "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported, the resource provider must validate and persist this value.", "readOnly":true, properties.etag: undefined => "$ref":"#/components/schemas/schemas:597", "description":"The etag field is not required. If it is provided in the response body, it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19), If-Match (section 14.24), If-None-Match (section 14.26), and If-Range (section 14.27) header fields. ", "readOnly":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
AutorestCore/Exception |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2021-04", "details":"Error: Plugin prechecker reported failure." |
PreCheck/DuplicateSchema |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2019-03", "details":"Duplicate Schema named Resource -- properties.kind: undefined => "$ref":"#/components/schemas/schemas:615", "description":"Metadata used by portal/tooling/etc to render different UX experiences for resources of the same type; e.g. ApiApps are a kind of Microsoft.Web/sites type. If supported, the resource provider must validate and persist this value.", "readOnly":true, properties.etag: undefined => "$ref":"#/components/schemas/schemas:616", "description":"The etag field is not required. If it is provided in the response body, it must also be provided as a header per the normal etag convention. Entity tags are used for comparing two or more entities from the same requested resource. HTTP/1.1 uses entity tags in the etag (section 14.19), If-Match (section 14.24), If-None-Match (section 14.26), and If-Range (section 14.27) header fields. ", "readOnly":true ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
PreCheck/DuplicateSchema |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2019-03", "details":"Duplicate Schema named ErrorResponse -- properties.code: "$ref":"#/components/schemas/schemas:66", "description":"Error code" =>, properties.message: "$ref":"#/components/schemas/schemas:67", "description":"Error message indicating why the operation failed." =>, properties.error: undefined => "description":"The error object.", "$ref":"#/components/schemas/schemas:750", title: undefined => "Error response" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
PreCheck/DuplicateSchema |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2019-03-01-only", "details":"Duplicate Schema named ErrorResponse -- properties.code: "$ref":"#/components/schemas/schemas:66", "description":"Error code" =>, properties.message: "$ref":"#/components/schemas/schemas:67", "description":"Error message indicating why the operation failed." =>, properties.error: undefined => "description":"The error object.", "$ref":"#/components/schemas/schemas:143", title: undefined => "Error response" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
AutorestCore/Exception |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2019-03-01-only", "details":"Error: Plugin prechecker reported failure." |
💬 AutorestCore/Exception | "readme":"monitor/resource-manager/readme.md", "tag":"package-2021-07", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
💬 AutorestCore/Exception | "readme":"monitor/resource-manager/readme.md", "tag":"package-2021-07", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
AutorestCore/Exception |
"readme":"monitor/resource-manager/readme.md", "tag":"package-2019-03", "details":"Error: Plugin prechecker reported failure." |
💬 AutorestCore/Exception | "readme":"monitor/resource-manager/readme.md", "tag":"package-2021-07", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
💬 AutorestCore/Exception | "readme":"monitor/resource-manager/readme.md", "tag":"package-2021-04", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"monitor/resource-manager/readme.md", "tag":"package-2021-04", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
💬 AutorestCore/Exception | "readme":"monitor/resource-manager/readme.md", "tag":"package-2020-10-only", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"monitor/resource-manager/readme.md", "tag":"package-2020-10-only", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
💬 AutorestCore/Exception | "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-03", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-03", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
💬 AutorestCore/Exception | "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-03-01-only", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
💬 AutorestCore/Exception | "readme":"monitor/resource-manager/readme.md", "tag":"package-2019-03-01-only", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️❌
[Staging] PrettierCheck: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
HowToFix |
Code style issues found path: Microsoft.Insights/stable/2019-03-01/actionGroups_API.json |
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
NewApiVersionRequired reason: |
Hi @qiaozha, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hi @qiaozha, Your PR has some issues. Please fix the CI sequentially by following the order of
|
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.