[Deployment Scripts] Swagger KPI fix: Make DS swagger match service side #15775

filizt · 2021-08-24T15:55:13Z

This PR updates the swagger to match the service side behavior for DS scriptContent property. Service has no limit on the length of a script, so removing "maxLength" from the swagger as well. This issue was caught by the Swagger live validation: https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=B88D5299-BAA5-40B7-A2C3-1EB7780630DB

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-08-24T15:55:16Z

Hi, @filizt Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-08-24T15:55:17Z

Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.0)
- current:stable/2020-10-01/deploymentScripts.json compared with base:stable/2020-10-01/deploymentScripts.json

Rule	Message
`❌` 1036 - ConstraintChanged	The new version has a different 'maxLength' value than the previous one. New: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L583:9 Old: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L583:9
`❌` 1036 - ConstraintChanged	The new version has a different 'maxLength' value than the previous one. New: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L583:9 Old: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L583:9
`❌` 1036 - ConstraintChanged	The new version has a different 'maxLength' value than the previous one. New: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L583:9 Old: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L583:9

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- resources/resource-manager/readme.md tag:package-deploymentscripts-2020-10
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- resources/resource-manager/readme.md tag:package-deploymentscripts-2020-10

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'DeploymentScripts_GetLogsDefault' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L317
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'DeploymentScripts_GetLogsDefault' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L317
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'DeploymentScripts_GetLogsDefault' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L317
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'DeploymentScripts_GetLogsDefault' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L317
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'DeploymentScripts_GetLogsDefault' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L317
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'DeploymentScripts_GetLogsDefault' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L317
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'DeploymentScripts_GetLogsDefault' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L317
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'DeploymentScripts_GetLogsDefault' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L317
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'DeploymentScripts_GetLogsDefault' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L317
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L344
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L344
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L344
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L344
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L344
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L344
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L344
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L344
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L344
`❌` R4037 - MissingTypeObject	The schema 'DeploymentScriptListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L811
`❌` R4037 - MissingTypeObject	The schema 'ScriptLogsList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L828
`❌` R4037 - MissingTypeObject	The schema 'DeploymentScriptsError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L888
`❌` R4037 - MissingTypeObject	The schema 'DeploymentScriptListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L811
`❌` R4037 - MissingTypeObject	The schema 'ScriptLogsList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L828
`❌` R4037 - MissingTypeObject	The schema 'DeploymentScriptsError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L888
`❌` R4037 - MissingTypeObject	The schema 'DeploymentScriptListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L811
`❌` R4037 - MissingTypeObject	The schema 'ScriptLogsList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L828
`❌` R4037 - MissingTypeObject	The schema 'DeploymentScriptsError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L888
`❌` R4037 - MissingTypeObject	The schema 'DeploymentScriptListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L811
`❌` R4037 - MissingTypeObject	The schema 'ScriptLogsList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L828
`❌` R4037 - MissingTypeObject	The schema 'DeploymentScriptsError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Resources/stable/2020-10-01/deploymentScripts.json#L888

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

resources/resource-manager/readme.md#package-deploymentscripts-2020-10

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"resources/resource-manager/readme.md",
"tag":"package-deploymentscripts-2020-10",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"resources/resource-manager/readme.md",
"tag":"package-deploymentscripts-2020-10",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"resources/resource-manager/readme.md",
"tag":"package-deploymentscripts-2020-10",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-08-24T15:55:17Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-08-24T15:55:17Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-python-track2 - track2_azure-mgmt-resource - 19.0.0

❌azure-sdk-for-go - resources/mgmt/2021-07-01/features - v56.3.0

❌azure-sdk-for-go - resources/mgmt/2021-01-01/subscriptions - v56.3.0

️✔️azure-sdk-for-go - resources/mgmt/2021-01-01/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2020-10-01/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2020-06-01/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2019-11-01/subscriptions - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2019-10-01/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2019-09-01/policy - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2019-07-01/managedapplications - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2019-07-01/features - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2019-06-01/subscriptions - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2019-06-01/policy - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2019-05-01/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2019-03-01/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2019-01-01/policy - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2018-06-01/subscriptions - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2018-06-01/managedapplications - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2018-05-01/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2018-05-01/policy - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2018-03-01/policy - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2018-02-01/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2017-09-01/managedapplications - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2017-05-10/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2016-12-01/policy - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2016-09-01/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2016-09-01/locks - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2016-09-01/links - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2016-07-01/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2016-06-01/subscriptions - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2016-04-01/policy - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2016-02-01/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2015-12-01/features - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2015-11-01/subscriptions - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2015-11-01/resources - v56.3.0
️✔️azure-sdk-for-go - resources/mgmt/2015-01-01/locks - v56.3.0
️✔️azure-sdk-for-go - preview/resources/mgmt/2021-06-01-preview/policy - v56.3.0
️✔️azure-sdk-for-go - preview/resources/mgmt/2020-09-01-preview/policy - v56.3.0
❌azure-sdk-for-go - preview/resources/mgmt/2020-03-01-preview/policy - v56.3.0

️✔️azure-sdk-for-go - preview/resources/mgmt/2019-06-01-preview/templatespecs - v56.3.0
️✔️azure-sdk-for-go - preview/resources/mgmt/2017-06-01-preview/policy - v56.3.0
️✔️azure-sdk-for-go - preview/resources/mgmt/2016-09-01-preview/managedapplications - v56.3.0
️✔️azure-sdk-for-go - preview/resources/mgmt/2015-10-01-preview/policy - v56.3.0

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 20a98a8. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/resources/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ResourceManager [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.ResourceManager.3.14.0-preview.nupkg
- Microsoft.Azure.Management.ResourceManager.3.14.0-preview.symbols.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 20a98a8. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-resource [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model PolicyDefinition has a new parameter system_data
info	[Changelog]   - Model PolicyAssignment has a new parameter system_data
info	[Changelog]   - Model TenantIdDescription has a new parameter tenant_type
info	[Changelog]   - Model TenantIdDescription has a new parameter default_domain
info	[Changelog]   - Model TenantIdDescription has a new parameter tenant_branding_logo_url
info	[Changelog]   - Model PolicySetDefinition has a new parameter system_data
info	[Changelog]   - Model Location has a new parameter type
info	[Changelog]   - Model LocationMetadata has a new parameter home_location
info	[Changelog]   - Added operation PolicyAssignmentsOperations.update_by_id
info	[Changelog]   - Added operation PolicyAssignmentsOperations.update
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation ProvidersOperations.list_at_tenant_scope has a new signature
info	[Changelog]   - Operation ProvidersOperations.list has a new signature
info	[Changelog]   - Operation SubscriptionsOperations.list_locations has a new signature

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 20a98a8. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-08-27 06:58:51 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-resources-generated"
cmderr	[generate.py] 2021-08-27 06:58:51 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-08-27 06:58:51 INFO autorest --version=3.4.5 --use=@autorest/java@4.0.36 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/resources/azure-resourcemanager-resources-generated --java.namespace=com.azure.resourcemanager.resources.generated --tag=package-resources-2021-04  --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/resources/resource-manager/readme.md
cmderr	[generate.py] 2021-08-27 06:59:30 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-08-27 06:59:30 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-08-27 06:59:30 INFO [POM][Skip] pom already has module azure-resourcemanager-resources-generated
cmderr	[generate.py] 2021-08-27 06:59:30 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-08-27 06:59:30 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-08-27 06:59:30 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-resources-generated [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-08-27 07:01:46 DEBUG Got artifact_id: azure-resourcemanager-resources-generated
cmderr	[Inst] 2021-08-27 07:01:46 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-08-27 07:01:46 DEBUG Got artifact: azure-resourcemanager-resources-generated-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-08-27 07:01:46 DEBUG Got artifact: azure-resourcemanager-resources-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-08-27 07:01:46 DEBUG Got artifact: azure-resourcemanager-resources-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-08-27 07:01:46 DEBUG Match jar package: azure-resourcemanager-resources-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-08-27 07:01:46 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15775/azure-sdk-for-java/azure-resourcemanager-resources-generated/azure-resourcemanager-resources-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-resources-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-resources-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-resources-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 20a98a8. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️resources/mgmt/2021-07-01/features [View full logs] [Release SDK Changes] Breaking Change Detected
Only show 3 items here, please refer to log for details.
```
info	[Changelog]
info	[Changelog] Total 16 breaking change(s), 0 additive change(s).
info	[Changelog]
```
️✔️resources/mgmt/2021-01-01/subscriptions [View full logs] Breaking Change Detected
Only show 3 items here, please refer to log for details.
```
info	[Changelog]
info	[Changelog] Total 27 breaking change(s), 0 additive change(s).
info	[Changelog]
```
️✔️resources/mgmt/2021-01-01/resources [View full logs]
```
info	[Changelog] This is a new package
```
️✔️resources/mgmt/2020-10-01/resources [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2020-06-01/resources [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2019-11-01/subscriptions [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2019-10-01/resources [View full logs]
Only show 3 items here, please refer to log for details.
```
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
info	[Changelog]
```
️✔️resources/mgmt/2019-09-01/policy [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2019-07-01/managedapplications [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2019-07-01/features [View full logs]
Only show 3 items here, please refer to log for details.
```
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
info	[Changelog]
```
️✔️resources/mgmt/2019-06-01/subscriptions [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2019-06-01/policy [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2019-05-01/resources [View full logs]
Only show 3 items here, please refer to log for details.
```
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
info	[Changelog]
```
️✔️resources/mgmt/2019-03-01/resources [View full logs]
Only show 3 items here, please refer to log for details.
```
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
info	[Changelog]
```
️✔️resources/mgmt/2019-01-01/policy [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2018-06-01/subscriptions [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2018-06-01/managedapplications [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2018-05-01/resources [View full logs]
Only show 3 items here, please refer to log for details.
```
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
info	[Changelog]
```
️✔️resources/mgmt/2018-05-01/policy [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2018-03-01/policy [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2018-02-01/resources [View full logs]
Only show 3 items here, please refer to log for details.
```
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
info	[Changelog]
```
️✔️resources/mgmt/2017-09-01/managedapplications [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2017-05-10/resources [View full logs]
Only show 3 items here, please refer to log for details.
```
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
info	[Changelog]
```
️✔️resources/mgmt/2016-12-01/policy [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2016-09-01/resources [View full logs]
Only show 3 items here, please refer to log for details.
```
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
info	[Changelog]
```
️✔️resources/mgmt/2016-09-01/locks [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2016-09-01/links [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2016-07-01/resources [View full logs]
Only show 3 items here, please refer to log for details.
```
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
info	[Changelog]
```
️✔️resources/mgmt/2016-06-01/subscriptions [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2016-04-01/policy [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2016-02-01/resources [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2015-12-01/features [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2015-11-01/subscriptions [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2015-11-01/resources [View full logs]
```
info	[Changelog] No exported changes
```
️✔️resources/mgmt/2015-01-01/locks [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/resources/mgmt/2021-06-01-preview/policy [View full logs]
```
info	[Changelog] This is a new package
```
️✔️preview/resources/mgmt/2020-09-01-preview/policy [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/resources/mgmt/2020-03-01-preview/policy [View full logs] Breaking Change Detected
Only show 3 items here, please refer to log for details.
```
info	[Changelog]
info	[Changelog] Total 64 breaking change(s), 4 additive change(s).
info	[Changelog]
```
️✔️preview/resources/mgmt/2019-06-01-preview/templatespecs [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/resources/mgmt/2017-06-01-preview/policy [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/resources/mgmt/2016-09-01-preview/managedapplications [View full logs]
```
info	[Changelog] No exported changes
```
️✔️preview/resources/mgmt/2015-10-01-preview/policy [View full logs]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 20a98a8. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/resources/resource-manager/readme.md

️✔️@azure/arm-features [View full logs] [Release SDK Changes]

azure-arm-features-1.1.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/featureClient.js → ./dist/arm-features.js...
cmderr	[npmPack] created ./dist/arm-features.js in 176ms

️✔️@azure/arm-links [View full logs] [Release SDK Changes]

azure-arm-links-1.1.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/managementLinkClient.js → ./dist/arm-links.js...
cmderr	[npmPack] created ./dist/arm-links.js in 137ms

️✔️@azure/arm-locks [View full logs] [Release SDK Changes]

azure-arm-locks-1.2.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/managementLockClient.js → ./dist/arm-locks.js...
cmderr	[npmPack] created ./dist/arm-locks.js in 178ms

️✔️@azure/arm-managedapplications [View full logs] [Release SDK Changes]

azure-arm-managedapplications-1.1.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/applicationClient.js → ./dist/arm-managedapplications.js...
cmderr	[npmPack] created ./dist/arm-managedapplications.js in 227ms

️✔️@azure/arm-policy [View full logs] [Release SDK Changes]

azure-arm-policy-4.1.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/policyClient.js → ./dist/arm-policy.js...
cmderr	[npmPack] created ./dist/arm-policy.js in 321ms

️✔️@azure/arm-resources-subscriptions [View full logs] [Release SDK Changes]

azure-arm-resources-subscriptions-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/subscriptionClient.js → ./dist/arm-resources-subscriptions.js...
cmderr	[npmPack] created ./dist/arm-resources-subscriptions.js in 189ms

️✔️@azure/arm-resources [View full logs] [Release SDK Changes]

azure-arm-resources-4.2.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/resourceManagementClient.js → ./dist/arm-resources.js...
cmderr	[npmPack] created ./dist/arm-resources.js in 511ms

️❌ azure-resource-manager-schemas failed [Detail]

❌Failed [Logs]Release - Generate from 20a98a8. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:2487) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2016-04-01/Microsoft.Authorization.Resources.json'
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:2487) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:2487) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
cmderr	[generateScript.sh] (node:2487) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2016-04-01/Microsoft.Authorization.Resources.json'
cmderr	[generateScript.sh] (node:2487) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.

️✔️resources [View full logs] [Release Schema Changes]

️✔️resources [View full logs]

error	Fatal error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
error	The following packages are still pending:
error		resources
error		resources

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-08-24T15:57:12Z

Hi @filizt, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

filizt · 2021-08-26T15:09:53Z

@raych1 - not sure why the azure-resource-manager-schemas task is failing. Could you take a look? If the failure is not from us, could you merge the PR please?

Swagger KPI fix:Make DS swager match service side

a9dadde

openapi-assignment-bot bot assigned raych1 Aug 24, 2021

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Aug 24, 2021

openapi-pipeline-app bot added CI-BreakingChange-Python-Track2 CI-BreakingChange-Go labels Aug 24, 2021

openapi-workflow-bot bot added the FixS360 label Aug 24, 2021

jorgecotillo added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 24, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 25, 2021

raych1 approved these changes Aug 27, 2021

View reviewed changes

raych1 merged commit 20a98a8 into Azure:main Aug 27, 2021

This was referenced Aug 27, 2021

[ReleasePR @azure/arm-features] Zone mappings fix Azure/azure-sdk-for-js#16320

Closed

[ReleasePR @azure/arm-links] Zone mappings fix Azure/azure-sdk-for-js#16321

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Deployment Scripts] Swagger KPI fix: Make DS swagger match service side #15775

[Deployment Scripts] Swagger KPI fix: Make DS swagger match service side #15775

filizt commented Aug 24, 2021 •

edited

Loading

openapi-workflow-bot bot commented Aug 24, 2021

openapi-pipeline-app bot commented Aug 24, 2021 •

edited

Loading

openapi-workflow-bot bot commented Aug 24, 2021

openapi-pipeline-app bot commented Aug 24, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Aug 24, 2021

filizt commented Aug 26, 2021

[Deployment Scripts] Swagger KPI fix: Make DS swagger match service side #15775

[Deployment Scripts] Swagger KPI fix: Make DS swagger match service side #15775

Conversation

filizt commented Aug 24, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Aug 24, 2021

openapi-pipeline-app bot commented Aug 24, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Aug 24, 2021

openapi-pipeline-app bot commented Aug 24, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Aug 24, 2021

filizt commented Aug 26, 2021

filizt commented Aug 24, 2021 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2021 •

edited

Loading

openapi-pipeline-app bot commented Aug 24, 2021 •

edited

Loading