-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing swagger correctness and completeness issues for RecoveryServicesBackup #15024
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a84db0d
Fixing swagger correctness and completeness issues for
pratimaupadhyay02 33d3488
Adding examples
pratimaupadhyay02 84173e8
Fixing swagger completness
pratimaupadhyay02 0f92ba5
Updating tag in 2021-04-01
pratimaupadhyay02 209126b
Update
pratimaupadhyay02 bae9367
Update
pratimaupadhyay02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...Microsoft.RecoveryServices/stable/2021-04-01/examples/Common/BackupStorageConfig_Get.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "resourceGroupName": "PythonSDKBackupTestRg", | ||
| "vaultName": "PySDKBackupTestRsVault", | ||
| "api-version": "2016-12-01" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": {}, | ||
| "body": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/PythonSDKBackupTestRg/providers/Microsoft.RecoveryServices/vaults/PySDKBackupTestRsVault/backupstorageconfig/vaultstorageconfig", | ||
| "name": "vaultstorageconfig", | ||
| "type": "Microsoft.RecoveryServices/vaults/backupstorageconfig", | ||
| "properties": { | ||
| "storageModelType": "GeoRedundant", | ||
| "storageType": "GeoRedundant", | ||
| "storageTypeState": "Locked" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
17 changes: 17 additions & 0 deletions
17
...crosoft.RecoveryServices/stable/2021-04-01/examples/Common/BackupStorageConfig_Patch.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "resourceGroupName": "PythonSDKBackupTestRg", | ||
| "vaultName": "PySDKBackupTestRsVault", | ||
| "api-version": "2016-12-01", | ||
| "parameters": { | ||
| "properties": { | ||
| "storageType": "LocallyRedundant", | ||
| "storageTypeState": "Unlocked" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "204": {} | ||
| } | ||
| } |
29 changes: 29 additions & 0 deletions
29
...Microsoft.RecoveryServices/stable/2021-04-01/examples/Common/BackupStorageConfig_Put.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-0000-0000-0000-000000000000", | ||
| "resourceGroupName": "PythonSDKBackupTestRg", | ||
| "vaultName": "PySDKBackupTestRsVault", | ||
| "api-version": "2016-12-01", | ||
| "parameters": { | ||
| "properties": { | ||
| "storageType": "LocallyRedundant", | ||
| "storageTypeState": "Unlocked" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": {}, | ||
| "body": { | ||
| "id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/PythonSDKBackupTestRg/providers/Microsoft.RecoveryServices/vaults/PySDKBackupTestRsVault/backupstorageconfig/vaultstorageconfig", | ||
| "name": "vaultstorageconfig", | ||
| "type": "Microsoft.RecoveryServices/vaults/backupstorageconfig", | ||
| "properties": { | ||
| "storageModelType": "LocallyRedundant", | ||
| "storageType": "LocallyRedundant", | ||
| "storageTypeState": "Unlocked" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The api-version 2018-12-20 has the same path, but the tag is different. So it's conflict. Pls fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ruowan In this PR the API BackupResourceStorageConfigs which is already present in the version 2018-12-20, is being added in the version 2021-04-01(which routes the request to the active stamp) with different operationId and tag which will ensure a new SDK function is generated for this API that routes the request specifically to active stamp.
We have followed similar procedure for a number of other APIs and the SDK generation has always worked in the past. This is an example of such a scenario : This is the API in 2021-04-01 :
azure-rest-api-specs/specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-04-01/bms.json
Line 374 in 8dff86d
This is the same API in 2018-12-20 with different operationId and tag :
azure-rest-api-specs/specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2018-12-20/bms.json
Line 21 in 8dff86d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you changed the tags of the below api in the new api version , this caused conflict.
$.paths["/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.RecoveryServices/vaults/vaultName/backupstorageconfig/vaultstorageconfig"].getThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed offline, accept this change as this situation exists for historical reason, and cannot easily fix.