[Hub Generated] [SiteRecovery] Review request for Microsoft.RecoveryServices to add version stable/2021-04-01 #14930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2021-02-10 to version 2021-04-01
|
Hi, @imshashwataggarwal Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| 'DELETE' operation 'ReplicationFabrics_Purge' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L558 |
|
| 'DELETE' operation 'ReplicationProtectedItems_Purge' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L2819 |
|
| 'DELETE' operation 'ReplicationProtectionContainerMappings_Purge' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L4376 |
|
| 'DELETE' operation 'ReplicationRecoveryServicesProviders_Purge' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L4821 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L20269 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L596 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L692 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L800 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L1568 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L2043 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L20191 |
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L9342 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L9379 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L9424 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L9532 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L9583 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L9934 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L9987 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L10018 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.RecoveryServices/stable/2021-04-01/service.json#L10038 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 245 Errors, 6 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-04-01/service.json compared with base:stable/2021-03-01/service.json
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/operations' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-03-01/service.json#L21:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationAlertSettings' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-03-01/service.json#L61:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationAlertSettings/{alertSettingName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-03-01/service.json#L104:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{virtualMachineName}/providers/Microsoft.RecoveryServices/replicationEligibilityResults' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-03-01/service.json#L208:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{virtualMachineName}/providers/Microsoft.RecoveryServices/replicationEligibilityResults/default' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-03-01/service.json#L252:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationEvents' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-03-01/service.json#L296:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationEvents/{eventName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-03-01/service.json#L347:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-03-01/service.json#L394:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-03-01/service.json#L437:5 |
|
The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/checkConsistency' removed or restructured? Old: Microsoft.RecoveryServices/stable/2021-03-01/service.json#L591:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 1 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"recoveryservicessiterecovery/resource-manager/readme.md", "tag":"package-2021-04", "details":"Error: Semantic validation failed. There was some errors" |
| 💬 AutorestCore/Exception | "readme":"recoveryservicessiterecovery/resource-manager/readme.md", "tag":"package-2021-04", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"recoveryservicessiterecovery/resource-manager/readme.md", "tag":"package-2021-04", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"recoveryservicessiterecovery/resource-manager/readme.md", "tag":"package-2021-04", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi, @imshashwataggarwal your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
This was referenced Jun 22, 2021
imshashwataggarwal
changed the title
this file has become too large to review properly (github won't even show the diff). In the next PR for this service please split these APIs up into separate swagger specs Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2021-04-01/service.json:2 in 5ffc70e. [](commit_id = 5ffc70e, deletion_comment = False) |
an individual GET should not have a $filter. Did you intend this to be on the collection GET? Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2021-04-01/service.json:469 in 5ffc70e. [](commit_id = 5ffc70e, deletion_comment = False) |
@pilor This filter has been present since 2018-07-10 version. It is required to get additional properties from another service during the GET Fabric call. The fabric is loaded with those additional properties if specified through this parameter. |
this should be "$top" (https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#response-3). Applies to all the occurences of "takeToken" as well Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2021-04-01/service.json:2527 in 5ffc70e. [](commit_id = 5ffc70e, deletion_comment = False) |
the VaultSetting resource needs a properties.provisioningState property if it is going to support async PUT. https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#creating-or-updating-resources-asynchronously Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2021-04-01/service.json:7707 in 5ffc70e. [](commit_id = 5ffc70e, deletion_comment = False) |
pilor
added
the
ARMChangesRequested
26 tasks
Ok, we will split the file next time we introduce an API version |
pilor
removed
ARMChangesRequested
pilor
added
the
ARMSignedOff
|
@ruowan, can you please merge |
|
Hi @imshashwataggarwal, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi, This PR has breaking change. Pls go through breaking change review. |
|
Hi @ruowan, this PR is adding no change other than API version number change, which is done to overcome S360 violations. The breaking changes are shown due to following reason:
We have already got breaking change team's approval on another PR. This needs to go before that PR to prevent S360 violations. Breaking change approval: https://msazure.visualstudio.com/One/_workitems/edit/10209988 |
ruowan
approved these changes
Jul 5, 2021
This was referenced Jul 5, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
…ervices to add version stable/2021-04-01 (Azure#14930) * Adds base for updating Microsoft.RecoveryServices from version stable/2021-02-10 to version 2021-04-01 * Updates readme * Updates API version in new specs and examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.