-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Network to add version stable/2021-06-09 #14745
base: main
Are you sure you want to change the base?
[Hub Generated] Review request for Microsoft.Network to add version stable/2021-06-09 #14745
Conversation
…01 to version 2021-06-09
Hi, @bhmohant Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
Runtime Exception |
"new":"https://github.com/Azure/azure-rest-api-specs/blob/12fc49e2c8db2d737c163a186446a2f24643a1f0/specification/frontdoor/resource-manager/Microsoft.Network/stable/2020-11-01/webapplicationfirewall.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/frontdoor/resource-manager/Microsoft.Network/stable/2020-11-01/webapplicationfirewall.json", "details":"Command failed: dotnet /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/oad@0.8.11/node_modules/@azure/oad/dlls/OpenApiDiff.dll -o /tmp/old-resolved.json -n /tmp/new-resolved.json |
Unhandled Exception: Newtonsoft.Json.JsonSerializationException: Error converting value False to type 'AutoRest.Swagger.Model.Schema'. Path 'definitions.ManagedRuleSetDefinitionProperties.properties.supportedSkus.additionalProperties', line 1, position 31589. ---> System.ArgumentException: Could not cast or convert from System.Boolean to AutoRest.Swagger.Model.Schema.\n at Newtonsoft.Json.Utilities.ConvertUtils.EnsureTypeAssignable(Object value, Type initialType, Type targetType)\n at Newtonsoft.Json.Utilities.ConvertUtils.ConvertOrCast(Object initialValue, CultureInfo culture, Type targetType)\n at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.EnsureType(JsonReader reader, Object value, CultureInfo culture, JsonContract contract, Type targetType)\n --- End of inner exception stack" |
️❌
LintDiff: 4 Errors, 0 Warnings failed [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
Rule | Message |
---|---|
AutoRest exception |
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2020-11", "details":"Newtonsoft.Json.JsonSerializationException: Error converting value False to type 'OpenAPI.Validator.Model.Schema'. Path 'properties.supportedSkus.additionalProperties', line 61, position 35. ---> System.ArgumentException: Could not cast or convert from System.Boolean to OpenAPI.Validator.Model.Schema. at Newtonsoft.Json.Utilities.ConvertUtils.EnsureTypeAssignable(Object value, Type initialType, Type targetType) at Newtonsoft.Json.Utilities.ConvertUtils.ConvertOrCast(Object initialValue, CultureInfo culture, Type targetType) at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.EnsureType(JsonReader reader, Object value, CultureInfo culture, JsonContract contract, Type targetType) --- End of inner exception stack trace --- at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.EnsureType(JsonReader reader, Object value, CultureInfo culture, JsonContract contract, Type targetType) at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, Jso" |
AutoRest exception |
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2020-11", "details":"swagger-document/classic-openapi-validator - FAILED" |
AutoRest exception |
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2020-11", "details":"Error: Plugin classic-openapi-validator reported failure." |
AutoRest exception |
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2020-11", "details":"swagger-document/individual/classic-openapi-validator - FAILED" |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/frontdoor/resource-manager/readme.md tag: specification/frontdoor/resource-manager/readme.md#tag-package-2020-11 |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
[Staging] SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2020-11", "details":"Schema 'Profile' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from Profile" |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2020-11", "details":"Schema 'Experiment' has a property 'name' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from Experiment" |
|
"readme":"frontdoor/resource-manager/readme.md", "tag":"package-2020-11", "details":"Schema 'PreconfiguredEndpoint' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from PreconfiguredEndpoint" |
|
💬 AutorestCore/Exception | "readme":"frontdoor/resource-manager/readme.md", "tag":"package-2020-11", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
...n/frontdoor/resource-manager/Microsoft.Network/stable/2021-06-09/webapplicationfirewall.json
Outdated
Show resolved
Hide resolved
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
...n/frontdoor/resource-manager/Microsoft.Network/stable/2021-06-09/webapplicationfirewall.json
Outdated
Show resolved
Hide resolved
...n/frontdoor/resource-manager/Microsoft.Network/stable/2021-06-09/webapplicationfirewall.json
Outdated
Show resolved
Hide resolved
...n/frontdoor/resource-manager/Microsoft.Network/stable/2021-06-09/webapplicationfirewall.json
Outdated
Show resolved
Hide resolved
...n/frontdoor/resource-manager/Microsoft.Network/stable/2021-06-09/webapplicationfirewall.json
Outdated
Show resolved
Hide resolved
...n/frontdoor/resource-manager/Microsoft.Network/stable/2021-06-09/webapplicationfirewall.json
Outdated
Show resolved
Hide resolved
NewApiVersionRequired reason: |
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
...n/frontdoor/resource-manager/Microsoft.Network/stable/2020-11-01/webapplicationfirewall.json
Outdated
Show resolved
Hide resolved
/azp run unifiedPipeline |
No pipelines are associated with this pull request. |
Next Steps to Merge⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛ |
@bhmohant please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.
Task: https://msazure.visualstudio.com/One/_workitems/edit/10072622