-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename agfood to agrifood #14735
Rename agfood to agrifood #14735
Conversation
Hi, @RGKarthik Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AgFoodPlatform/farmBeats/{farmBeatsResourceName}/extensions/{extensionId}' removed or restructured? Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L9:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AgFoodPlatform/farmBeats/{farmBeatsResourceName}/extensions' removed or restructured? Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L195:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.AgFoodPlatform/farmBeatsExtensionDefinitions' removed or restructured? Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L279:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.AgFoodPlatform/farmBeatsExtensionDefinitions/{farmBeatsExtensionId}' removed or restructured? Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L368:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AgFoodPlatform/farmBeats/{farmBeatsResourceName}' removed or restructured? Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L412:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AgFoodPlatform/farmBeats' removed or restructured? Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L616:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AgFoodPlatform/farmBeats' removed or restructured? Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L674:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AgFoodPlatform/checkNameAvailability' removed or restructured? Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L735:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.AgFoodPlatform/operations' removed or restructured? Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L789:5 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'FarmBeatsProperties' removed or renamed? New: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L9:3 Old: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/agfood.json#L829:3 |
️❌
LintDiff: 8 Errors, 50 Warnings failed [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
Only 10 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R4037 - MissingTypeObject |
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: common-types/resource-management/v2/types.json#L9 |
R4037 - MissingTypeObject |
The schema 'AzureEntityResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: common-types/resource-management/v2/types.json#L31 |
R4037 - MissingTypeObject |
The schema 'TrackedResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: common-types/resource-management/v2/types.json#L48 |
R4037 - MissingTypeObject |
The schema 'ErrorDetail' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: common-types/resource-management/v2/types.json#L277 |
R4037 - MissingTypeObject |
The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: common-types/resource-management/v2/types.json#L313 |
R4037 - MissingTypeObject |
The schema 'ErrorAdditionalInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: common-types/resource-management/v2/types.json#L323 |
R4037 - MissingTypeObject |
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: common-types/resource-management/v2/types.json#L353 |
R4037 - MissingTypeObject |
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: common-types/resource-management/v2/types.json#L406 |
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AgFoodPlatform/preview/2021-03-31-preview/agfood.json#L8932 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.AgFoodPlatform/preview/2021-03-31-preview/agfood.json#L9205 |
️❌
Avocado: 6 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: data-plane/Microsoft.AgFoodPlatform/preview/2021-03-31-preview |
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: Microsoft.AgFoodPlatform/preview/2021-03-31-preview/examples |
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: 201e205d2ec657e244cd8db34d46bdbad925e503/specification/agfood/data-plane |
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: resource-manager/Microsoft.AgFoodPlatform/preview/2020-05-12-preview |
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: Microsoft.AgFoodPlatform/preview/2020-05-12-preview/examples |
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: 201e205d2ec657e244cd8db34d46bdbad925e503/specification/agfood/resource-manager |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
Hi @RGKarthik, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
* Rename agfood to agrifood * Agfood to Agri in swagger
* Rename agfood to agrifood * Agfood to Agri in swagger
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.