-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new parameter to enable/disable BGP route translation for NAT VirtualWan VpnGateway #14462
Add new parameter to enable/disable BGP route translation for NAT VirtualWan VpnGateway #14462
Conversation
…tualWan VpnGateway
Hi, @Nilambari Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/stable/2021-03-01/network.json#L221 |
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/stable/2021-03-01/network.json#L221 |
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/stable/2021-03-01/network.json#L221 |
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/stable/2021-03-01/network.json#L221 |
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/stable/2021-03-01/network.json#L221 |
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/stable/2021-03-01/network.json#L221 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces' Location: Microsoft.Network/stable/2021-03-01/vmssNetworkInterface.json#L37 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/networkInterfaces' Location: Microsoft.Network/stable/2021-03-01/vmssNetworkInterface.json#L97 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces/{networkInterfaceName}' Location: Microsoft.Network/stable/2021-03-01/vmssNetworkInterface.json#L150 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.Compute/virtualMachineScaleSets/{virtualMachineScaleSetName}/virtualMachines/{virtualmachineIndex}/networkInterfaces/{networkInterfaceName}/ipConfigurations' Location: Microsoft.Network/stable/2021-03-01/vmssNetworkInterface.json#L221 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️
[Staging] SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"network/resource-manager/readme.md",
"tag":"package-2021-03",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"network/resource-manager/readme.md",
"tag":"package-2021-03",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
"readme":"network/resource-manager/readme.md", "tag":"package-2021-03", "details":"Schema 'ResourceNavigationLink' has a property 'id' that is already declared the parent schema 'SubResource' but 'readonly' has been changed -- this is not permitted. The property has been removed from ResourceNavigationLink" |
|
"readme":"network/resource-manager/readme.md", "tag":"package-2021-03", "details":"Schema 'VpnServerConfiguration' has a property 'name' that is already declared the parent schema 'Resource' but 'readonly' has been changed -- this is not permitted. The property has been removed from VpnServerConfiguration" |
|
💬 AutorestCore/Exception | "readme":"network/resource-manager/readme.md", "tag":"package-2021-03", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
Rule | Message |
---|---|
RestBuild error |
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=216812&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️️✔️
[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]
Breaking Changes Tracking
️️✔️
azure-sdk-for-net succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from 753842e7a0f7044be0235e27097a48d8188bb88a. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️
Microsoft.Azure.Management.Network [View full logs] [Preview SDK Changes]
️⚠️
azure-sdk-for-python-track2 warning [Detail]
⚠️
Warning [Logs] Generate from 753842e7a0f7044be0235e27097a48d8188bb88a. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json warn No file changes detected after generation warn No package detected after generation
️⚠️
azure-sdk-for-java warning [Detail]
⚠️
Warning [Logs] Generate from 753842e7a0f7044be0235e27097a48d8188bb88a. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-05-18 22:08:17 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-network-generated" cmderr [generate.py] 2021-05-18 22:08:17 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-05-18 22:08:17 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.28 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/network/azure-resourcemanager-network-generated --java.namespace=com.azure.resourcemanager.network.generated --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/network/resource-manager/readme.md cmderr [generate.py] 2021-05-18 22:11:43 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-05-18 22:11:43 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-05-18 22:11:43 INFO [POM][Skip] pom already has module azure-resourcemanager-network-generated cmderr [generate.py] 2021-05-18 22:11:43 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-05-18 22:11:43 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-05-18 22:11:43 INFO [POM][Success] Write to root pom
️✔️
azure-resourcemanager-network-generated [View full logs] [Preview SDK Changes]- pom.xml
- azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar
- azure-resourcemanager-network-generated-1.0.0-beta.1-javadoc.jar
- azure-resourcemanager-network-generated-1.0.0-beta.1.jar
cmderr [Inst] 2021-05-18 22:19:27 DEBUG Got artifact_id: azure-resourcemanager-network-generated cmderr [Inst] 2021-05-18 22:19:27 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-05-18 22:19:27 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar cmderr [Inst] 2021-05-18 22:19:27 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1-javadoc.jar cmderr [Inst] 2021-05-18 22:19:27 DEBUG Got artifact: azure-resourcemanager-network-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-05-18 22:19:27 DEBUG Match jar package: azure-resourcemanager-network-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-05-18 22:19:27 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14462/azure-sdk-for-java/azure-resourcemanager-network-generated/azure-resourcemanager-network-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-network-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-network-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-network-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️
azure-sdk-for-go succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from 753842e7a0f7044be0235e27097a48d8188bb88a. SDK Automation 14.0.0command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only show 4 items here, please refer to log for details.
️✔️
network/mgmt/2020-11-01/network [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - New field `NicType` in struct `InterfacePropertiesFormat` info [Changelog] info [Changelog] Total 214 breaking change(s), 241 additive change(s). info [Changelog]
- Only show 4 items here, please refer to log for details.
️✔️
network/mgmt/2020-08-01/network [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - New field `Type` in struct `Subnet` info [Changelog] info [Changelog] Total 2 breaking change(s), 34 additive change(s). info [Changelog]
- Only show 4 items here, please refer to log for details.
️✔️
network/mgmt/2020-07-01/network [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - New field `PrivateLinkService` in struct `InterfacePropertiesFormat` info [Changelog] info [Changelog] Total 2 breaking change(s), 27 additive change(s). info [Changelog]
️✔️
network/mgmt/2020-06-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2020-05-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2020-04-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2020-03-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2019-12-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2019-11-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2019-09-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2019-08-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2019-07-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2019-06-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2019-04-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2019-02-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2018-12-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2018-11-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2018-10-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2018-08-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2018-07-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2018-06-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2018-04-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2018-02-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2018-01-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2017-11-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2017-10-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2017-09-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2017-08-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2017-06-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2017-03-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2016-12-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2016-09-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2016-06-01/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2016-03-30/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
network/mgmt/2015-06-15/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️
preview/network/mgmt/2015-05-01-preview/network [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️️✔️
azure-sdk-for-js succeeded [Detail] [Expand]
️✔️
Succeeded [Logs] Generate from 753842e7a0f7044be0235e27097a48d8188bb88a. SDK Automation 14.0.0warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/network/resource-manager/readme.md
️✔️
@azure/arm-network [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/networkManagementClient.js → ./dist/arm-network.js... cmderr [npmPack] created ./dist/arm-network.js in 2.4s
️⚠️
azure-resource-manager-schemas warning [Detail]
⚠️
Warning [Logs] Generate from 753842e7a0f7044be0235e27097a48d8188bb88a. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation warn Skip detect changed packages
* Adds base for updating Microsoft.Network from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Add new parameter to enable/disable BGP route translation for NAT VirtualWan VpnGateway (#14462) * Adding Bastion Host Configuration Features (#14442) Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Add PL ASG (#14620) * Add PL ASG * Prettier * [Private Link] Private Endpoint Ipconfigurations swagger for 2021-03-01 (#14662) * Ipconfigurations swagger * Ran prettier check * fixing conflicting files * fixing lint * Fixing linter diff * Lint diff * resolving comments * fixing conflict * Fioxing * running prettier * Fixing linter comment Co-authored-by: Shane Baden <shbaden@microsoft.com> * Add missing properties of ServiceEndpointPolicy (#14948) * Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response * Add missing 'contextualServiceEndpointPolicies' * fix bug * fix type * Add missing properties to ServiceEndpointPolicy * Revert "fix type" This reverts commit 3a49beb. * Revert "fix bug" This reverts commit a4fff4a. * Revert "Add missing 'contextualServiceEndpointPolicies'" This reverts commit ccf1916. * Revert "Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response" This reverts commit e532cc1. Co-authored-by: Xu Wang <wax@microsoft.com> * add new service tag details api (#14958) * add new service tag details api * prettier check fixes * fixing lint issue, additional properties issue * Add Load distribution policy and global configuration to AppGW (#14790) * add Load distribution policy and global configuration to Application Gateway resource * prettify * remove provisioning state * add public ssh key to network virtual appliance (#14988) * Changes needed for BgpEndpoint (#14800) * changes needed for BgpEndpoint * prettier check * model validation fix * fix description * update again * Multi QoS support for DSCP configuration (#15120) * Updating the DSCP jsons to reflect the multi-qos support * Adding support to multi-qos * adding the type object to NrpQos * fixing the prettier removing my update to the settings * fixing the missing type object error. seeing if this also fixes the additional attributes exception * fixing the prettier exception * almost forgot this, it was refactor from NrpQos to QosDefinition. NRPQos is already being used in Networking repo * copying what I did with my other objects * names didn't match with what I have in NRP's src * forgot to update the examples with the updates in the specification. updating it * fixing the merge exceptions * Add SQL Setting to Firewall Policy (#15110) * Add SQL Setting to Firewall Policy * fix lint check except for object type * resolve linter error * network: fix newly added targets field to an array and missing sub-resource properties in applicationGateways.json (#15318) * fix: change target to an array and add subresource properties * fix target examples * Support to update tags for BastionHost resource (#15446) * Initial commit * Validation fixes * Update bastionHost.json Co-authored-by: Abhishek Shah <shabhis@microsoft.com> * Azure FW - Explicit Proxy feature swagger change (#15017) * explicit proxy swagger change * prettier check fix * lint check * prettier fix * revert unnecessary file change * Add kind to virtual hub (#15562) * Adding customnetworkinterfacename attribute to Private Endpoint (#15574) Co-authored-by: Shane Baden <shbaden@microsoft.com> * Added 3 new properties to InboundNatRule resource (#15611) * Added the missins properties to fix the change breaking update (#15732) Co-authored-by: Nilambari <nilamd@microsoft.com> Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com> Co-authored-by: Abhishek Shah <shabhis@microsoft.com> Co-authored-by: Yang Shi <yangshi93@gmail.com> Co-authored-by: Shane Baden <naruto.shane@gmail.com> Co-authored-by: Shane Baden <shbaden@microsoft.com> Co-authored-by: Xu Wang <wangxu724@gmail.com> Co-authored-by: Xu Wang <wax@microsoft.com> Co-authored-by: guptas14 <71726901+guptas14@users.noreply.github.com> Co-authored-by: Akshay Gupta <aksgupta@microsoft.com> Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com> Co-authored-by: David Velasco <davelasc@microsoft.com> Co-authored-by: Jiejiong Wu <b564518128@users.noreply.github.com> Co-authored-by: tinawu6 <78238424+tinawu6@users.noreply.github.com> Co-authored-by: irrogozh <irrogozh@microsoft.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.