Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compute VirtualMachineExtension model #14458

Closed
wants to merge 1 commit into from

Conversation

ctaggart
Copy link
Contributor

Hey @Sandido, there appears to be a bug in the compute policy spec. It causes deserialization to fail in the Azure SDK for Rust
Azure/azure-sdk-for-rust#54 .

related PRs:
#12334
#14223


MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ctaggart Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 18, 2021

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 9 Warnings failed [Detail]

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'name' renamed or removed?
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L7830:7
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L7830:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'type' renamed or removed?
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L7830:7
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L7830:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'location' renamed or removed?
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L7830:7
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L7830:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'tags' renamed or removed?
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L7830:7
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L7830:7
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L1641:13
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L1641:13
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L1656:13
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L1656:13
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L1662:13
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L1662:13
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L1716:13
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L1716:13
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L1816:13
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L1816:13
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Compute/stable/2020-12-01/compute.json#L7909:11
    Old: Microsoft.Compute/stable/2020-12-01/compute.json#L7909:11
    ️❌LintDiff: 1 Errors, 0 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    R2020 - RequiredPropertiesMissingInResourceModel Model definition 'VirtualMachineExtension' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L7829


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L36
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Disks_Delete'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L223
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Disks_GrantAccess'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L327
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Disks_RevokeAccess'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L374
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Snapshots_Update'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L465
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Snapshots_Delete'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L544
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Snapshots_GrantAccess'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L648
    D5001 - XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'Snapshots_RevokeAccess'
    Location: Microsoft.Compute/stable/2020-12-01/disk.json#L695
    R2020 - RequiredPropertiesMissingInResourceModel Model definition 'SubResourceWithColocationStatus' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L7128
    R2026 - AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.Compute/stable/2020-12-01/compute.json#L9647
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2021-03-01
    ️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]
    Rule Message
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: tags
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L7829
    JsonUrl: stable/2020-12-01/examples/GetVirtualMachine.json
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: location
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L7829
    JsonUrl: stable/2020-12-01/examples/GetVirtualMachine.json
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: type
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L7829
    JsonUrl: stable/2020-12-01/examples/GetVirtualMachine.json
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: name
    Url: Microsoft.Compute/stable/2020-12-01/compute.json#L7829
    JsonUrl: stable/2020-12-01/examples/GetVirtualMachine.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"compute/resource-manager/readme.md",
    "tag":"package-2020-12-01",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"compute/resource-manager/readme.md",
    "tag":"package-2020-12-01",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    Rule Message
    PreCheck/DuplicateSchema "readme":"compute/resource-manager/readme.md",
    "tag":"package-2020-12-01",
    "details":"Duplicate Schema named PurchasePlan -- properties.promotionCode: undefined => "$ref":"#/components/schemas/schemas:1336",
    "description":"The Offer Promotion Code." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2020-12-01",
    "details":"Error: Plugin prechecker reported failure."
    PreCheck/DuplicateSchema "readme":"compute/resource-manager/readme.md",
    "tag":"package-2020-12-01-only",
    "details":"Duplicate Schema named PurchasePlan -- properties.promotionCode: "$ref":"#/components/schemas/schemas:108",
    "description":"The Offer Promotion Code." => ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2020-12-01-only",
    "details":"Error: Plugin prechecker reported failure."
    💬 AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2020-12-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    💬 AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2020-12-01-only",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"compute/resource-manager/readme.md",
    "tag":"package-2020-12-01-only",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Compute label May 18, 2021
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 18, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 20.0.0
    +	Model PurchasePlan no longer has parameter promotion_code
    +	Operation VirtualMachineScaleSetsOperations.get has a new signature
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from af5a8cece0376be4bad4e5952ed76e77cecb3644. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Compute [View full logs]  [Preview SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from af5a8cece0376be4bad4e5952ed76e77cecb3644. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model VirtualMachineScaleSetUpdateNetworkProfile has a new parameter network_api_version
      info	[Changelog]   - Model VirtualMachineScaleSetUpdateVMProfile has a new parameter user_data
      info	[Changelog]   - Model VirtualMachineScaleSetPublicIPAddressConfiguration has a new parameter delete_option
      info	[Changelog]   - Model VirtualMachineScaleSetPublicIPAddressConfiguration has a new parameter sku
      info	[Changelog]   - Model VirtualMachineScaleSetNetworkProfile has a new parameter network_api_version
      info	[Changelog]   - Model VirtualMachineScaleSetVMProfile has a new parameter user_data
      info	[Changelog]   - Model VirtualMachineScaleSetUpdatePublicIPAddressConfiguration has a new parameter delete_option
      info	[Changelog]   - Model VirtualMachineScaleSetUpdateNetworkConfiguration has a new parameter delete_option
      info	[Changelog]   - Model VirtualMachineScaleSetVM has a new parameter user_data
      info	[Changelog]   - Model VirtualMachineScaleSetNetworkConfiguration has a new parameter delete_option
      info	[Changelog]   - Model NetworkInterfaceReference has a new parameter delete_option
      info	[Changelog]   - Model PatchSettings has a new parameter assessment_mode
      info	[Changelog]   - Model LinuxPatchSettings has a new parameter assessment_mode
      info	[Changelog]   - Model NetworkProfile has a new parameter network_api_version
      info	[Changelog]   - Model NetworkProfile has a new parameter network_interface_configurations
      info	[Changelog]   - Model OSDisk has a new parameter delete_option
      info	[Changelog]   - Model DataDisk has a new parameter delete_option
      info	[Changelog]   - Model VirtualMachineUpdate has a new parameter user_data
      info	[Changelog]   - Model VirtualMachineUpdate has a new parameter scheduled_events_profile
      info	[Changelog]   - Model VirtualMachine has a new parameter user_data
      info	[Changelog]   - Model VirtualMachine has a new parameter scheduled_events_profile
      info	[Changelog]   - Added operation group RestorePointCollectionsOperations
      info	[Changelog]   - Added operation group RestorePointsOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation VirtualMachineScaleSetsOperations.get has a new signature
      info	[Changelog]   - Model PurchasePlan no longer has parameter promotion_code
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from af5a8cece0376be4bad4e5952ed76e77cecb3644. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-05-18 19:26:51 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-compute-generated"
      cmderr	[generate.py] 2021-05-18 19:26:51 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-05-18 19:26:51 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.28 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated --java.namespace=com.azure.resourcemanager.compute.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[generate.py] 2021-05-18 19:28:37 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-05-18 19:28:37 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-05-18 19:28:37 INFO [POM][Skip] pom already has module azure-resourcemanager-compute-generated
      cmderr	[generate.py] 2021-05-18 19:28:37 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-05-18 19:28:37 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-05-18 19:28:37 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-compute-generated [View full logs]  [Preview SDK Changes]
      cmderr	[Inst] 2021-05-18 19:33:23 DEBUG Got artifact_id: azure-resourcemanager-compute-generated
      cmderr	[Inst] 2021-05-18 19:33:23 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-05-18 19:33:23 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-05-18 19:33:23 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-05-18 19:33:23 DEBUG Match jar package: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-05-18 19:33:23 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14458/azure-sdk-for-java/azure-resourcemanager-compute-generated/azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-compute-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-compute-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from af5a8cece0376be4bad4e5952ed76e77cecb3644. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/compute/resource-manager/readme.md
    • ️✔️@azure/arm-compute [View full logs]  [Preview SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/computeManagementClient.js → ./dist/arm-compute.js...
      cmderr	[npmPack] created ./dist/arm-compute.js in 1.5s
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from af5a8cece0376be4bad4e5952ed76e77cecb3644. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️containerservice/mgmt/2017-01-31/containerservice [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2016-09-30/containerservice [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️containerservice/mgmt/2016-03-30/containerservice [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2021-03-01/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `DeleteOption` in struct `VirtualMachineScaleSetUpdateNetworkConfigurationProperties`
      info	[Changelog] - New field `AssessmentMode` in struct `PatchSettings`
      info	[Changelog] - New field `DeleteOption` in struct `NetworkInterfaceReferenceProperties`
      info	[Changelog]
      info	[Changelog] Total 11 breaking change(s), 343 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2020-12-01/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 0 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2020-06-30/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `EnableFpga` in struct `VirtualMachineScaleSetUpdateNetworkConfigurationProperties`
      info	[Changelog] - New field `GroupByClientApplicationID` in struct `LogAnalyticsInputBase`
      info	[Changelog] - New field `GroupByUserAgent` in struct `LogAnalyticsInputBase`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2020-06-01/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog] - New field `EnableFpga` in struct `VirtualMachineScaleSetNetworkConfigurationProperties`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 9 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2019-12-01/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2019-07-01/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2019-03-01/compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 6 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️compute/mgmt/2018-10-01/compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2018-06-01/compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2018-04-01/compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-12-01/compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-09-01/skus [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2017-03-30/compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2016-03-30/compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️compute/mgmt/2015-06-15/compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/containerservice/mgmt/2015-11-01-preview/containerservice [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/compute/mgmt/2020-10-01-preview/compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/compute/mgmt/2016-04-30-preview/compute [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from af5a8cece0376be4bad4e5952ed76e77cecb3644. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @ctaggart, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants