Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed by tenant approvers #14422

Merged
merged 3 commits into from
May 18, 2021
Merged

Managed by tenant approvers #14422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf3ff11
Add managedByTenantApprovers to Swagger
skayani May 14, 2021
298c4ba
Formatting fixes
skayani May 14, 2021
52d69d2
Small fix
skayani May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...rosoft.ManagedServices/preview/2020-02-01-preview/examples/GetRegistrationDefinition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,13 @@
{
"justInTimeAccessPolicy": {
"multiFactorAuthProvider": "Azure",
"maximumActivationDuration": "PT8H"
"maximumActivationDuration": "PT8H",
"managedByTenantApprovers": [
{
"principalId": "d9b22cd6-6407-43cc-8c60-07c56df0b51a",
"principalIdDisplayName": "Approver Group"
}
]
},
"principalId": "3e0ed8c6-e902-4fc5-863c-e3ddbb2ae2a2",
"principalIdDisplayName": "Support User",
Expand Down
8 changes: 7 additions & 1 deletion ...osoft.ManagedServices/preview/2020-02-01-preview/examples/GetRegistrationDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,13 @@
{
"justInTimeAccessPolicy": {
"multiFactorAuthProvider": "Azure",
"maximumActivationDuration": "PT8H"
"maximumActivationDuration": "PT8H",
"managedByTenantApprovers": [
{
"principalId": "d9b22cd6-6407-43cc-8c60-07c56df0b51a",
"principalIdDisplayName": "Approver Group"
}
]
},
"principalId": "3e0ed8c6-e902-4fc5-863c-e3ddbb2ae2a2",
"principalIdDisplayName": "Support User",
Expand Down
24 changes: 21 additions & 3 deletions ...rosoft.ManagedServices/preview/2020-02-01-preview/examples/PutRegistrationDefinition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,13 @@
"roleDefinitionId": "ae349356-3a1b-4a5e-921d-050484c6347e",
"justInTimeAccessPolicy": {
"multiFactorAuthProvider": "Azure",
"maximumActivationDuration": "PT8H"
"maximumActivationDuration": "PT8H",
"managedByTenantApprovers": [
{
"principalId": "d9b22cd6-6407-43cc-8c60-07c56df0b51a",
"principalIdDisplayName": "Approver Group"
}
]
}
}
]
Expand Down Expand Up @@ -69,7 +75,13 @@
{
"justInTimeAccessPolicy": {
"multiFactorAuthProvider": "Azure",
"maximumActivationDuration": "PT8H"
"maximumActivationDuration": "PT8H",
"managedByTenantApprovers": [
{
"principalId": "d9b22cd6-6407-43cc-8c60-07c56df0b51a",
"principalIdDisplayName": "Approver Group"
}
]
},
"principalId": "3e0ed8c6-e902-4fc5-863c-e3ddbb2ae2a2",
"principalIdDisplayName": "Support User",
Expand Down Expand Up @@ -115,7 +127,13 @@
{
"justInTimeAccessPolicy": {
"multiFactorAuthProvider": "Azure",
"maximumActivationDuration": "PT8H"
"maximumActivationDuration": "PT8H",
"managedByTenantApprovers": [
{
"principalId": "d9b22cd6-6407-43cc-8c60-07c56df0b51a",
"principalIdDisplayName": "Approver Group"
}
]
},
"principalId": "3e0ed8c6-e902-4fc5-863c-e3ddbb2ae2a2",
"principalIdDisplayName": "Support User",
Expand Down
30 changes: 28 additions & 2 deletions ...esource-manager/Microsoft.ManagedServices/preview/2020-02-01-preview/managedservices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,6 +1072,23 @@
"type": "object",
"description": "Eligible authorization tuple containing principle Id (of user/service principal/security group), role definition id, and the just-in-time access setting."
},
"EligibleApprover": {
"properties": {
"principalId": {
"type": "string",
"description": "Principal Id of the user or security group that will approve JIT activation requests for the eligible authorization."
},
"principalIdDisplayName": {
"type": "string",
"description": "Display name of the principal Id."
}
},
"required": [
"principalId"
],
"type": "object",
"description": "A principal Id and user-friendly display name representing an eligible authorization approver."
},
"JustInTimeAccessPolicy": {
"properties": {
"multiFactorAuthProvider": {
Expand All @@ -1084,12 +1101,21 @@
"x-ms-enum": {
"name": "MultiFactorAuthProvider",
"modelAsString": true
}
},
"default": "None"
Copy link
Contributor

@dramuy dramuy May 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"default": "None"

thank you for fixing the default. appreciate it. #Resolved

},
"maximumActivationDuration": {
"type": "string",
"format": "duration",
"description": "Maximum access duration in ISO 8601 format. The default value is \"PT8H\"."
"description": "Maximum access duration in ISO 8601 format.",
"default": "PT8H"
},
"managedByTenantApprovers": {
"type": "array",
"items": {
"$ref": "#/definitions/EligibleApprover"
},
"description": "The list of managedByTenant approvers for the eligible authorization."
}
},
"required": [
Expand Down