adds private link properties, params and examples #13986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @nishantpunetha Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response of operation:'PrivateLinkResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L411 |
|
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L503 |
|
The response of operation:'PrivateEndpointConnections_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L547 |
| The child tracked resource, 'privateLinkResources' with immediate parent 'Workspace', must have a list by immediate parent operation. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L654 |
|
| The child tracked resource, 'privateEndpointConnections' with immediate parent 'Workspace', must have a list by immediate parent operation. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L654 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.Databricks/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L328 |
| Guid used in model definition 'ManagedIdentityConfiguration' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L896 |
|
| Guid used in model definition 'CreatedBy' for property 'oid'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L1055 |
|
| Guid used in model definition 'WorkspaceProviderAuthorization' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L1173 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: value Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L935 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Lists workspaces Location: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L296 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️❌Cross Version BreakingChange (Base on stable version): 5 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.9)
- original: stable/2018-04-01/databricks.json <---> new: preview/2021-04-01-preview/databricks.json
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Databricks/workspaces/{workspaceName}/virtualNetworkPeerings/{peeringName}' removed or restructured? Old: Microsoft.Databricks/stable/2018-04-01/databricks.json#L328:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Databricks/workspaces/{workspaceName}/virtualNetworkPeerings' removed or restructured? Old: Microsoft.Databricks/stable/2018-04-01/databricks.json#L482:5 |
|
The new version is missing a definition that was found in the old version. Was 'VirtualNetworkPeering' removed or renamed? New: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L654:3 Old: Microsoft.Databricks/stable/2018-04-01/databricks.json#L564:3 |
|
The new version is missing a definition that was found in the old version. Was 'VirtualNetworkPeeringPropertiesFormat' removed or renamed? New: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L654:3 Old: Microsoft.Databricks/stable/2018-04-01/databricks.json#L564:3 |
|
The new version is missing a definition that was found in the old version. Was 'AddressSpace' removed or renamed? New: Microsoft.Databricks/preview/2021-04-01-preview/databricks.json#L654:3 Old: Microsoft.Databricks/stable/2018-04-01/databricks.json#L564:3 |
️⚠️[Staging] SDK Track2 Validation: 3 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"databricks/resource-manager/readme.md", "tag":"package-2021-04-01-preview", "details":"Schema 'GroupIdInformation' has a property 'id' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from GroupIdInformation" |
|
| "readme":"databricks/resource-manager/readme.md", "tag":"package-2021-04-01-preview", "details":"Schema 'GroupIdInformation' has a property 'name' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from GroupIdInformation" |
|
| "readme":"databricks/resource-manager/readme.md", "tag":"package-2021-04-01-preview", "details":"Schema 'GroupIdInformation' has a property 'type' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from GroupIdInformation" |
|
| 💬 AutorestCore/Exception | "readme":"databricks/resource-manager/readme.md", "tag":"package-2021-04-01-preview", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"databricks/resource-manager/readme.md", "tag":"package-2021-04-01-preview", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"databricks/resource-manager/readme.md",
"tag":"package-2021-04-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi @nishantpunetha, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Apr 16, 2021
lirenhe
pushed a commit
that referenced
this pull request
Jun 9, 2021
* Adding baseline version from previous stable version * Fixing Avocado errors * Fixing API Version Mismatch Avacado error * Updating SystemData * Fixing examples to have latest API version * Removing vNet Peering APIs as we aren't versioning them * Fixing Lint Errors * Updating CMK Properties * Fixing lint errors * Fixed review comment * Fixing ARM Reviewer Comment * Bringing S360 fixes to new version * Fixing the casing of the keyVaultUri * adds private link properties, params and examples (#13986) * Revert "adds private link properties, params and examples (#13986)" This reverts commit 0498eaa. * Fixing Cross Version Breaking Change Errors * Updating the vNet Peering into Preview Tag as well Co-authored-by: nishantpunetha <nishant.punetha@gmail.com>
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
* Adding baseline version from previous stable version * Fixing Avocado errors * Fixing API Version Mismatch Avacado error * Updating SystemData * Fixing examples to have latest API version * Removing vNet Peering APIs as we aren't versioning them * Fixing Lint Errors * Updating CMK Properties * Fixing lint errors * Fixed review comment * Fixing ARM Reviewer Comment * Bringing S360 fixes to new version * Fixing the casing of the keyVaultUri * adds private link properties, params and examples (Azure#13986) * Revert "adds private link properties, params and examples (Azure#13986)" This reverts commit 0498eaa. * Fixing Cross Version Breaking Change Errors * Updating the vNet Peering into Preview Tag as well Co-authored-by: nishantpunetha <nishant.punetha@gmail.com>
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Adding baseline version from previous stable version * Fixing Avocado errors * Fixing API Version Mismatch Avacado error * Updating SystemData * Fixing examples to have latest API version * Removing vNet Peering APIs as we aren't versioning them * Fixing Lint Errors * Updating CMK Properties * Fixing lint errors * Fixed review comment * Fixing ARM Reviewer Comment * Bringing S360 fixes to new version * Fixing the casing of the keyVaultUri * adds private link properties, params and examples (Azure#13986) * Revert "adds private link properties, params and examples (Azure#13986)" This reverts commit 0498eaa. * Fixing Cross Version Breaking Change Errors * Updating the vNet Peering into Preview Tag as well Co-authored-by: nishantpunetha <nishant.punetha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.