fixing .net sdk #13668

ghost · 2021-03-26T07:18:13Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-03-26T07:18:15Z

Hi, @sharma224 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-03-26T07:18:16Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-03-26T07:18:17Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/automation/resource-manager/readme.md tag: specification/automation/resource-manager/readme.md#tag-package-2020-01-13-preview

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️❌[Staging] SDK Track2 Validation: 2 Errors, 0 Warnings failed [Detail]

The following tags are being changed in this PR

automation/resource-manager/readme.md#package-2020-01-13-preview

The following errors/warnings are introduced by current PR:

Rule	Message
`❌` PreCheck/DuplicateSchema	"readme":"automation/resource-manager/readme.md", "tag":"package-2020-01-13-preview", "details":"Duplicate Schema named ScheduleProperties -- properties.interval.$ref: "#/components/schemas/schemas:647" =>, properties.interval.type: undefined => "integer" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` AutorestCore/Exception	"readme":"automation/resource-manager/readme.md", "tag":"package-2020-01-13-preview", "details":"Error: Plugin prechecker reported failure."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-03-26T07:18:17Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from ed82e6716617b008c3f92f9604f0a25e4f4ddb92. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-automation [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter encryption
info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter public_network_access
info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter identity
info	[Changelog]   - Model AutomationAccount has a new parameter private_endpoint_connections
info	[Changelog]   - Model AutomationAccount has a new parameter encryption
info	[Changelog]   - Model AutomationAccount has a new parameter public_network_access
info	[Changelog]   - Model AutomationAccount has a new parameter identity
info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter encryption
info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter public_network_access
info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter identity
info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model SoftwareUpdateConfigurationCollectionItem no longer has parameter tasks

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from ed82e6716617b008c3f92f9604f0a25e4f4ddb92. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/automation/resource-manager/readme.md

️✔️automation [View full logs] [Preview Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from ed82e6716617b008c3f92f9604f0a25e4f4ddb92. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️automation/mgmt/2019-06-01/automation [View full logs] [Preview SDK Changes]
```
info	[Changelog] This is a new package
```

️✔️automation/mgmt/2015-10-31/automation [View full logs] [Preview SDK Changes]

Only show 20 items here, please refer to log for details.

info	[Changelog] - New function `WatcherListResultPage.NotDone() bool`
info	[Changelog] - New function `Watcher.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `WatcherClient.CreateOrUpdate(context.Context, string, string, string, Watcher) (Watcher, error)`
info	[Changelog] - New function `WatcherClient.GetSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `*WatcherListResultIterator.NextWithContext(context.Context) error`
info	[Changelog] - New struct `PrivateEndpointConnection`
info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
info	[Changelog] - New struct `PrivateEndpointProperty`
info	[Changelog] - New struct `PrivateLinkServiceConnectionStateProperty`
info	[Changelog] - New struct `Watcher`
info	[Changelog] - New struct `WatcherClient`
info	[Changelog] - New struct `WatcherListResult`
info	[Changelog] - New struct `WatcherListResultIterator`
info	[Changelog] - New struct `WatcherListResultPage`
info	[Changelog] - New struct `WatcherProperties`
info	[Changelog] - New struct `WatcherUpdateParameters`
info	[Changelog] - New struct `WatcherUpdateProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 76 additive change(s).
info	[Changelog]

️✔️preview/automation/mgmt/2020-01-13-preview/automation [View full logs] [Preview SDK Changes]
```
info	[Changelog] This is a new package
```

️✔️preview/automation/mgmt/2018-06-30-preview/automation [View full logs] [Preview SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `PrivateLinkServiceConnectionStateProperty.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PrivateEndpointConnection.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*PrivateEndpointConnection.UnmarshalJSON([]byte) error`
info	[Changelog] - New struct `PrivateEndpointConnection`
info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
info	[Changelog] - New struct `PrivateEndpointProperty`
info	[Changelog] - New struct `PrivateLinkServiceConnectionStateProperty`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 11 additive change(s).
info	[Changelog]

️✔️preview/automation/mgmt/2018-01-15-preview/automation [View full logs] [Preview SDK Changes]

info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `*PrivateEndpointConnection.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PrivateLinkServiceConnectionStateProperty.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PrivateEndpointConnection.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `PrivateEndpointConnection`
info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
info	[Changelog] - New struct `PrivateEndpointProperty`
info	[Changelog] - New struct `PrivateLinkServiceConnectionStateProperty`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 11 additive change(s).
info	[Changelog]

️✔️preview/automation/mgmt/2017-05-15-preview/automation [View full logs] [Preview SDK Changes]

Only show 20 items here, please refer to log for details.

info	[Changelog] - New function `WatcherClient.GetResponder(*http.Response) (Watcher, error)`
info	[Changelog] - New function `WatcherClient.StartSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `*Watcher.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `WatcherClient.StartPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `WatcherClient.CreateOrUpdate(context.Context, string, string, string, Watcher) (Watcher, error)`
info	[Changelog] - New struct `PrivateEndpointConnection`
info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
info	[Changelog] - New struct `PrivateEndpointProperty`
info	[Changelog] - New struct `PrivateLinkServiceConnectionStateProperty`
info	[Changelog] - New struct `Watcher`
info	[Changelog] - New struct `WatcherClient`
info	[Changelog] - New struct `WatcherListResult`
info	[Changelog] - New struct `WatcherListResultIterator`
info	[Changelog] - New struct `WatcherListResultPage`
info	[Changelog] - New struct `WatcherProperties`
info	[Changelog] - New struct `WatcherUpdateParameters`
info	[Changelog] - New struct `WatcherUpdateProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 76 additive change(s).
info	[Changelog]

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from ed82e6716617b008c3f92f9604f0a25e4f4ddb92. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/automation/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Automation [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.Automation.3.8.2-preview.nupkg
- Microsoft.Azure.Management.Automation.3.8.2-preview.snupkg

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from ed82e6716617b008c3f92f9604f0a25e4f4ddb92. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-automation [View full logs] [Preview SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter identity
info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter encryption
info	[Changelog]   - Model AutomationAccountUpdateParameters has a new parameter public_network_access
info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter identity
info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter encryption
info	[Changelog]   - Model AutomationAccountCreateOrUpdateParameters has a new parameter public_network_access
info	[Changelog]   - Model AutomationAccount has a new parameter identity
info	[Changelog]   - Model AutomationAccount has a new parameter private_endpoint_connections
info	[Changelog]   - Model AutomationAccount has a new parameter encryption
info	[Changelog]   - Model AutomationAccount has a new parameter public_network_access
info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
info	[Changelog]   - Added operation group PrivateLinkResourcesOperations

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from ed82e6716617b008c3f92f9604f0a25e4f4ddb92. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/automation/resource-manager/readme.md

️✔️@azure/arm-automation [View full logs] [Preview SDK Changes]

azure-arm-automation-10.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/automationClient.js → ./dist/arm-automation.js...
cmderr	[npmPack] created ./dist/arm-automation.js in 931ms

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2021-03-26T07:18:17Z

Thank you for your contribution sharma224! We will review the pull request and get back to you soon.

sdk

083a341

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 26, 2021

ghost closed this Mar 26, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Mar 26, 2021

This was referenced Mar 26, 2021

[AutoPR automation] fixing .net sdk AzureSDKAutomation/azure-resource-manager-schemas#2093

Draft

[AutoPR Microsoft.Azure.Management.Automation] fixing .net sdk AzureSDKAutomation/azure-sdk-for-net#3663

Draft

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixing .net sdk #13668

fixing .net sdk #13668

ghost commented Mar 26, 2021

openapi-workflow-bot bot commented Mar 26, 2021

openapi-workflow-bot bot commented Mar 26, 2021

openapi-pipeline-app bot commented Mar 26, 2021 •

edited

Loading

openapi-pipeline-app bot commented Mar 26, 2021 •

edited

Loading

ghost commented Mar 26, 2021

fixing .net sdk #13668

fixing .net sdk #13668

Conversation

ghost commented Mar 26, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Mar 26, 2021

openapi-workflow-bot bot commented Mar 26, 2021

openapi-pipeline-app bot commented Mar 26, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Mar 26, 2021 • edited Loading

Swagger Generation Artifacts

ghost commented Mar 26, 2021

openapi-pipeline-app bot commented Mar 26, 2021 •

edited

Loading

openapi-pipeline-app bot commented Mar 26, 2021 •

edited

Loading