Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include notification for new directory structure #1364

Merged
merged 5 commits into from
Jul 5, 2017
Merged

Include notification for new directory structure #1364

merged 5 commits into from
Jul 5, 2017

Conversation

salameer
Copy link
Member

Adding description to the new upcoming changes to the repos folder structure

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • [X ] The title of the PR is clear and informative.
  • [X ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • [X ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • [X ] If applicable, the PR references the bug/issue that it fixes.
  • [X ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Adding description to the new upcoming changes to the repos folder structure
@kirthik
Copy link
Contributor

kirthik commented Jun 30, 2017

Could you please take a look at the comments in #1360 and address them here? Not sure why that PR got closed and new one was opened ...

salameer added 3 commits July 2, 2017 20:30
updated Tag values to "package-2017-03"

I hope this is what you meant cause honestly I don't have a lot of context on the decision or pattern for this value :)
@salameer
Copy link
Member Author

salameer commented Jul 3, 2017

Captain @kirthik

Your comments have been addressed in my latest commits, please let me know if there's more to be changed here

Thanks and God Speed LOL

README.md Outdated

```bash
.
├──automation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether we intentionally skipped the top node specification or not https://github.com/Azure/azure-rest-api-specs/tree/reorg. Other than that LGTM! 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm, good point let me add it

Added root folder "Specification"
@salameer salameer merged commit 97eb2b1 into Azure:master Jul 5, 2017
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-ruby

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants