Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stream Analytics] Add Subscription Level APIs #13322

Merged
merged 29 commits into from
Jul 7, 2021

Conversation

roslynlu
Copy link
Contributor

@roslynlu roslynlu commented Mar 8, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.

April

  1. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.

March

  1. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@roslynlu roslynlu requested a review from atpham256 as a code owner March 8, 2021 21:55
@openapi-workflow-bot
Copy link

Hi, @roslynlu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 8, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @roslynlu your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 8, 2021

    Swagger Validation Report

    ️❌BreakingChange: 38 Errors, 236 Warnings failed [Detail]

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.StreamAnalytics/streamingjobs/{jobName}/functions/{functionName}/RetrieveDefaultDefinition' removed or restructured?
    Old: Microsoft.StreamAnalytics/preview/2017-04-01-preview/functions.json#L374:5
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.StreamAnalytics/preview/2017-04-01-preview/functions.json#L124:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.StreamAnalytics/preview/2017-04-01-preview/functions.json#L193:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.StreamAnalytics/preview/2017-04-01-preview/functions.json#L236:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.StreamAnalytics/preview/2017-04-01-preview/functions.json#L288:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.StreamAnalytics/preview/2017-04-01-preview/functions.json#L337:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.StreamAnalytics/preview/2017-04-01-preview/functions.json#L400:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.StreamAnalytics/preview/2017-04-01-preview/inputs.json#L124:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.StreamAnalytics/preview/2017-04-01-preview/inputs.json#L199:11
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.StreamAnalytics/preview/2017-04-01-preview/inputs.json#L242:11
    ️⚠️LintDiff: 2 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isGlobal
    Location: Microsoft.StreamAnalytics/preview/2017-04-01-preview/subscriptions.json#L662
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isGlobal
    Location: Microsoft.StreamAnalytics/preview/2017-04-01-preview/subscriptions.json#L662


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R4015 - NestedResourcesMustHaveListOperation The nested resource 'Transformation' does not have list operation, please add it.
    Location: Microsoft.StreamAnalytics/preview/2017-04-01-preview/transformations.json#L241
    R4015 - NestedResourcesMustHaveListOperation The nested resource 'Transformation' does not have list operation, please add it.
    Location: Microsoft.StreamAnalytics/preview/2017-04-01-preview/transformations.json#L241
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.StreamAnalytics/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.StreamAnalytics/preview/2017-04-01-preview/operations.json#L36
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.StreamAnalytics/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.StreamAnalytics/preview/2017-04-01-preview/operations.json#L36
    R4037 - MissingTypeObject The schema 'FunctionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.StreamAnalytics/preview/2017-04-01-preview/functions.json#L980
    R4037 - MissingTypeObject The schema 'StreamingJobListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.StreamAnalytics/preview/2017-04-01-preview/streamingjobs.json#L692
    R4037 - MissingTypeObject The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.StreamAnalytics/preview/2017-04-01-preview/subscriptions.json#L359
    R4037 - MissingTypeObject The schema 'Cluster' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.StreamAnalytics/preview/2020-03-01-preview/clusters.json#L368
    R4037 - MissingTypeObject The schema 'ClusterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.StreamAnalytics/preview/2020-03-01-preview/clusters.json#L390
    R4037 - MissingTypeObject The schema 'ClusterListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.StreamAnalytics/preview/2020-03-01-preview/clusters.json#L421
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/streamanalytics/resource-manager/readme.md
    tag: specification/streamanalytics/resource-manager/readme.md#tag-package-2020-03-preview
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"streamanalytics/resource-manager/readme.md",
    "tag":"package-2020-03-preview",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"streamanalytics/resource-manager/readme.md",
    "tag":"package-2020-03-preview",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"streamanalytics/resource-manager/readme.md",
    "tag":"package-2020-03-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"streamanalytics/resource-manager/readme.md",
    "tag":"package-pure-2017-04-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"streamanalytics/resource-manager/readme.md",
    "tag":"package-pure-2017-04-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 8, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-streamanalytics - 1.0.0rc1
    azure-sdk-for-go - streamanalytics/mgmt/2016-03-01/streamanalytics - v55.5.0
    +	Field `Location` of struct `Resource` has been removed
    +	Field `Tags` of struct `Resource` has been removed
    ️✔️azure-sdk-for-go - preview/streamanalytics/mgmt/2020-03-01-preview/streamanalytics - v55.5.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b5a2494. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/streamanalytics/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.StreamAnalytics [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b5a2494. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-streamanalytics [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation SubscriptionsOperations.compile_query
      info	[Changelog]   - Added operation SubscriptionsOperations.begin_test_output
      info	[Changelog]   - Added operation SubscriptionsOperations.begin_sample_input
      info	[Changelog]   - Added operation SubscriptionsOperations.begin_test_input
      info	[Changelog]   - Added operation SubscriptionsOperations.begin_test_query
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b5a2494. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️streamanalytics/mgmt/2016-03-01/streamanalytics [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Field `Tags` of struct `Resource` has been removed
      info	[Changelog] - Field `Location` of struct `Resource` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `Csv`
      info	[Changelog] - New const `Avro`
      info	[Changelog] - New const `JSON`
      info	[Changelog] - New function `TrackedResource.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `ProxyResource.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleEventSerializationTypeValues() []EventSerializationType`
      info	[Changelog] - New struct `Error`
      info	[Changelog] - New struct `ErrorDetails`
      info	[Changelog] - New struct `ErrorError`
      info	[Changelog] - New struct `ProxyResource`
      info	[Changelog] - New struct `TrackedResource`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 16 additive change(s).
      info	[Changelog]
    • ️✔️preview/streamanalytics/mgmt/2020-03-01-preview/streamanalytics [View full logs
      Only show 60 items here, please refer to log for details.
      info	[Changelog] - New function `*SubscriptionsTestInputMethodFuture.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `RawStreamInputDataSource.AsEventHubV2StreamInputDataSource() (*EventHubV2StreamInputDataSource, bool)`
      info	[Changelog] - New function `RawOutputDatasource.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `RawReferenceInputDataSource.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `QueryCompilationError.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `RawOutputDatasource.AsPowerBIOutputDataSource() (*PowerBIOutputDataSource, bool)`
      info	[Changelog] - New function `QueryCompilationResult.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `BlobStreamInputDataSource.AsRawStreamInputDataSource() (*RawStreamInputDataSource, bool)`
      info	[Changelog] - New function `RawOutputDatasource.AsBasicOutputDataSource() (BasicOutputDataSource, bool)`
      info	[Changelog] - New function `IoTHubStreamInputDataSource.AsRawStreamInputDataSource() (*RawStreamInputDataSource, bool)`
      info	[Changelog] - New function `*SubscriptionsTestOutputMethodFuture.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `RawReferenceInputDataSource.AsBasicReferenceInputDataSource() (BasicReferenceInputDataSource, bool)`
      info	[Changelog] - New function `*RawStreamInputDataSource.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `PowerBIOutputDataSource.AsRawOutputDatasource() (*RawOutputDatasource, bool)`
      info	[Changelog] - New function `SubscriptionsClient.CompileQueryMethod(context.Context, CompileQuery, string) (QueryCompilationResult, error)`
      info	[Changelog] - New function `EventHubOutputDataSource.AsRawOutputDatasource() (*RawOutputDatasource, bool)`
      info	[Changelog] - New function `AzureDataLakeStoreOutputDataSource.AsRawOutputDatasource() (*RawOutputDatasource, bool)`
      info	[Changelog] - New function `OutputDataSource.AsRawOutputDatasource() (*RawOutputDatasource, bool)`
      info	[Changelog] - New function `EventHubV2StreamInputDataSource.AsRawStreamInputDataSource() (*RawStreamInputDataSource, bool)`
      info	[Changelog] - New function `SubscriptionsClient.TestInputMethodResponder(*http.Response) (TestDatasourceResult, error)`
      info	[Changelog] - New function `RawStreamInputDataSource.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `SubscriptionsClient.TestOutputMethod(context.Context, TestOutput, string) (SubscriptionsTestOutputMethodFuture, error)`
      info	[Changelog] - New function `*SubscriptionsSampleInputMethodFuture.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `AzureSQLDatabaseOutputDataSource.AsRawOutputDatasource() (*RawOutputDatasource, bool)`
      info	[Changelog] - New function `SubscriptionsClient.SampleInputMethod(context.Context, SampleInput, string) (SubscriptionsSampleInputMethodFuture, error)`
      info	[Changelog] - New function `SubscriptionsClient.TestQueryMethod(context.Context, TestQuery, string) (SubscriptionsTestQueryMethodFuture, error)`
      info	[Changelog] - New function `SubscriptionsClient.SampleInputMethodResponder(*http.Response) (SampleInputResult, error)`
      info	[Changelog] - New function `AzureTableOutputDataSource.AsRawOutputDatasource() (*RawOutputDatasource, bool)`
      info	[Changelog] - New function `SubscriptionsClient.TestQueryMethodPreparer(context.Context, TestQuery, string) (*http.Request, error)`
      info	[Changelog] - New function `RawReferenceInputDataSource.AsRawReferenceInputDataSource() (*RawReferenceInputDataSource, bool)`
      info	[Changelog] - New function `ReferenceInputDataSource.AsRawReferenceInputDataSource() (*RawReferenceInputDataSource, bool)`
      info	[Changelog] - New function `SubscriptionsClient.TestInputMethod(context.Context, TestInput, string) (SubscriptionsTestInputMethodFuture, error)`
      info	[Changelog] - New function `BlobReferenceInputDataSource.AsRawReferenceInputDataSource() (*RawReferenceInputDataSource, bool)`
      info	[Changelog] - New function `RawStreamInputDataSource.AsBasicStreamInputDataSource() (BasicStreamInputDataSource, bool)`
      info	[Changelog] - New function `RawOutputDatasource.AsOutputDataSource() (*OutputDataSource, bool)`
      info	[Changelog] - New struct `CompileQuery`
      info	[Changelog] - New struct `QueryCompilationError`
      info	[Changelog] - New struct `QueryCompilationResult`
      info	[Changelog] - New struct `QueryFunction`
      info	[Changelog] - New struct `QueryInput`
      info	[Changelog] - New struct `QueryTestingResult`
      info	[Changelog] - New struct `RawInputDatasourceProperties`
      info	[Changelog] - New struct `RawOutputDatasource`
      info	[Changelog] - New struct `RawOutputDatasourceProperties`
      info	[Changelog] - New struct `RawReferenceInputDataSource`
      info	[Changelog] - New struct `RawStreamInputDataSource`
      info	[Changelog] - New struct `SampleInput`
      info	[Changelog] - New struct `SampleInputResult`
      info	[Changelog] - New struct `SubscriptionsSampleInputMethodFuture`
      info	[Changelog] - New struct `SubscriptionsTestInputMethodFuture`
      info	[Changelog] - New struct `SubscriptionsTestOutputMethodFuture`
      info	[Changelog] - New struct `SubscriptionsTestQueryMethodFuture`
      info	[Changelog] - New struct `TestDatasourceResult`
      info	[Changelog] - New struct `TestInput`
      info	[Changelog] - New struct `TestOutput`
      info	[Changelog] - New struct `TestQuery`
      info	[Changelog] - New struct `TestQueryDiagnostics`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 146 additive change(s).
      info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b5a2494. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/streamanalytics/resource-manager/readme.md
    • ️✔️@azure/arm-streamanalytics [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/streamAnalyticsManagementClient.js → ./dist/arm-streamanalytics.js...
      cmderr	[npmPack] created ./dist/arm-streamanalytics.js in 588ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b5a2494. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️streamanalytics [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi, @roslynlu your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @PhoenixHe-msft

    @openapi-workflow-bot
    Copy link

    Hi @roslynlu, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @j5lim
    Copy link
    Contributor

    j5lim commented Mar 9, 2021

    Please resolve the breaking changes flagged by the tool. Adding new endpoints need a new api version.
    https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#api-changes-that-require-a-version-change

    If you have a justification for breaking changes, please follow the breaking change review checklist in the pr description to get approval.

    @roslynlu
    Copy link
    Contributor Author

    roslynlu commented Mar 9, 2021

    Hi Jin,

    This is what I’m seeing in the documentation:
    “Public previews are released broadly, but contain APIs that may change between previews and may be deleted prior to the final version. The X integer (indicating the revision of the preview) must be incremented for all breaking changes (resulting in a new API version). Evolutionary changes may be added as needed, as long as the change is communicated broadly.
    You should follow the axiom "don't surprise your customers" when deciding whether to increment the preview version, and err on the side of incrementing the preview version.”

    Additionally,
    “Adding a new endpoint is always an evolutionary change.”

    Therefore, it should be up to our discretion and it isn’t a hard requirement to increment the API version right?

    @roslynlu roslynlu changed the title [Stream Analytics] Add Query Testing APIs [Stream Analytics] Add Subscription Level APIs Jul 1, 2021
    @PhoenixHe-NV
    Copy link
    Contributor

    @roslyn Lu Please fix all the CI issues

    @roslynlu
    Copy link
    Contributor Author

    roslynlu commented Jul 6, 2021

    @PhoenixHe-msft, I believe I have fixed everything, is there anything else I need to do for this PR to be merged?

    @openapi-workflow-bot
    Copy link

    Hi @roslynlu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @PhoenixHe-NV PhoenixHe-NV merged commit b5a2494 into Azure:master Jul 7, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * add query testing apis
    
    * add operationId and outputURI
    
    * fix some linter errors
    
    * fix model validation
    
    * address some PR comments
    
    * address some comments
    
    * delete getoperationresults example
    
    * try adding raw input datasource wrappers
    
    * add inputs
    
    * refactor input structure
    
    * add outputs
    
    * modify some descriptions
    
    * address more comments
    
    * add 200 response
    
    * fix formatting
    
    * Delete package-lock.json
    
    * restore package-lock.json
    
    * address final comments
    
    * add compile query
    
    * add sample input api
    
    * add test input and test output apis
    
    * fix validation errors
    
    * update testQuery and compileQuery
    
    * update sample input and test input/output
    
    * final fixes
    
    * fix linter errors pt1
    
    * fix small bugs
    
    * remove duplicate operations def
    
    Co-authored-by: Roslyn Lu <roslu@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants