Addressing Ri Reco Swagger issues #13248

saipv · 2021-03-03T00:31:24Z

Previous link missing
SkuName property is missing

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Previous link missing SkuName property is missing

openapi-workflow-bot · 2021-03-03T00:31:27Z

Hi, @saipv Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-03-03T00:31:28Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2019-10-01/consumption.json <---> new: stable/2019-10-01/consumption.json

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- consumption/resource-manager/readme.md tag:package-2019-10
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- consumption/resource-manager/readme.md tag:package-2019-10

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 52 Warnings warning [Detail]

Only 10 items are listed, please refer to log for more details.

The following tags are being changed in this PR

consumption/resource-manager/readme.md#package-2019-10

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'MeterDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'UsageDetailsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'LegacyUsageDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ModernUsageDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationSummariesListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationSummaryProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationDetailsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationRecommendationDetailsProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationRecommendationDetailsCalculatedSavingsProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-03-03T00:31:29Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from bb53cef. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️consumption/mgmt/2019-10-01/consumption [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 11 items here, please refer to log for details.

info	[Changelog] - New field `Etag` in struct `ModernChargeSummary`
info	[Changelog] - New field `Value` in struct `Tag`
info	[Changelog] - New field `Etag` in struct `PriceSheetResult`
info	[Changelog] - New field `Etag` in struct `EventSummary`
info	[Changelog] - New field `Etag` in struct `ReservationSummary`
info	[Changelog] - New field `Etag` in struct `ManagementGroupAggregatedCostResult`
info	[Changelog] - New field `AdditionalInfo` in struct `MarketplaceProperties`
info	[Changelog] - New field `Etag` in struct `Marketplace`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 38 additive change(s).
info	[Changelog]

️✔️consumption/mgmt/2019-01-01/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-10-01/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-08-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-06-30/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-05-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-03-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2018-01-31/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️consumption/mgmt/2017-11-30/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/consumption/mgmt/2017-12-30-preview/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/consumption/mgmt/2017-04-24-preview/consumption [View full logs] [Release SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from bb53cef. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Consumption [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Consumption.3.0.2.nupkg
- Microsoft.Azure.Management.Consumption.3.0.2.snupkg

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from bb53cef. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md

️✔️consumption [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from bb53cef. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-consumption [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model Forecast has a new parameter etag
info	[Changelog]   - Model Notification has a new parameter threshold_type
info	[Changelog]   - Model TagsResult has a new parameter next_link
info	[Changelog]   - Model TagsResult has a new parameter previous_link
info	[Changelog]   - Model Operation has a new parameter id
info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
info	[Changelog]   - Model PriceSheetResult has a new parameter etag
info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_ratio
info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_group
info	[Changelog]   - Model ReservationDetail has a new parameter kind
info	[Changelog]   - Model ReservationDetail has a new parameter etag
info	[Changelog]   - Model Marketplace has a new parameter etag
info	[Changelog]   - Model Budget has a new parameter filter
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Model ReservationSummary has a new parameter used_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter total_reserved_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter utilized_percentage
info	[Changelog]   - Model ReservationSummary has a new parameter etag
info	[Changelog]   - Model ReservationSummary has a new parameter purchased_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter remaining_quantity
info	[Changelog]   - Model ReservationSummary has a new parameter kind
info	[Changelog]   - Model Balance has a new parameter etag
info	[Changelog]   - Added operation ReservationsSummariesOperations.list
info	[Changelog]   - Added operation ReservationRecommendationsOperations.list
info	[Changelog]   - Added operation ReservationsDetailsOperations.list
info	[Changelog]   - Added operation ChargesOperations.list
info	[Changelog]   - Added operation group LotsOperations
info	[Changelog]   - Added operation group EventsOperations
info	[Changelog]   - Added operation group CreditsOperations
info	[Changelog]   - Added operation group ReservationTransactionsOperations
info	[Changelog]   - Added operation group ReservationRecommendationDetailsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model Budget no longer has parameter filters
info	[Changelog]   - Removed operation UsageDetailsOperations.download
info	[Changelog]   - Model ReservationRecommendation has a new signature
info	[Changelog]   - Model ChargeSummary has a new signature
info	[Changelog]   - Model UsageDetail has a new signature
info	[Changelog]   - Removed operation ChargesOperations.list_by_scope

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from bb53cef. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-consumption [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter etag
info	[Changelog]   - Model Marketplace has a new parameter etag
info	[Changelog]   - Model ModernChargeSummary has a new parameter etag
info	[Changelog]   - Model ModernReservationRecommendation has a new parameter etag
info	[Changelog]   - Model ChargeSummary has a new parameter etag
info	[Changelog]   - Model Forecast has a new parameter etag
info	[Changelog]   - Model ReservationDetail has a new parameter etag
info	[Changelog]   - Model CreditSummary has a new parameter etag
info	[Changelog]   - Model ReservationRecommendationDetailsModel has a new parameter etag
info	[Changelog]   - Model PriceSheetResult has a new parameter etag
info	[Changelog]   - Model LegacyChargeSummary has a new parameter etag
info	[Changelog]   - Model LotSummary has a new parameter etag
info	[Changelog]   - Model EventSummary has a new parameter etag
info	[Changelog]   - Model ReservationRecommendation has a new parameter etag
info	[Changelog]   - Model Operation has a new parameter id
info	[Changelog]   - Model ModernUsageDetail has a new parameter etag
info	[Changelog]   - Model Balance has a new parameter etag
info	[Changelog]   - Model ReservationSummary has a new parameter etag
info	[Changelog]   - Model LegacyUsageDetail has a new parameter etag
info	[Changelog]   - Model UsageDetail has a new parameter etag
info	[Changelog]   - Model TagsResult has a new parameter previous_link
info	[Changelog]   - Model TagsResult has a new parameter next_link
info	[Changelog]   - Model Resource has a new parameter etag
info	[Changelog]   - Added operation ReservationRecommendationDetailsOperations.get

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from bb53cef. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-03-10 03:10:23 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-consumption"
cmderr	[generate.py] 2021-03-10 03:10:23 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-03-10 03:10:23 INFO autorest --version=3.1.0 --use=@autorest/java@4.0.19 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/consumption/azure-resourcemanager-consumption --java.namespace=com.azure.resourcemanager.consumption   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
cmderr	[generate.py] 2021-03-10 03:11:10 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-03-10 03:11:10 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-03-10 03:11:10 INFO [POM][Skip] pom already has module azure-resourcemanager-consumption
cmderr	[generate.py] 2021-03-10 03:11:10 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-03-10 03:11:10 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-03-10 03:11:10 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-consumption [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-03-10 03:14:55 DEBUG Got artifact_id: azure-resourcemanager-consumption
cmderr	[Inst] 2021-03-10 03:14:55 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-03-10 03:14:55 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-10 03:14:55 DEBUG Match jar package: azure-resourcemanager-consumption-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-10 03:14:55 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13248/azure-sdk-for-java/azure-resourcemanager-consumption/azure-resourcemanager-consumption-1.0.0-beta.1.jar\" -o azure-resourcemanager-consumption-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-consumption -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-consumption-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from bb53cef. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md

️✔️@azure/arm-consumption [View full logs] [Release SDK Changes]

azure-arm-consumption-6.3.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js...
cmderr	[npmPack] created ./dist/arm-consumption.js in 533ms

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

raych1 · 2021-03-03T09:26:05Z

@ArcturusZhang @msyyc , can you confirm if adding readonly properties would cause breaking change for GO/Python SDK?

msyyc · 2021-03-08T06:48:18Z

For python, the breaking change is not caused by this PR.

raych1 · 2021-03-08T09:17:54Z

@ArcturusZhang , can you check the potential GO sdk breaking change?

ArcturusZhang · 2021-03-09T03:40:13Z

@raych1 breaking changes are false alarms

The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: #12777 #12555 #13039 #13097 #12822 #13280 #12942 #13248 #13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (Azure#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

Adding fixes made in 2019-10-01 to 2019-11-01 (#13414) The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure/azure-rest-api-specs#12777 Azure/azure-rest-api-specs#12555 Azure/azure-rest-api-specs#13039 Azure/azure-rest-api-specs#13097 Azure/azure-rest-api-specs#12822 Azure/azure-rest-api-specs#13280 Azure/azure-rest-api-specs#12942 Azure/azure-rest-api-specs#13248 Azure/azure-rest-api-specs#13378 This PR is to add those corrections to 2019-11-01 version

* Addressing Ri Reco Swagger issues Previous link missing SkuName property is missing * Fixing one more for the location attribute in Ri Reco response

The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure#12777 Azure#12555 Azure#13039 Azure#13097 Azure#12822 Azure#13280 Azure#12942 Azure#13248 Azure#13378 This PR is to add those corrections to 2019-11-01 version

* Addressing Ri Reco Swagger issues Previous link missing SkuName property is missing * Fixing one more for the location attribute in Ri Reco response

The PR for adding new version 2019-11-01 took longer than expected to be approved, so some fixes made in 10-01 were not included in 2019-11-01 version. The missing changes were the following PRs: Azure#12777 Azure#12555 Azure#13039 Azure#13097 Azure#12822 Azure#13280 Azure#12942 Azure#13248 Azure#13378 This PR is to add those corrections to 2019-11-01 version

Addressing Ri Reco Swagger issues

5032dbf

Previous link missing SkuName property is missing

saipv requested a review from kjeur as a code owner March 3, 2021 00:31

openapi-assignment-bot bot assigned raych1 Mar 3, 2021

openapi-workflow-bot bot added the FixS360 label Mar 3, 2021

saipv requested a review from sri- March 3, 2021 00:35

openapi-sdkautomation bot mentioned this pull request Mar 3, 2021

[AutoPR @azure/arm-consumption] Addressing Ri Reco Swagger issues AzureSDKAutomation/azure-sdk-for-js#3867

Closed

saipv requested a review from sachin-msft March 3, 2021 00:35

openapi-sdkautomation bot mentioned this pull request Mar 3, 2021

[AutoPR azure-mgmt-consumption] Addressing Ri Reco Swagger issues AzureSDKAutomation/azure-sdk-for-python#4460

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python label Mar 3, 2021

This was referenced Mar 3, 2021

[AutoPR consumption] Addressing Ri Reco Swagger issues AzureSDKAutomation/azure-resource-manager-schemas#1851

Closed

[AutoPR track2_azure-mgmt-consumption] Addressing Ri Reco Swagger issues AzureSDKAutomation/azure-sdk-for-python#4461

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Mar 3, 2021

This was referenced Mar 3, 2021

[AutoPR Microsoft.Azure.Management.Consumption] Addressing Ri Reco Swagger issues AzureSDKAutomation/azure-sdk-for-net#3412

Closed

[AutoPR azure-resourcemanager-consumption] Addressing Ri Reco Swagger issues AzureSDKAutomation/azure-sdk-for-java#7704

Closed

Fixing one more for the location attribute in Ri Reco response

f4e00d9

sri- approved these changes Mar 8, 2021

View reviewed changes

raych1 merged commit bb53cef into master Mar 10, 2021

Lira-tron mentioned this pull request Mar 15, 2021

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-11-01 #13414

Merged

25 tasks

JackTn deleted the dev-consumption-Microsoft.Consumption-2019-10-01-saipv4 branch August 17, 2021 06:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addressing Ri Reco Swagger issues #13248

Addressing Ri Reco Swagger issues #13248

saipv commented Mar 3, 2021 •

edited

Loading

openapi-workflow-bot bot commented Mar 3, 2021

openapi-pipeline-app bot commented Mar 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Mar 3, 2021 •

edited

Loading

raych1 commented Mar 3, 2021

msyyc commented Mar 8, 2021

raych1 commented Mar 8, 2021

ArcturusZhang commented Mar 9, 2021

Addressing Ri Reco Swagger issues #13248

Addressing Ri Reco Swagger issues #13248

Conversation

saipv commented Mar 3, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Mar 3, 2021

openapi-pipeline-app bot commented Mar 3, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Mar 3, 2021 • edited Loading

Swagger Generation Artifacts

raych1 commented Mar 3, 2021

msyyc commented Mar 8, 2021

raych1 commented Mar 8, 2021

ArcturusZhang commented Mar 9, 2021

saipv commented Mar 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Mar 3, 2021 •

edited

Loading

openapi-pipeline-app bot commented Mar 3, 2021 •

edited

Loading