Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent class of ClusterResource and DataCenterResource in .NET SDK #13244

Merged
merged 4 commits into from
Mar 4, 2021

Commits on Mar 2, 2021

  1. Fix parent class of ClusterResource and DataCenterResource in .NET SDK

    Removed x-ms-azure-resource from ClusterResource and DataCenterResource. x-ms-azure-resource is already set on the ProxyResource and TrackedResource definitions that ClusterResource and DataCenterResource, and when it's applied it on ClusterResource or DataCenterResource directly, it forces the parent class to be IResource in the .NET SDK and loses the location, type, id, etc. parameters.
    frrossms committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    2fa56c0 View commit details
    Browse the repository at this point in the history
  2. Switched to CosmosDB's ARM resource parents.

    The types.json ones throw errors. In particular, I can't use TrackedResource because it sets location to be required, and the same field is not found by the linter.
    frrossms committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    519bab0 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Configuration menu
    Copy the full SHA
    73e0f47 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c3617fa View commit details
    Browse the repository at this point in the history