Adding Azure CLI build configuration for Quota APIs #13202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pportTicketAction. 2. Removing state=enabledForPreview. 3. Updating Example.
…20-10-01-preview/reservations.json, which matches the previous SDK release. 2. Documentation changes.
…ONE quota request, so changing quotas to quota.
This reverts commit 8f58d34.
This was referenced Mar 1, 2021
|
@JustinConway Please point me to readme.cli.md commands and formats. How do I resolve this error? |
|
Please review the PR. The CLI generation Issue is fixed. Thanks. |
qiaozha
reviewed
Mar 8, 2021
| basic-setup-py: true | ||
| output-folder: $(python-sdks-folder)/reservations/azure-mgmt-reservations | ||
| ``` | ||
| See configuration in [readme.cli.md](./readme.cli.md) |
There was a problem hiding this comment.
actually readme.az.md is for azure-cli readme.cli,md is meant to for all command line tools
| package-name: azure-mgmt-reservations | ||
| az-output-folder: $(azure-cli-extension-folder)/src/reservations | ||
| python-sdk-output-folder: "$(az-output-folder)/azext_reservations/vendored_sdks/quota" | ||
| ``` |
There was a problem hiding this comment.
based on the scenario that quota and reservation is functionally independent, I would suggest you to use multi-package https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/code-gen/configure-cli.md#multi-packages
|
Assigning this to @qiaozha since I have no knowledge on azure CLI configurations... |
qiaozha
approved these changes
Mar 17, 2021
|
Please let me know, if anything else is needed from myside? |
This was referenced Mar 19, 2021
Closed
Merged
|
merged |
This was referenced Mar 19, 2021
|
What's the process for Azure Powershell release? |
MirzaSikander
pushed a commit
to MirzaSikander/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2021
* 1.Breaking Change - Removing duplicate autoQuotaIncreaseState from supportTicketAction. 2. Removing state=enabledForPreview. 3. Updating Example. * Updating Provider name in example. * Capacity RP Quota APIs for GA * Adding preview version to stable dir as base files. * Files from preview version, which will be removed. * Updating to GA Version. * 1. Updated reservation version tag to - Microsoft.Capacity/preview/2020-10-01-preview/reservations.json, which matches the previous SDK release. 2. Documentation changes. * Documentation updates for put and patch request, which includes only ONE quota request, so changing quotas to quota. * Update documenation for put. * Doc update. * Adding -preview tag for GO sdk. * Updating Go settings for output folder to be -preview. * Adding preview subdir for GO package. * Adding preview subdir to Go sdk path. * Removing tag - tag: package-2020-10-25-preview * introduce a new tag to keep the go sdk package unchanged * Revert "introduce a new tag to keep the go sdk package unchanged" This reverts commit 8f58d34. * Adding Azure CLI readme configuration. * Updating the ReadMe configurations. * Updating readme.md * Removing duplicate cli: tag. * Fixing build issues. * Removing Parameter alias. * cli config changes. * Updating the package name to reservation. * Updates - removin .az.md. * Updating Example names to be unique for Get PUT * Adding operations and python-sdk-output-folder. * Updates. * Removing unused file. * Revert "Removing unused file." This reverts commit 4f763bd. * Revert "Revert "Removing unused file."" This reverts commit 60c520e. * Add reference to python readme.md file. * Adding python readme file. * Adding Operations for test-scenario * Adding split * Disabling few operation, which is not needed. * Removing split for Operation * Disabling the reservation Operations. * Disable reservation operations. * Revert "Disable reservation operations." This reverts commit d98cbcb. * Adding client-subscription-bound: false Co-authored-by: Arcturus Zhang <dapzhang@microsoft.com>
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* 1.Breaking Change - Removing duplicate autoQuotaIncreaseState from supportTicketAction. 2. Removing state=enabledForPreview. 3. Updating Example. * Updating Provider name in example. * Capacity RP Quota APIs for GA * Adding preview version to stable dir as base files. * Files from preview version, which will be removed. * Updating to GA Version. * 1. Updated reservation version tag to - Microsoft.Capacity/preview/2020-10-01-preview/reservations.json, which matches the previous SDK release. 2. Documentation changes. * Documentation updates for put and patch request, which includes only ONE quota request, so changing quotas to quota. * Update documenation for put. * Doc update. * Adding -preview tag for GO sdk. * Updating Go settings for output folder to be -preview. * Adding preview subdir for GO package. * Adding preview subdir to Go sdk path. * Removing tag - tag: package-2020-10-25-preview * introduce a new tag to keep the go sdk package unchanged * Revert "introduce a new tag to keep the go sdk package unchanged" This reverts commit 8f58d34. * Adding Azure CLI readme configuration. * Updating the ReadMe configurations. * Updating readme.md * Removing duplicate cli: tag. * Fixing build issues. * Removing Parameter alias. * cli config changes. * Updating the package name to reservation. * Updates - removin .az.md. * Updating Example names to be unique for Get PUT * Adding operations and python-sdk-output-folder. * Updates. * Removing unused file. * Revert "Removing unused file." This reverts commit 4f763bd. * Revert "Revert "Removing unused file."" This reverts commit 60c520e. * Add reference to python readme.md file. * Adding python readme file. * Adding Operations for test-scenario * Adding split * Disabling few operation, which is not needed. * Removing split for Operation * Disabling the reservation Operations. * Disable reservation operations. * Revert "Disable reservation operations." This reverts commit d98cbcb. * Adding client-subscription-bound: false Co-authored-by: Arcturus Zhang <dapzhang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
[x ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.