Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 #13196

Merged
merged 4 commits into from
Mar 11, 2021
Merged

[Hub Generated] Review request for Microsoft.KeyVault to add version stable/2019-09-01 #13196

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8914aa5
Add missing property and annotation
jiacheng-L Feb 28, 2021
bf3d993
Fix typo
jiacheng-L Feb 28, 2021
89c876a
Address PR comment
jiacheng-L Mar 8, 2021
d70bb07
Prettier Check
jiacheng-L Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .../keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/createVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@
"enabledForDeployment": true,
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
"vaultUri": "https://sample-vault.vault.azure.net",
"provisioningState": "Succeeded"
}
Expand Down Expand Up @@ -243,6 +244,7 @@
"enabledForDeployment": true,
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
"vaultUri": "https://sample-vault.vault.azure.net",
"provisioningState": "Succeeded"
}
Expand Down
2 changes: 2 additions & 0 deletions ...rce-manager/Microsoft.KeyVault/stable/2019-09-01/examples/createVaultWithNetworkAcls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
"enabledForDeployment": true,
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
"vaultUri": "https://sample-vault.vault.azure.net"
}
}
Expand Down Expand Up @@ -106,6 +107,7 @@
"enabledForDeployment": true,
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
"vaultUri": "https://sample-vault.vault.azure.net"
}
}
Expand Down
1 change: 1 addition & 0 deletions ...ion/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/getVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"enabledForDeployment": true,
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
"vaultUri": "https://sample-vault.vault.azure.net",
"provisioningState": "Succeeded"
}
Expand Down
1 change: 1 addition & 0 deletions ...ource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/listVaultByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"enableSoftDelete": true,
"hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
"vaultUri": "https://sample-vault.vault.azure.net/",
"provisioningState": "Succeeded"
}
Expand Down
1 change: 1 addition & 0 deletions ...source-manager/Microsoft.KeyVault/stable/2019-09-01/examples/listVaultBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"enableSoftDelete": true,
"hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
"vaultUri": "https://sample-vault.vault.azure.net/",
"provisioningState": "Succeeded"
}
Expand Down
2 changes: 2 additions & 0 deletions .../keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/examples/updateVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@
"enabledForDeployment": true,
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
"vaultUri": "https://sample-vault.vault.azure.net",
"provisioningState": "Succeeded"
}
Expand Down Expand Up @@ -243,6 +244,7 @@
"enabledForDiskEncryption": true,
"enabledForTemplateDeployment": true,
"vaultUri": "https://sample-vault.vault.azure.net",
"hsmPoolResourceId": "00000000-0000-0000-0000-000000000000",
"provisioningState": "Succeeded"
}
}
Expand Down
6 changes: 4 additions & 2 deletions specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keys.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,12 +461,14 @@
"name": "JsonWebKeyOperation",
"modelAsString": true
}
}
},
"readOnly": true
},
"keySize": {
"type": "integer",
"format": "int32",
"description": "The key size in bits. For example: 2048, 3072, or 4096 for RSA."
"description": "The key size in bits. For example: 2048, 3072, or 4096 for RSA.",
"readOnly": true
},
"curveName": {
"type": "string",
Expand Down
8 changes: 7 additions & 1 deletion specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,6 +1261,11 @@
"type": "string",
"description": "The URI of the vault for performing operations on keys and secrets. This property is readonly"
},
"hsmPoolResourceId": {
"type": "string",
"description": "The resource id of HSM Pool.",
"readOnly": true
},
"enabledForDeployment": {
"type": "boolean",
"description": "Property to specify whether Azure Virtual Machines are permitted to retrieve certificates stored as secrets from the key vault."
Expand Down Expand Up @@ -1299,7 +1304,8 @@
"x-ms-enum": {
"name": "CreateMode",
"modelAsString": false
}
},
"x-ms-secret": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createMode doesn't seem to be a secret?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for fixing this swagger error: https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=6412D966-7158-4823-A942-17403BA9635C. Based on the document here, write-only or secret-carrier can marked with "x-ms-secret"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write-only and secret is different things, please use "x-ms-mutability": ["create", "update"] for write-only annotation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiacheng-L , can you make this change?

},
"enablePurgeProtection": {
"type": "boolean",
Expand Down