Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Iothub] Added new routing source [version 2021-02-01-preview] #13069

Merged
merged 6 commits into from
Mar 2, 2021
Merged

[Iothub] Added new routing source [version 2021-02-01-preview] #13069

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4aa12ea
Adds base for updating Microsoft.Devices from version preview/2020-08…
kdonthineni Feb 20, 2021
c1c5a58
Updates readme
kdonthineni Feb 20, 2021
94248f2
Updates API version in new specs and examples
kdonthineni Feb 20, 2021
00f85fa
Update iothub.json
kdonthineni Feb 20, 2021
2aed63d
Update iothub.json
kdonthineni Feb 24, 2021
95b88b5
Update iothub.json
kdonthineni Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions ...fication/iothub/resource-manager/Microsoft.Devices/preview/2021-02-01-preview/iothub.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3134,7 +3134,8 @@
"TwinChangeEvents",
"DeviceLifecycleEvents",
"DeviceJobLifecycleEvents",
"DigitalTwinChangeEvents"
"DigitalTwinChangeEvents",
"DeviceConnectionStateEvents"
],
"type": "string",
"x-ms-enum": {
Expand Down Expand Up @@ -4240,8 +4241,18 @@
"readOnly": true
},
"type": {
kdonthineni marked this conversation as resolved.
Show resolved Hide resolved
"description": "Identity type. Only allowed values are SystemAssigned and UserAssigned. Comma separated if both for ex: SystemAssigned,UserAssigned",
"type": "string"
"description": "The type of identity used for the resource. The type 'SystemAssigned,UserAssigned' includes both an implicitly created identity and a set of user assigned identities. The type 'None' will remove any identities from the service.",
"type": "string",
"enum": [
"SystemAssigned",
"UserAssigned",
"SystemAssigned,UserAssigned",
"None"
],
"x-ms-enum": {
"name": "ResourceIdentityType",
"modelAsString": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modelAsString should be set to false as mentioned in above example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RamyasreeChakka we are setting modelAsString : true, as other enums in our swagger were using in that way and to maintain that consistent behaviour.

Copy link
Member

@RamyasreeChakka RamyasreeChakka Feb 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimengan - ARM common definitions are present here:

azure-rest-api-specs/specification/common-types/resource-management/v2/types.json

Line 221 in a06d912

"Identity": {

These are the guidance for RPs. In the common definition also, for identity -> modelAsString is set to false to allow strict validation. I would leave it up to you to make the call here. Signing off from ARM side.

For more details: http://azure.github.io/autorest/extensions/#x-ms-enum

}
},
"userAssignedIdentities": {
"type": "object",
Expand Down