Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Iothub] Added new routing source [version 2021-02-01-preview] #13069
[Iothub] Added new routing source [version 2021-02-01-preview] #13069
Changes from 1 commit
4aa12ea
c1c5a58
94248f2
00f85fa
2aed63d
95b88b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modelAsString should be set to false as mentioned in above example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RamyasreeChakka we are setting modelAsString : true, as other enums in our swagger were using in that way and to maintain that consistent behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nimengan - ARM common definitions are present here:
azure-rest-api-specs/specification/common-types/resource-management/v2/types.json
Line 221 in a06d912
These are the guidance for RPs. In the common definition also, for identity -> modelAsString is set to false to allow strict validation. I would leave it up to you to make the call here. Signing off from ARM side.
For more details: http://azure.github.io/autorest/extensions/#x-ms-enum