-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Resource Graph - Resource Changes API 2020-09-01_preview update. #13052
Azure Resource Graph - Resource Changes API 2020-09-01_preview update. #13052
Conversation
Hi, @alexaloni Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: fetchSnapshots Location: Microsoft.ResourceGraph/preview/2020-09-01-preview/resourcechanges.json#L173 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Basic query Location: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourcegraph.json#L76 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: First page query Location: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourcegraph.json#L76 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Next page query Location: Microsoft.ResourceGraph/preview/2020-04-01-preview/resourcegraph.json#L76 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/resourcegraph/resource-manager/readme.md tag: specification/resourcegraph/resource-manager/readme.md#tag-package-preview-2020-09 |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️
[Staging] Cross Version BreakingChange (Base on preview version): 14 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
[Staging] SDK Track2 Validation: 9 Warnings warning [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
"readme":"resourcegraph/resource-manager/readme.md", "tag":"package-preview-2020-09", "details":"The schema 'ResourceChangeData-beforeSnapshot' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"resourcegraph/resource-manager/readme.md", "tag":"package-preview-2020-09", "details":"The schema 'ResourceChangeData-afterSnapshot' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"resourcegraph/resource-manager/readme.md", "tag":"package-preview-2020-09", "details":"The schema 'QueryRequestOptions' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"resourcegraph/resource-manager/readme.md", "tag":"package-preview-2020-09", "details":"The schema 'FacetRequestOptions' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"resourcegraph/resource-manager/readme.md", "tag":"package-preview-2020-09", "details":"The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"resourcegraph/resource-manager/readme.md", "tag":"package-preview-2020-09", "details":"The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"resourcegraph/resource-manager/readme.md", "tag":"package-preview-2020-09", "details":"The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
"readme":"resourcegraph/resource-manager/readme.md", "tag":"package-preview-2020-09", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
|
"readme":"resourcegraph/resource-manager/readme.md", "tag":"package-preview-2020-09", "details":"The schema 'ResourceChangeList-$skipToken' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resourcegraph/resource-manager/Microsoft.ResourceGraph/preview/2020-09-01-preview/resourcechanges.json#/components/schemas/ResourceChangeList-$skipToken" |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
Hi @alexaloni, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Looks good from ARM perspective, signing off. |
Please try to resolve the warnings |
@ArcturusZhang , can you check the if this PR causes GO SDK breaking change? |
I reviewed the warnings - most of them are not critical and relates to resource history and resource graph , so not applicable to resource changes. |
Breaking changes in Go come from previous PRs |
Azure#13052) * initial drop of previous version * publishing the actual change * pretty check update * updating response for resource change details to return list Co-authored-by: Alex Dubinkov <alexdu@microsoft.com>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.