Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix semantic and example errors in previous versions for compatability #12909

Merged
merged 1 commit into from
Feb 21, 2021
Merged

fix semantic and example errors in previous versions for compatability #12909

merged 1 commit into from
Feb 21, 2021

Conversation

jdhms
Copy link
Contributor

@jdhms jdhms commented Feb 9, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

  • Update existing versions to use the common parameters for subscriptionId, resourceGroupName, and apiVersion. This enables compatibility when fixing subsequent s360 issues
  • Provide unique names for examples per validation errors
  • Add required and default responses

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @jdhms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki [Window to Fix Broken]( Window to Fix Broken - Overview (azure.com)) for more details.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 9, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 106 Errors, 0 Warnings failed [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed?
    New: Microsoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json#L229:3
    Old: Microsoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json#L217:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupNameParameter' removed or renamed?
    New: Microsoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json#L229:3
    Old: Microsoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json#L217:3
    ❌ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed?
    New: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L229:3
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-ProviderOperationsCalls.json#L225:3
    ❌ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Authorization/preview/2015-06-01/authorization-ClassicAdminCalls.json#L59:11
    ❌ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Authorization/preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json#L99:11
    ❌ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Authorization/preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json#L149:11
    ❌ 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.Authorization/preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json#L201:11
    ❌ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Authorization/preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json#L204:11
    ❌ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Authorization/preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json#L259:11
    ❌ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Authorization/preview/2017-10-01-preview/authorization-RoleAssignmentsCalls.json#L305:11
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 340 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentSchedule' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleInstanceFilter' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleInstanceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleInstance' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2020-10-01-preview",
    "details":"The schema 'RoleAssignmentScheduleInstanceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 9, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️🔄 azure-sdk-for-net inProgress [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f0a0a9f. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️authorization/mgmt/2015-07-01/authorization [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
info	[Changelog]
    • ️✔️preview/authorization/mgmt/2020-04-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] No exported changes
    • ️✔️preview/authorization/mgmt/2018-09-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]
    • ️✔️preview/authorization/mgmt/2018-07-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]
    • ️✔️preview/authorization/mgmt/2018-01-01-preview/authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
info	[Changelog]
    • ️✔️preview/authorization/mgmt/2017-10-01-preview/authorization [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog] - Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
info	[Changelog]
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f0a0a9f. Schema Automation 14.0.0 
      warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleAssignmentId}': Unable to locate '/providers/' segment
cmdout	[Autorest] WARNING: Skipping path '/{roleAssignmentId}': Unable to locate '/providers/' segment
    • ️✔️authorization [View full logs]  [Release Schema Changes] 
      cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN
cmderr	[resource-manager] Using request for node-pre-gyp https download
cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f0a0a9f. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-authorization [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model RoleAssignment has a new parameter updated_on
info	[Changelog]   - Model RoleAssignment has a new parameter delegated_managed_identity_resource_id
info	[Changelog]   - Model RoleAssignment has a new parameter created_by
info	[Changelog]   - Model RoleAssignment has a new parameter created_on
info	[Changelog]   - Model RoleAssignment has a new parameter updated_by
info	[Changelog]   - Added operation group AccessReviewInstanceOperations
info	[Changelog]   - Added operation group AccessReviewDefaultSettingsOperations
info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalStepOperations
info	[Changelog]   - Added operation group AccessReviewInstancesAssignedForMyApprovalOperations
info	[Changelog]   - Added operation group AccessReviewInstanceDecisionsOperations
info	[Changelog]   - Added operation group RoleAssignmentApprovalStepsOperations
info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalStepsOperations
info	[Changelog]   - Added operation group AccessReviewInstancesOperations
info	[Changelog]   - Added operation group RoleAssignmentApprovalStepOperations
info	[Changelog]   - Added operation group RoleAssignmentApprovalOperations
info	[Changelog]   - Added operation group AccessReviewInstanceMyDecisionsOperations
info	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsOperations
info	[Changelog]   - Added operation group Operations
info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalOperations
info	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsAssignedForMyApprovalOperations
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f0a0a9f. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
    • ️✔️@azure/arm-authorization [View full logs]  [Release SDK Changes] 
      cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/authorizationManagementClient.js → ./dist/arm-authorization.js...
cmderr	[npmPack] created ./dist/arm-authorization.js in 177ms
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f0a0a9f. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-21 21:49:11 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-authorization-generated"
cmderr	[generate.py] 2021-02-21 21:49:11 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-21 21:49:11 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.16 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/authorization/azure-resourcemanager-authorization-generated --java.namespace=com.azure.resourcemanager.authorization.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
cmderr	[generate.py] 2021-02-21 21:49:52 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-21 21:49:52 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-21 21:49:52 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-21 21:49:52 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-21 21:49:52 INFO [POM][Skip] pom already has module sdk/authorization
cmderr	[generate.py] 2021-02-21 21:49:52 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-authorization-generated [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-02-21 21:52:41 DEBUG Got artifact_id: azure-resourcemanager-authorization-generated
cmderr	[Inst] 2021-02-21 21:52:41 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-21 21:52:41 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-02-21 21:52:41 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-02-21 21:52:41 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-21 21:52:41 DEBUG Match jar package: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-21 21:52:41 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12909/azure-sdk-for-java/azure-resourcemanager-authorization-generated/azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-authorization-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @jdhms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    This was referenced Feb 9, 2021
    Closed
    Closed
    Closed
    This was referenced Feb 9, 2021
    Closed
    Closed
    @jdhms
    Copy link
    Contributor Author

    jdhms commented Feb 9, 2021

    Hi @allenjzhang,

    This PR fixes some semantic errors in previous preview versions, which will enable us to fix further s360 issues. The issues were with swagger only:

    • Update existing versions to use the common parameters for compatibility when fixing subsequent s360 issues
    • Provide unique names for examples per validation errors
    • Add required and default responses

    @allenjzhang
    Copy link
    Member

    /azp run SDK azure-sdk-for-net

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @allenjzhang
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @allenjzhang allenjzhang added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed BreakingChangeReviewRequired labels Feb 21, 2021
    @allenjzhang allenjzhang merged commit f0a0a9f into Azure:master Feb 21, 2021
    This was referenced Feb 21, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    This was referenced Feb 21, 2021
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @jdhms @mkarmark
    fix semantic and example errors in previous versions for compatability (
    986543b 
    Azure#12909)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @allenjzhang allenjzhang allenjzhang approved these changes

    @stankovski stankovski Awaiting requested review from stankovski stankovski is a code owner

    Assignees

    @allenjzhang allenjzhang

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go FixS360
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @jdhms @allenjzhang