Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Public private branch 'dev-maintenance-Microsoft.Maintenance-2021-04-01-preview' #12899

Conversation

KalpeshChavan12
Copy link
Contributor

This PR moves the private branch that was created into public. The branch has already been reviewed, to view the status, please go to the OpenAPI Hub.

@openapi-workflow-bot
Copy link

Hi, @KalpeshChavan12 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 8, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 1 Warnings warning [Detail]

    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L2228
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 15 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L185:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L261:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L344:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L413:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L604:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L692:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L695:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L858:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L932:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L935:11
    ️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 15 Warnings warning [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L185:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L261:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L344:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L413:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L604:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L692:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L695:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L858:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L932:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Maintenance/preview/2021-04-01-preview/Maintenance.json#L935:11
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]

    Rule Message
    ⚠️ PreCheck/CheckDuplicateSchemas "readme":"maintenance/resource-manager/readme.md",
    "tag":"package-preview-2021-04",
    "details":"Checking for duplicate schemas,
    this could take a (long) while. Run with --verbose for more detail."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 8, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4760eb1. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/maintenance/resource-manager/readme.md
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.Maintenance/configurationAssignments. Skipping definition with path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{providerName}/{resourceType}/{resourceName}/providers/Microsoft.Maintenance/configurationAssignments/{configurationAssignmentName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.Maintenance/configurationAssignments. Using definition with path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{providerName}/{resourceParentType}/{resourceParentName}/{resourceType}/{resourceName}/providers/Microsoft.Maintenance/configurationAssignments/{configurationAssignmentName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.Maintenance/configurationAssignments. Skipping definition with path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{providerName}/{resourceType}/{resourceName}/providers/Microsoft.Maintenance/configurationAssignments/{configurationAssignmentName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.Maintenance/configurationAssignments. Using definition with path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{providerName}/{resourceParentType}/{resourceParentName}/{resourceType}/{resourceName}/providers/Microsoft.Maintenance/configurationAssignments/{configurationAssignmentName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.Maintenance/configurationAssignments. Skipping definition with path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{providerName}/{resourceType}/{resourceName}/providers/Microsoft.Maintenance/configurationAssignments/{configurationAssignmentName}'.
      cmdout	[Autorest] WARNING: Found duplicate definition for variable-named type Microsoft.Maintenance/configurationAssignments. Using definition with path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{providerName}/{resourceParentType}/{resourceParentName}/{resourceType}/{resourceName}/providers/Microsoft.Maintenance/configurationAssignments/{configurationAssignmentName}'.
    • ️✔️maintenance [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 4760eb1. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-maintenance [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model Resource has a new parameter system_data
      info	[Changelog]   - Model Operation has a new parameter is_data_action
      info	[Changelog]   - Model ApplyUpdate has a new parameter system_data
      info	[Changelog]   - Model ConfigurationAssignment has a new parameter system_data
      info	[Changelog]   - Model MaintenanceConfiguration has a new parameter visibility
      info	[Changelog]   - Model MaintenanceConfiguration has a new parameter start_date_time
      info	[Changelog]   - Model MaintenanceConfiguration has a new parameter install_patches
      info	[Changelog]   - Model MaintenanceConfiguration has a new parameter recur_every
      info	[Changelog]   - Model MaintenanceConfiguration has a new parameter duration
      info	[Changelog]   - Model MaintenanceConfiguration has a new parameter system_data
      info	[Changelog]   - Model MaintenanceConfiguration has a new parameter time_zone
      info	[Changelog]   - Model MaintenanceConfiguration has a new parameter expiration_date_time
      info	[Changelog]   - Added operation ConfigurationAssignmentsOperations.get
      info	[Changelog]   - Added operation ConfigurationAssignmentsOperations.get_parent
      info	[Changelog]   - Added operation ApplyUpdatesOperations.list
      info	[Changelog]   - Added operation group ConfigurationAssignmentsWithinSubscriptionOperations
      info	[Changelog]   - Added operation group ApplyUpdateForResourceGroupOperations
      info	[Changelog]   - Added operation group PublicMaintenanceConfigurationsOperations
      info	[Changelog]   - Added operation group MaintenanceConfigurationsForResourceGroupOperations
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 4760eb1. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️maintenance/mgmt/2020-04-01/maintenance [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/maintenance/mgmt/2018-06-01-preview/maintenance [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @allenjzhang
    Copy link
    Member

    ApiDocPreview passed in ADO pipeline.

    @allenjzhang allenjzhang merged commit 4760eb1 into master Feb 9, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    …tenance-2021-04-01-preview' (Azure#12899)
    
    * Adds base for updating Microsoft.Maintenance from version preview/2020-07-01-preview to version 2021-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Added Guest OS patch configuration support in maintenance config.
    
    * Fixed typos.
    
    * Fixed typos for TaskScope enum.
    
    * Added Get method for config assignments.
    
    * Fixed Example.
    
    * Fixed Swagger LintDiff issue.
    Added New operations for AppluUpdates, ConfigurationAssignment,
    MaintenanceConfiguration
    
    * Added Examples
    
    * Fixed Resource name.
    
    * Fixed spell check.
    
    * Removed maintenanceScopeType enum. Removed All, Resource, InResource
    MaintenanceScope.
    
    Co-authored-by: Kalpesh Chavan <kachavan@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants