Resource mover new api version 2021-01-01 #12731

ajaygit158 · 2021-01-29T16:34:18Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-pipeline-app · 2021-01-29T16:34:21Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌LintDiff: 5 Errors, 0 Warnings failed [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- resourcemover/resource-manager/readme.md tag:package-2021-01-01
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- resourcemover/resource-manager/readme.md tag:default

Rule	Message
`❌` R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'MoveCollections_Create' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.Migrate/stable/2021-01-01/resourcemovercollection.json#L17
`❌` R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'MoveCollections_Update' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.Migrate/stable/2021-01-01/resourcemovercollection.json#L76
`❌` R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'MoveCollections_Get' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.Migrate/stable/2021-01-01/resourcemovercollection.json#L182
`❌` R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'MoveResources_Create' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.Migrate/stable/2021-01-01/resourcemovercollection.json#L714
`❌` R4009 - RequiredSystemDataInNewApiVersions	The response of operation:'MoveResources_Get' is defined without 'systemData'. Consider adding the systemData to the response. New: Microsoft.Migrate/stable/2021-01-01/resourcemovercollection.json#L833

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2019-10-01-preview/resourcemovercollection.json <---> new: stable/2021-01-01/resourcemovercollection.json

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-29T16:34:21Z

Hi, @ajaygit158 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-01-29T16:34:22Z

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 4e21b58. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/resourcemover/resource-manager/readme.md

️✔️resourcemover [View full logs] [Release Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN
cmderr	[resource-manager] Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 4e21b58. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️resourcemover/mgmt/2021-01-01/resourcemover [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
```

️✔️preview/resourcemover/mgmt/2019-10-01-preview/resourcemover [View full logs] [Release SDK Changes] Breaking Change Detected

Only show 60 items here, please refer to log for details.

info	[Changelog] - New function `NetworkSecurityGroupResourceSettings.AsKeyVaultResourceSettings() (*KeyVaultResourceSettings, bool)`
info	[Changelog] - New function `UnresolvedDependencyCollectionPage.Values() []UnresolvedDependency`
info	[Changelog] - New function `DiskEncryptionSetResourceSettings.AsNetworkInterfaceResourceSettings() (*NetworkInterfaceResourceSettings, bool)`
info	[Changelog] - New function `DiskEncryptionSetResourceSettings.AsSQLDatabaseResourceSettings() (*SQLDatabaseResourceSettings, bool)`
info	[Changelog] - New function `SQLElasticPoolResourceSettings.AsKeyVaultResourceSettings() (*KeyVaultResourceSettings, bool)`
info	[Changelog] - New function `SQLDatabaseResourceSettings.AsDiskEncryptionSetResourceSettings() (*DiskEncryptionSetResourceSettings, bool)`
info	[Changelog] - New function `NewUnresolvedDependencyCollectionIterator(UnresolvedDependencyCollectionPage) UnresolvedDependencyCollectionIterator`
info	[Changelog] - New function `PublicIPAddressResourceSettings.AsKeyVaultResourceSettings() (*KeyVaultResourceSettings, bool)`
info	[Changelog] - New function `MoveCollectionProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `DiskEncryptionSetResourceSettings.AsVirtualMachineResourceSettings() (*VirtualMachineResourceSettings, bool)`
info	[Changelog] - New function `*UnresolvedDependencyCollectionPage.NextWithContext(context.Context) error`
info	[Changelog] - New function `KeyVaultResourceSettings.AsVirtualMachineResourceSettings() (*VirtualMachineResourceSettings, bool)`
info	[Changelog] - New function `KeyVaultResourceSettings.AsLoadBalancerResourceSettings() (*LoadBalancerResourceSettings, bool)`
info	[Changelog] - New function `SQLDatabaseResourceSettings.AsKeyVaultResourceSettings() (*KeyVaultResourceSettings, bool)`
info	[Changelog] - New function `NewUnresolvedDependencyCollectionPage(UnresolvedDependencyCollection, func(context.Context, UnresolvedDependencyCollection) (UnresolvedDependencyCollection, error)) UnresolvedDependencyCollectionPage`
info	[Changelog] - New function `DiskEncryptionSetResourceSettings.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `DiskEncryptionSetResourceSettings.AsVirtualNetworkResourceSettings() (*VirtualNetworkResourceSettings, bool)`
info	[Changelog] - New function `KeyVaultResourceSettings.AsSQLDatabaseResourceSettings() (*SQLDatabaseResourceSettings, bool)`
info	[Changelog] - New function `MoveCollectionsClient.ListRequiredForPreparer(context.Context, string, string, string) (*http.Request, error)`
info	[Changelog] - New function `MoveResourceCollection.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `ResourceGroupResourceSettings.AsDiskEncryptionSetResourceSettings() (*DiskEncryptionSetResourceSettings, bool)`
info	[Changelog] - New function `*UnresolvedDependencyCollectionPage.Next() error`
info	[Changelog] - New function `KeyVaultResourceSettings.AsNetworkInterfaceResourceSettings() (*NetworkInterfaceResourceSettings, bool)`
info	[Changelog] - New function `NetworkInterfaceResourceSettings.AsDiskEncryptionSetResourceSettings() (*DiskEncryptionSetResourceSettings, bool)`
info	[Changelog] - New function `AvailabilitySetResourceSettings.AsKeyVaultResourceSettings() (*KeyVaultResourceSettings, bool)`
info	[Changelog] - New function `*UnresolvedDependencyCollectionIterator.NextWithContext(context.Context) error`
info	[Changelog] - New function `UnresolvedDependencyCollection.IsEmpty() bool`
info	[Changelog] - New function `*UnresolvedDependencyCollectionIterator.Next() error`
info	[Changelog] - New function `DiskEncryptionSetResourceSettings.AsBasicResourceSettings() (BasicResourceSettings, bool)`
info	[Changelog] - New function `UnresolvedDependencyCollectionIterator.Response() UnresolvedDependencyCollection`
info	[Changelog] - New function `AvailabilitySetResourceSettings.AsDiskEncryptionSetResourceSettings() (*DiskEncryptionSetResourceSettings, bool)`
info	[Changelog] - New function `DiskEncryptionSetResourceSettings.AsPublicIPAddressResourceSettings() (*PublicIPAddressResourceSettings, bool)`
info	[Changelog] - New function `DiskEncryptionSetResourceSettings.AsSQLElasticPoolResourceSettings() (*SQLElasticPoolResourceSettings, bool)`
info	[Changelog] - New function `NetworkInterfaceResourceSettings.AsKeyVaultResourceSettings() (*KeyVaultResourceSettings, bool)`
info	[Changelog] - New struct `DiskEncryptionSetResourceSettings`
info	[Changelog] - New struct `KeyVaultResourceSettings`
info	[Changelog] - New struct `MoveCollectionPropertiesErrors`
info	[Changelog] - New struct `NsgReference`
info	[Changelog] - New struct `PublicIPReference`
info	[Changelog] - New struct `RequiredForResourcesCollection`
info	[Changelog] - New struct `Summary`
info	[Changelog] - New struct `SummaryCollection`
info	[Changelog] - New struct `UnresolvedDependenciesFilter`
info	[Changelog] - New struct `UnresolvedDependenciesFilterProperties`
info	[Changelog] - New struct `UnresolvedDependencyCollectionIterator`
info	[Changelog] - New struct `UnresolvedDependencyCollectionPage`
info	[Changelog] - New field `IsResolveRequired` in struct `MoveResourceProperties`
info	[Changelog] - New field `Etag` in struct `MoveCollection`
info	[Changelog] - New field `SummaryCollection` in struct `MoveResourceCollection`
info	[Changelog] - New field `TotalCount` in struct `MoveResourceCollection`
info	[Changelog] - New field `NetworkSecurityGroup` in struct `SubnetResourceSettings`
info	[Changelog] - New field `LoadBalancerNatRules` in struct `NicIPConfigurationResourceSettings`
info	[Changelog] - New field `PublicIP` in struct `NicIPConfigurationResourceSettings`
info	[Changelog] - New field `Fqdn` in struct `PublicIPAddressResourceSettings`
info	[Changelog] - New field `SummaryCollection` in struct `UnresolvedDependencyCollection`
info	[Changelog] - New field `TotalCount` in struct `UnresolvedDependencyCollection`
info	[Changelog] - New field `Errors` in struct `MoveCollectionProperties`
info	[Changelog]
info	[Changelog] Total 10 breaking change(s), 117 additive change(s).
info	[Changelog]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 4e21b58. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/resourcemover/resource-manager/readme.md

️✔️resourcemover [View full logs] [Release SDK Changes]

resourcemover-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/resourceMoverServiceAPI.js → ./dist/resourcemover.js...
cmderr	[npmPack] created ./dist/resourcemover.js in 391ms

️❌ azure-sdk-for-python-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 4e21b58. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmdout	[automation_generate.sh] [Autorest]/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 4e21b58. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-02-04 01:46:23 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-resourcemover"
cmderr	[generate.py] 2021-02-04 01:46:23 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-02-04 01:46:23 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.11 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/resourcemover/azure-resourcemanager-resourcemover --java.namespace=com.azure.resourcemanager.resourcemover   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/resourcemover/resource-manager/readme.md
cmderr	[generate.py] 2021-02-04 01:47:12 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-02-04 01:47:12 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-02-04 01:47:12 INFO [POM][Skip] pom already has module azure-resourcemanager-resourcemover
cmderr	[generate.py] 2021-02-04 01:47:12 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-02-04 01:47:12 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-02-04 01:47:12 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-resourcemover [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-02-04 01:50:44 DEBUG Got artifact_id: azure-resourcemanager-resourcemover
cmderr	[Inst] 2021-02-04 01:50:44 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-02-04 01:50:44 DEBUG Got artifact: azure-resourcemanager-resourcemover-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-04 01:50:44 DEBUG Match jar package: azure-resourcemanager-resourcemover-1.0.0-beta.1.jar
cmderr	[Inst] 2021-02-04 01:50:44 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12731/azure-sdk-for-java/azure-resourcemanager-resourcemover/azure-resourcemanager-resourcemover-1.0.0-beta.1.jar\" -o azure-resourcemanager-resourcemover-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-resourcemover -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-resourcemover-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-29T16:37:09Z

Hi @ajaygit158, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

dukum · 2021-01-29T19:37:34Z

/azp run

azure-pipelines · 2021-01-29T19:37:39Z

Commenter does not have sufficient privileges for PR 12731 in repo Azure/azure-rest-api-specs

ajaygit158 · 2021-02-01T03:29:31Z

/azp run

azure-pipelines · 2021-02-01T03:29:45Z

Azure Pipelines successfully started running 2 pipeline(s).

openapi-workflow-bot · 2021-02-01T05:31:39Z

Hi, @ajaygit158 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @raych1

raych1 · 2021-02-03T05:29:00Z

@msyyc, can you please have a look at python SDK check failures?

ArcturusZhang · 2021-02-03T07:03:56Z

@raych1 this PR did not change anything of the package that is reporting breaking changes - therefore we could ignore the breaking changes warnings for go SDK

msyyc · 2021-02-03T10:50:13Z

For python, It is a known issue and we will fix it soon. Please ignore it now

raych1 · 2021-02-03T23:25:05Z

@akning-ms , please force merge this PR since python sdk failure is known issue, thanks.

* Added new 2021-01-01 Api version for Azure Resource Mover. * Changes for new API version. * Added new Swagger API version for resource mover. Co-authored-by: Ajay Gupta <ajgupt@microsoft.com>

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 29, 2021

This was referenced Jan 29, 2021

[AutoPR resourcemover] [Do not merge] resource mover new api version AzureSDKAutomation/azure-sdk-for-js#3462

Closed

[AutoPR resourcemover] [Do not merge] resource mover new api version AzureSDKAutomation/azure-resource-manager-schemas#1541

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 29, 2021

openapi-sdkautomation bot mentioned this pull request Jan 29, 2021

[AutoPR azure-resourcemanager-resourcemover] [Do not merge] resource mover new api version AzureSDKAutomation/azure-sdk-for-java#7352

Closed

ajaygit158 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 29, 2021

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Jan 29, 2021

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 1, 2021

ajaygit158 marked this pull request as ready for review February 1, 2021 04:34

ajaygit158 requested review from ArcturusZhang, ChenTanyi, jsntcy, msyyc and qiaozha as code owners February 1, 2021 04:34

openapi-assignment-bot bot assigned raych1 Feb 1, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 1, 2021

ajaygit158 assigned pilor Feb 1, 2021

pilor removed their assignment Feb 1, 2021

jorgecotillo self-assigned this Feb 2, 2021

jorgecotillo added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 2, 2021

ajaygit158-zz added 3 commits February 3, 2021 12:36

Added new 2021-01-01 Api version for Azure Resource Mover.

bb94d3e

Changes for new API version.

b2e9d90

Added new Swagger API version for resource mover.

c3eb267

ajaygit158 force-pushed the ajgupt/ResourceMoverNewApiVersion branch from 876cfcf to c3eb267 Compare February 3, 2021 07:15

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Feb 3, 2021

ajaygit158 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Feb 3, 2021

ajaygit158 changed the title ~~[Do not merge] resource mover new api version~~ Resource mover new api version 2021-01-01 Feb 3, 2021

raych1 added the Approved-LintDiff label Feb 3, 2021

akning-ms merged commit 4e21b58 into Azure:master Feb 4, 2021

ajaygit158 mentioned this pull request Feb 4, 2021

Changes to refer new API version of Resource Mover Service Azure/azure-sdk-for-net#18432

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resource mover new api version 2021-01-01 #12731

Resource mover new api version 2021-01-01 #12731

ajaygit158 commented Jan 29, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 29, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 29, 2021

openapi-pipeline-app bot commented Jan 29, 2021 •

edited

Loading

openapi-workflow-bot bot commented Jan 29, 2021

dukum commented Jan 29, 2021

azure-pipelines bot commented Jan 29, 2021

ajaygit158 commented Feb 1, 2021

azure-pipelines bot commented Feb 1, 2021

openapi-workflow-bot bot commented Feb 1, 2021

raych1 commented Feb 3, 2021

ArcturusZhang commented Feb 3, 2021

msyyc commented Feb 3, 2021 •

edited

Loading

raych1 commented Feb 3, 2021

Resource mover new api version 2021-01-01 #12731

Resource mover new api version 2021-01-01 #12731

Conversation

ajaygit158 commented Jan 29, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Jan 29, 2021 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Jan 29, 2021

openapi-pipeline-app bot commented Jan 29, 2021 • edited Loading

Swagger Generation Artifacts

openapi-workflow-bot bot commented Jan 29, 2021

dukum commented Jan 29, 2021

azure-pipelines bot commented Jan 29, 2021

ajaygit158 commented Feb 1, 2021

azure-pipelines bot commented Feb 1, 2021

openapi-workflow-bot bot commented Feb 1, 2021

raych1 commented Feb 3, 2021

ArcturusZhang commented Feb 3, 2021

msyyc commented Feb 3, 2021 • edited Loading

raych1 commented Feb 3, 2021

ajaygit158 commented Jan 29, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 29, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 29, 2021 •

edited

Loading

msyyc commented Feb 3, 2021 •

edited

Loading