Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[communication] Add MicrosoftTeamsUser identifier kind and make id optional #12435

Merged
merged 3 commits into from
Jan 16, 2021
Merged

[communication] Add MicrosoftTeamsUser identifier kind and make id optional #12435

merged 3 commits into from
Jan 16, 2021

Conversation

DominikMe
Copy link
Member

also fixes two missing types

@openapi-workflow-bot
Copy link

Hi, @DominikMe Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 14, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 5 Errors, 0 Warnings failed [Detail]

    Rule Message
    ❌ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json#L10:5
    Old: Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json#L10:5
    ❌ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json#L17:9
    Old: Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json#L16:9
    ❌ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json#L46:11
    Old: Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json#L44:11
    ❌ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json#L52:9
    Old: Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json#L50:9
    ❌ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json#L23:5
    Old: Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json#L22:5
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 14, 2021 •
    edited
    Loading

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-workflow-bot
    Copy link

    Hi @DominikMe, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @RezaJooyandeh
    Copy link
    Member

    👋🏻 @tjprescott, this is still a preview swagger. Do you know why the pipeline is asking us to fill the breaking change template?

    @tjprescott
    Copy link
    Member

    Please elaborate on the breaking change. Is this a change, or fixing a "bug" in the Swagger?

    @DominikMe
    Copy link
    Member Author

    Please elaborate on the breaking change. Is this a change, or fixing a "bug" in the Swagger?

    @tjprescott The breaking change that was discovered by CI is the addition of "type": "object" to the model definitions. I had forgot to add them, and autorest had automatically inferred type: object with a Warning.

    This common swagger hasn't been used in any service yet and we are adjusting it now while integrating it with the new versions for our various communication services.

    @tjprescott
    Copy link
    Member

    Thanks @DominikMe. @lmazuel can you merge this PR?

    @lmazuel lmazuel merged commit aef2821 into Azure:master Jan 16, 2021
    @DominikMe DominikMe deleted the communication-common-addTeamsIdentifier branch January 18, 2021 20:27
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    @DominikMe @mkarmark
    [communication] Add MicrosoftTeamsUser identifier kind and make id op…
    28bb376 
    …tional (Azure#12435)

* [communication] Add MicrosoftTeamsUser identifier kind and make id optional

* add type:object where missing

* Add isAnonymous property
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @amrElroumy amrElroumy amrElroumy approved these changes

    @lmazuel lmazuel lmazuel approved these changes

    @tjprescott tjprescott tjprescott approved these changes

    @RezaJooyandeh RezaJooyandeh RezaJooyandeh approved these changes

    @juancamilor juancamilor Awaiting requested review from juancamilor

    Assignees

    @tjprescott tjprescott

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @DominikMe @RezaJooyandeh @tjprescott @amrElroumy @lmazuel