Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2019-06-01-preview/FailoverManagedInstance.json #11880

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Fix 2019-06-01-preview/FailoverManagedInstance.json #11880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix 2019-06-01-preview/FailoverManagedInstance.json
  • Loading branch information
@ericshape
ericshape committed Dec 2, 2020
commit cd6b8e22f4cc45c247eacb631c012f75cd4b47e8
73 changes: 26 additions & 47 deletions ...ql/resource-manager/Microsoft.Sql/preview/2019-06-01-preview/FailoverManagedInstance.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,6 @@
"produces": [
"application/json"
],
"security": [
{
"azure_auth": [
"user_impersonation"
]
}
],
"securityDefinitions": {
"azure_auth": {
"type": "oauth2",
"authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize",
"flow": "implicit",
"description": "Azure Active Directory OAuth2 Flow",
"scopes": {
"user_impersonation": "impersonate your user account"
}
}
},
"paths": {
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/managedInstances/{managedInstanceName}/failover": {
"post": {
Expand All @@ -43,16 +25,14 @@
"operationId": "ManagedInstances_Failover",
"parameters": [
{
"$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ResourceGroupNameParameter"
"$ref": "../../../common/v1/types.json#/parameters/ResourceGroupParameter"
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/ManagedInstanceNameParameter"
"name": "managedInstanceName",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MilanBrkicFON
this is due to your doc override the name parameters in: https://msdata.visualstudio.com/Database%20Systems/_git/DsMainDev?path=%2FSql%2Fxdb%2Fmanifest%2Fsvc%2Fmgmt%2FWebApiHosting%2FARM%2FV20190601%2FManagedInstance%2FControllers%2FFailoverManagedInstance.cs&version=GBmaster&line=66&lineEnd=68&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents

if removing the doc override, it will generate "ManagedInstanceNameParameter". Thus, this is not a true breaking change.

"in": "path",
"description": "The name of the managed instance to failover.",
"required": true,
"type": "string"
},
{
"name": "replicaType",
Expand All @@ -68,17 +48,23 @@
"name": "ReplicaType",
"modelAsString": true
}
},
{
"$ref": "../../../common/v1/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "../../../common/v1/types.json#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "Successfully completed managed instance failover."
},
"default": {
"description": "*** Error Responses: ***\n\n * 400 ManagedInstanceFailoverThrottled - There was a recent failover on the managed instance.\n\n * 400 ManagedInstanceFailoverNotSupportedOnSKU - This type of customer initiated failover is not supported on the given SKU.\n\n * 403 ManagedInstanceFailoverFullBackupMissing - Automated backup needs to complete the first full backup for a new database.\n\n * 404 SubscriptionDoesNotHaveServer - The requested server was not found\n\n * 404 ServerNotInSubscriptionResourceGroup - Specified server does not exist in the specified resource group and subscription.\n\n * 409 ManagedInstanceNotInStateToFailover - The managed instance is currently in a state such that failover cannot be issued."
},
"202": {
"description": "Managed instance failover is in progress."
},
"default": {
"description": "*** Error Responses: ***\n\n * 400 ManagementServiceFeatureDisabled - User attempted to use a feature which is disabled.\n\n * 400 ManagedInstanceFailoverThrottled - There was a recent failover on the managed instance.\n\n * 400 ManagedInstanceFailoverNotSupportedOnSKU - This type of customer initiated failover is not supported on the given SKU.\n\n * 404 SubscriptionDoesNotHaveServer - The requested server was not found\n\n * 404 ServerNotInSubscriptionResourceGroup - Specified server does not exist in the specified resource group and subscription.\n\n * 409 ManagedInstanceNotInStateToFailover - The managed instance is currently in a state such that failover cannot be issued."
}
},
"x-ms-long-running-operation": true,
Expand All @@ -91,23 +77,16 @@
}
},
"definitions": {},
"parameters": {
"SubscriptionIdParameter": {
"name": "subscriptionId",
"in": "path",
"description": "The subscription ID that identifies an Azure subscription.",
"required": true,
"type": "string",
"x-ms-parameter-location": "client"
},
"ManagedInstanceNameParameter": {
"name": "managedInstanceName",
"in": "path",
"description": "The name of the managed instance.",
"required": true,
"type": "string",
"x-ms-parameter-location": "method"
"parameters": {},
"securityDefinitions": {
"azure_auth": {
"type": "oauth2",
"description": "Azure Active Directory OAuth2 Flow",
"flow": "implicit",
"authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize",
"scopes": {
"user_impersonation": "impersonate your user account"
}
}
},
"responses": {}
}
}
5 changes: 2 additions & 3 deletions specification/sql/resource-manager/readme.azureresourceschema.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,8 @@ output-folder: $(azureresourceschema-folder)/schemas

# all the input files in this apiVersion
input-file:
- ./Microsoft.Sql/preview/2020-08-01-preview/databases.json
- ./Microsoft.Sql/preview/2020-08-01-preview/elasticPools.json

- ./Microsoft.Sql/preview/2020-08-01-preview/Databases.json
- ./Microsoft.Sql/preview/2020-08-01-preview/ElasticPools.json
```

### Tag: schema-sql-2020-02-02-preview and azureresourceschema
Expand Down