Add Private link and Private link association APIs #11364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Staging] Swagger Validation Report
️✔️ |
| Rule | Message |
|---|---|
|
pathTemplate: /subscriptions/{subscriptionId}/resourceGroups/{sourceResourceGroupName}/providers/Microsoft.Authorization/resourceManagementPrivateLinks/{resourceManagementPrivateLinksName} contains the path parameter sourceResourceGroupName however, it is not present in [object Object] - { "subscriptionId": "{subscriptionId}", "resourceGroupName": "{resourceGroupName}", "resourceManagementPrivateLinksName": "myPrivateLink" }.The value of the path parameter can either be a "string" of the form { sourceResourceGroupName: "some sample value" } or it can be an "object" of the form { "sourceResourceGroupName": { value: "some sample value", skipUrlEncoding: true } }. Url: stable/2020-05-01/examples/createPrivateLink.json#L1 |
|
Response statusCode "200" for operation "ResourceManagementPrivateLinks_Put" is provided in exampleResponseValue, however it is not present in the swagger spec. |
|
pathTemplate: /subscriptions/{subscriptionId}/resourceGroups/{sourceResourceGroupName}/providers/Microsoft.Authorization/resourceManagementPrivateLinks/{resourceManagementPrivateLinksName} contains the path parameter sourceResourceGroupName however, it is not present in [object Object] - { "subscriptionId": "{subscriptionId}", "resourceGroupName": "{resourceGroupName}", "resourceManagementPrivateLinksName": "myPrivateLink" }.The value of the path parameter can either be a "string" of the form { sourceResourceGroupName: "some sample value" } or it can be an "object" of the form { "sourceResourceGroupName": { value: "some sample value", skipUrlEncoding: true } }. Url: stable/2020-05-01/examples/deletePrivateLink.json#L1 |
|
Response statusCode "200" for operation "ResourceManagementPrivateLinks_Delete" is provided in exampleResponseValue, however it is not present in the swagger spec. |
|
pathTemplate: /subscriptions/{subscriptionId}/resourceGroups/{sourceResourceGroupName}/providers/Microsoft.Authorization/resourceManagementPrivateLinks/{resourceManagementPrivateLinksName} contains the path parameter sourceResourceGroupName however, it is not present in [object Object] - { "subscriptionId": "{subscriptionId}", "resourceGroupName": "{resourceGroupName}", "resourceManagementPrivateLinksName": "myPrivateLink" }.The value of the path parameter can either be a "string" of the form { sourceResourceGroupName: "some sample value" } or it can be an "object" of the form { "sourceResourceGroupName": { value: "some sample value", skipUrlEncoding: true } }. Url: stable/2020-05-01/examples/getPrivateLink.json#L1 |
|
Response statusCode "200" for operation "ResourceManagementPrivateLinks_Get" is provided in exampleResponseValue, however it is not present in the swagger spec. |
|
Response statusCode "200" for operation "PrivateLinkAssociations_Get" is provided in exampleResponseValue, however it is not present in the swagger spec. |
️❌SemanticValidation: 10 Errors, 0 Warnings [Detail] [Expand]
❌
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go
|
azure-sdk-for-java
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
azure-sdk-for-net
|
azure-sdk-for-python-track2
|
azure-resource-manager-schemas
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Oct 23, 2020
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @Vishakha-Git your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @raych1 |
This was referenced Oct 23, 2020
This was referenced Oct 24, 2020
raych1
added
the
Reviewed-ChangesRequested
|
@Vishakha-Git , please fix the CI check failures. |
|
Please go through the contribution checklist added as part of the review and mark them completed. Also Please go through the ARM API Review Checklist. These steps are required before review can be continued. |
|
@Vishakha-Git , are you still working on this PR? It's been two weeks without response since last feedback. |
@Vishakha-Git , can you go through the contribution checklist in first comment of this PR and check on the items. Otherwise, ARM review will not be started. Also, please fix the CI check failures. |
|
Hi, @Vishakha-Git. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
|
I close this PR as no response. Feel free to re-open if necessary, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource Manger Private Link:- PUT,DELETE, GET
Private link association GET
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.