Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new contract to support github action based devops starter #11325

Closed
wants to merge 6 commits into from
Closed

Create new contract to support github action based devops starter #11325

wants to merge 6 commits into from

Conversation

suyash691
Copy link
Contributor

@suyash691 suyash691 commented Oct 22, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 22, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi, @suyash691 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-workflow-bot
    Copy link

    Hi, @suyash691 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @lirenhe

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 22, 2020
    @suyash691
    Copy link
    Contributor Author

    @PhoenixHe-msft @lirenhe I've already created a PR with these changes in the private branch and gotten them approved by the ARM team
    https://github.com/Azure/azure-rest-api-specs-pr/pull/1648
    Will a re-review still be needed

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 22, 2020

    Azure CLI Extension Generation

    • Installation instruction for service devops [Preview Changes]
      curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/azure-rest-api-specs/11325/azure-cli-extensions/devops/devops-0.1.0-py3-none-any.whl" -o devops-0.1.0-py3-none-any.whl
      az extension add --source=devops-0.1.0-py3-none-any.whl
      
    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 54d96fc with merge commit 99b7e1ed94a3eb25058d552fa269732cc8f206e1. Azure CLI Automation 13.0.17.20200918.2
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationDisplayValue' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PipelineListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      [AutoRest] WARNING (): Operation Update has already existed in group! Skip split!
      [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      [AutoRest] 
      [AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
      [AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
      [AutoRest] --------------------------------------------------------
      [AutoRest]   test-scenario:
      [AutoRest]     - name: /Pipelines/put/Create an Azure pipeline to deploy a sample ASP.Net application to Azure web-app
      [AutoRest]     - name: /Pipelines/get/Get an existing Azure pipeline
      [AutoRest]     - name: /Pipelines/get/List all Azure Pipelines under the specified resource group
      [AutoRest]     - name: /Pipelines/get/List all Azure pipelines under the specified subscription
      [AutoRest]     - name: /Pipelines/patch/Get an existing Azure pipeline
      [AutoRest]     - name: /Pipelines/delete/Get an existing Azure pipeline
      [AutoRest]     - name: /PipelineTemplateDefinitions/get/Get the list of pipeline template definitions
      [AutoRest] --------------------------------------------------------

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 22, 2020

    azure-sdk-for-java

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 54d96fc with merge commit 99b7e1ed94a3eb25058d552fa269732cc8f206e1. SDK Automation 13.0.17.20200918.2
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 22, 2020

    azure-sdk-for-js

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 54d96fc with merge commit 99b7e1ed94a3eb25058d552fa269732cc8f206e1. SDK Automation 13.0.17.20200918.2
    • ️✔️@azure/arm-devops [View full logs]  [Preview SDK Changes]
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/devOpsClient.js → ./dist/arm-devops.js...
      [npmPack] created ./dist/arm-devops.js in 249ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-devops@1.0.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 42.3kB dist/arm-devops.js                                    
      [npmPack] npm notice 13.9kB dist/arm-devops.min.js                                
      [npmPack] npm notice 1.5kB  esm/devOpsClient.js                                   
      [npmPack] npm notice 2.5kB  esm/devOpsClientContext.js                            
      [npmPack] npm notice 263B   esm/models/index.js                                   
      [npmPack] npm notice 372B   esm/operations/index.js                               
      [npmPack] npm notice 14.2kB esm/models/mappers.js                                 
      [npmPack] npm notice 2.2kB  esm/operations/operations.js                          
      [npmPack] npm notice 355B   esm/models/operationsMappers.js                       
      [npmPack] npm notice 1.5kB  esm/models/parameters.js                              
      [npmPack] npm notice 9.6kB  esm/operations/pipelines.js                           
      [npmPack] npm notice 521B   esm/models/pipelinesMappers.js                        
      [npmPack] npm notice 2.4kB  esm/operations/pipelineTemplateDefinitions.js         
      [npmPack] npm notice 435B   esm/models/pipelineTemplateDefinitionsMappers.js      
      [npmPack] npm notice 888B   rollup.config.js                                      
      [npmPack] npm notice 1.6kB  package.json                                          
      [npmPack] npm notice 457B   tsconfig.json                                         
      [npmPack] npm notice 91.1kB dist/arm-devops.js.map                                
      [npmPack] npm notice 13.6kB dist/arm-devops.min.js.map                            
      [npmPack] npm notice 666B   esm/devOpsClient.d.ts.map                             
      [npmPack] npm notice 791B   esm/devOpsClient.js.map                               
      [npmPack] npm notice 491B   esm/devOpsClientContext.d.ts.map                      
      [npmPack] npm notice 1.4kB  esm/devOpsClientContext.js.map                        
      [npmPack] npm notice 5.6kB  esm/models/index.d.ts.map                             
      [npmPack] npm notice 181B   esm/operations/index.d.ts.map                         
      [npmPack] npm notice 126B   esm/models/index.js.map                               
      [npmPack] npm notice 195B   esm/operations/index.js.map                           
      [npmPack] npm notice 991B   esm/models/mappers.d.ts.map                           
      [npmPack] npm notice 8.2kB  esm/models/mappers.js.map                             
      [npmPack] npm notice 1.0kB  esm/operations/operations.d.ts.map                    
      [npmPack] npm notice 1.4kB  esm/operations/operations.js.map                      
      [npmPack] npm notice 202B   esm/models/operationsMappers.d.ts.map                 
      [npmPack] npm notice 215B   esm/models/operationsMappers.js.map                   
      [npmPack] npm notice 445B   esm/models/parameters.d.ts.map                        
      [npmPack] npm notice 1.2kB  esm/models/parameters.js.map                          
      [npmPack] npm notice 3.5kB  esm/operations/pipelines.d.ts.map                     
      [npmPack] npm notice 5.5kB  esm/operations/pipelines.js.map                       
      [npmPack] npm notice 305B   esm/models/pipelinesMappers.d.ts.map                  
      [npmPack] npm notice 318B   esm/models/pipelinesMappers.js.map                    
      [npmPack] npm notice 1.1kB  esm/operations/pipelineTemplateDefinitions.d.ts.map   
      [npmPack] npm notice 1.5kB  esm/operations/pipelineTemplateDefinitions.js.map     
      [npmPack] npm notice 259B   esm/models/pipelineTemplateDefinitionsMappers.d.ts.map
      [npmPack] npm notice 272B   esm/models/pipelineTemplateDefinitionsMappers.js.map  
      [npmPack] npm notice 3.1kB  README.md                                             
      [npmPack] npm notice 1.1kB  esm/devOpsClient.d.ts                                 
      [npmPack] npm notice 1.6kB  src/devOpsClient.ts                                   
      [npmPack] npm notice 860B   esm/devOpsClientContext.d.ts                          
      [npmPack] npm notice 2.3kB  src/devOpsClientContext.ts                            
      [npmPack] npm notice 14.3kB esm/models/index.d.ts                                 
      [npmPack] npm notice 141B   esm/operations/index.d.ts                             
      [npmPack] npm notice 13.7kB src/models/index.ts                                   
      [npmPack] npm notice 340B   src/operations/index.ts                               
      [npmPack] npm notice 1.2kB  esm/models/mappers.d.ts                               
      [npmPack] npm notice 11.3kB src/models/mappers.ts                                 
      [npmPack] npm notice 2.1kB  esm/operations/operations.d.ts                        
      [npmPack] npm notice 4.1kB  src/operations/operations.ts                          
      [npmPack] npm notice 127B   esm/models/operationsMappers.d.ts                     
      [npmPack] npm notice 317B   src/models/operationsMappers.ts                       
      [npmPack] npm notice 481B   esm/models/parameters.d.ts                            
      [npmPack] npm notice 1.6kB  src/models/parameters.ts                              
      [npmPack] npm notice 9.2kB  esm/operations/pipelines.d.ts                         
      [npmPack] npm notice 17.6kB src/operations/pipelines.ts                           
      [npmPack] npm notice 293B   esm/models/pipelinesMappers.d.ts                      
      [npmPack] npm notice 502B   src/models/pipelinesMappers.ts                        
      [npmPack] npm notice 2.3kB  esm/operations/pipelineTemplateDefinitions.d.ts       
      [npmPack] npm notice 4.5kB  src/operations/pipelineTemplateDefinitions.ts         
      [npmPack] npm notice 207B   esm/models/pipelineTemplateDefinitionsMappers.d.ts    
      [npmPack] npm notice 384B   src/models/pipelineTemplateDefinitionsMappers.ts      
      [npmPack] npm notice 1.1kB  LICENSE.txt                                           
      [npmPack] npm notice === Tarball Details === 
      [npmPack] npm notice name:          @azure/arm-devops                       
      [npmPack] npm notice version:       1.0.0                                   
      [npmPack] npm notice filename:      azure-arm-devops-1.0.0.tgz              
      [npmPack] npm notice package size:  42.3 kB                                 
      [npmPack] npm notice unpacked size: 330.1 kB                                
      [npmPack] npm notice shasum:        026123f2127be43d54326f2cf9cc642475835a25
      [npmPack] npm notice integrity:     sha512-42UIziWymw/eQ[...]XPwRRxbyxLknA==
      [npmPack] npm notice total files:   69                                      
      [npmPack] npm notice 

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 22, 2020

    azure-sdk-for-go

    ⚠️ warning [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 22, 2020

    azure-sdk-for-python

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 54d96fc with merge commit 99b7e1ed94a3eb25058d552fa269732cc8f206e1. SDK Automation 13.0.17.20200918.2
      [azure-mgmt-devops][ChangeLog] WARNING: Failed to generate ChangeLog.
    • ⚠️azure-mgmt-devops [View full logs]  [Preview SDK Changes]
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-devops
      [build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-devops
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-devops
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:406: UserWarning: The version specified ('2020-07-13-preview') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
      [build_package]   "details." % self.metadata.version
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /z/venv/lib/python3.6/site-packages/setuptools/dist.py:406: UserWarning: The version specified ('2020-07-13-preview') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
      [build_package]   "details." % self.metadata.version
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      Not exact 2 reports found:
      code_reports/latest/report.json
      Not generating changelog.
      [ChangeLog] WARNING: Failed to generate ChangeLog.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 22, 2020

    azure-sdk-for-python-track2

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 22, 2020

    azure-resource-manager-schemas

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 54d96fc with merge commit 99b7e1ed94a3eb25058d552fa269732cc8f206e1. Schema Automation 13.0.17.20200918.2
      [devops][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
      [devops][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
      [devops][after_scripts|node] configure: WARNING: secure clearing/zeroing of memory is not supported by the selected crypto backend
    • ️✔️devops [View full logs]  [Preview Schema Changes]
        [after_scripts|node] PostProcessor finished successfully.
        [after_scripts|node]   5794 passing (1m)
        AzureResourceSchema has no registered package commands.

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 22, 2020

      Trenton Generation

      ⚠️ warning [Logs] [Expand Details]
      • ⚠️ Generate from 54d96fc with merge commit 99b7e1ed94a3eb25058d552fa269732cc8f206e1. Trenton Automation 13.0.17.20200918.2
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CloudErrorBody' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationDisplayValue' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PipelineListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
        [AutoRest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
        [AutoRest] WARNING (): 'cli.flatten.cli-flatten-set-enabled' is not set to true, skip flattenSetter
        [AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
        [AutoRest] WARNING: cannot find gosdk folder in readme.trenton.md:
        Failed to find any changed packages. Please check the changed file list.
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/client.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/devopsapi/interfaces.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/enums.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/models.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/operations.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/pipelines.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/pipelinetemplatedefinitions.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2019-07-01-preview/devops/version.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/client.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/devopsapi/interfaces.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/enums.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/models.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/operations.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/pipelines.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/pipelinetemplatedefinitions.go
        /z/work/azure-sdk-for-trenton/vendor/github.com/Azure/azure-sdk-for-go/services/services/preview/devops/mgmt/2020-07-13-preview/devops/version.go

      @openapi-sdkautomation
      Copy link

      openapi-sdkautomation bot commented Oct 22, 2020

      azure-sdk-for-net

      ️✔️ succeeded [Logs] [Expand Details]
      • ️✔️ Generate from 54d96fc with merge commit 99b7e1ed94a3eb25058d552fa269732cc8f206e1. SDK Automation 13.0.17.20200918.2
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
        [AutoRest] realpath(): Permission denied
      • ️✔️Microsoft.Azure.Management.DevOps [View full logs]  [Preview SDK Changes]
          No Artifact Generated.

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @PhoenixHe-NV
        Copy link
        Contributor

        @suyash691 Please fix readme.go.md
        output-folder generated of tag package-2020-07-13-preview must be under a preview subdirectory for a preview swagger set. Please refer the sample for readme.go.md file here https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/samplefiles/readme.go.md for more information

        @lirenhe lirenhe added Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 26, 2020
        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @suyash691
        Copy link
        Contributor Author

        @PhoenixHe-msft I fixed the issue with Go Compilation

        @lirenhe lirenhe added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Oct 29, 2020
        @chiragg4u
        Copy link
        Contributor

        While adding new version the recommendation is to copy the existing version into new directory structure for first commit and then push new changes for easy review. Please create new branch with this recommendation for faster review.

        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Labels
        Reviewed-FeedbackProvided WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
        Projects
        None yet
        Development

        Successfully merging this pull request may close these issues.

        4 participants