-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DoNotMerge]Adding Extended Location Property to Microsoft.Compute Resources - CI Checks #11247
[DoNotMerge]Adding Extended Location Property to Microsoft.Compute Resources - CI Checks #11247
Conversation
[Staging] Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
❌ |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR is just for CI checks as it was failing for the same changes to Compute-2020-12 branch |
azure-sdk-for-go
|
azure-sdk-for-js
|
azure-resource-manager-schemas
|
azure-sdk-for-python-track2
- Breaking Change detected in SDK
|
azure-sdk-for-net
|
azure-sdk-for-java
|
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
hi @changlong-liu could you pls help to look at the Python Track2 breaking change? Thanks. |
hi @pavanrachapudy adding property to response of stable API version is breaking change per http://aka.ms/bcforapi, pls do it in new API version, and go through breaking change review process. |
Hi @yungezz , Python T2 breaking changes come from previous PR. I think this PR is fine. |
Hi @yungezz . I have a PR to have these changes to go to the new API version branch. I created this PR to master to just check if CI checks are working fine or not. I have couple of jobs failing in the azure pipelines over there. So just wanted to check here. No action is needed on this PR. Sorry for the confusion. I will close this PR. |
…e resources
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.