Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apimanagement - 2020-06-01-preview version release #11196

Merged
merged 18 commits into from
Oct 20, 2020

Conversation

solankisamir
Copy link
Member

@solankisamir solankisamir commented Oct 14, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Merging the branch to master, as all the changes are in. Please refer to individual sign-off here

https://github.com/Azure/azure-rest-api-specs/pulls?q=is%3Apr+label%3A2020-06-01-preview+is%3Aclosed

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

solankisamir and others added 16 commits July 27, 2020 13:07
* add support for PATCH returning 200 OK

* CI fixes

prettier fix

CI fixes part 2

* Password no longer a mandatory property when uploading Certificates

* add missing x-ms-odata extension for filter support
* Oauth server secrets contract

* fix azureMonitor enum
* API Management Service Deleted Services Resource

* Path fix

* Lint + custom-words fixes

* Location URI parameter for deletedservices Resource

* GET for deletedservices by service name

* Remove resourceGroupName from resource path

* fixes

* schema for purge operation

* perttier applied

* 204 response code added

Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
* OperationNameFormat property added to Diagnostic contract

* add azuremonitor to update contract

Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
…esponse contract (#10331)

* Change Network Status response contract

* Update examples for network status contract
* update namedvalue contract for keyvault

* add examples

* separate out create contract

* common create contract

* fix examples
* Data Masking settings for Diagnostic

* Move dataMasking under HttpMessageDiagnostic

Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 14, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 14, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 96b001d with merge commit cc483e7. SDK Automation 13.0.17.20200918.2
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityStateByOperation' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityStateByApi' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityStateByProduct' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityState' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'checkEntityExists' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
    [AutoRest] WARNING: HEAD 'getEntityTag' method missing 404 status code section -- this might be unintentional.
  • ️✔️@azure/arm-apimanagement [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
    [npmPack] created ./dist/arm-apimanagement.js in 1.6s
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-apimanagement@6.0.0
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 12.4kB  esm/operations/api.js                                  
    [npmPack] npm notice 9.8kB   esm/operations/apiDiagnostic.js                        
    [npmPack] npm notice 2.8kB   esm/models/apiDiagnosticMappers.js                     
    [npmPack] npm notice 2.0kB   esm/operations/apiExport.js                            
    [npmPack] npm notice 466B    esm/models/apiExportMappers.js                         
    [npmPack] npm notice 9.6kB   esm/operations/apiIssue.js                             
    [npmPack] npm notice 8.8kB   esm/operations/apiIssueAttachment.js                   
    [npmPack] npm notice 2.8kB   esm/models/apiIssueAttachmentMappers.js                
    [npmPack] npm notice 8.7kB   esm/operations/apiIssueComment.js                      
    [npmPack] npm notice 2.8kB   esm/models/apiIssueCommentMappers.js                   
    [npmPack] npm notice 2.8kB   esm/models/apiIssueMappers.js                          
    [npmPack] npm notice 6.0kB   esm/apiManagementClient.js                             
    [npmPack] npm notice 2.6kB   esm/apiManagementClientContext.js                      
    [npmPack] npm notice 2.4kB   esm/operations/apiManagementOperations.js              
    [npmPack] npm notice 468B    esm/models/apiManagementOperationsMappers.js           
    [npmPack] npm notice 21.7kB  esm/operations/apiManagementService.js                 
    [npmPack] npm notice 2.9kB   esm/models/apiManagementServiceMappers.js              
    [npmPack] npm notice 2.8kB   esm/operations/apiManagementServiceSkus.js             
    [npmPack] npm notice 515B    esm/models/apiManagementServiceSkusMappers.js          
    [npmPack] npm notice 3.1kB   esm/models/apiMappers.js                               
    [npmPack] npm notice 9.8kB   esm/operations/apiOperation.js                         
    [npmPack] npm notice 2.8kB   esm/models/apiOperationMappers.js                      
    [npmPack] npm notice 7.9kB   esm/operations/apiOperationPolicy.js                   
    [npmPack] npm notice 2.8kB   esm/models/apiOperationPolicyMappers.js                
    [npmPack] npm notice 7.1kB   esm/operations/apiPolicy.js                            
    [npmPack] npm notice 2.8kB   esm/models/apiPolicyMappers.js                         
    [npmPack] npm notice 2.8kB   esm/operations/apiProduct.js                           
    [npmPack] npm notice 2.7kB   esm/models/apiProductMappers.js                        
    [npmPack] npm notice 9.7kB   esm/operations/apiRelease.js                           
    [npmPack] npm notice 2.8kB   esm/models/apiReleaseMappers.js                        
    [npmPack] npm notice 2.8kB   esm/operations/apiRevision.js                          
    [npmPack] npm notice 473B    esm/models/apiRevisionMappers.js                       
    [npmPack] npm notice 9.9kB   esm/operations/apiSchema.js                            
    [npmPack] npm notice 2.8kB   esm/models/apiSchemaMappers.js                         
    [npmPack] npm notice 8.5kB   esm/operations/apiTagDescription.js                    
    [npmPack] npm notice 2.8kB   esm/models/apiTagDescriptionMappers.js                 
    [npmPack] npm notice 9.4kB   esm/operations/apiVersionSet.js                        
    [npmPack] npm notice 2.8kB   esm/models/apiVersionSetMappers.js                     
    [npmPack] npm notice 1.3MB   dist/arm-apimanagement.js                              
    [npmPack] npm notice 486.5kB dist/arm-apimanagement.min.js                          
    [npmPack] npm notice 10.8kB  esm/operations/authorizationServer.js                  
    [npmPack] npm notice 2.9kB   esm/models/authorizationServerMappers.js               
    [npmPack] npm notice 10.3kB  esm/operations/backend.js                              
    [npmPack] npm notice 2.8kB   esm/models/backendMappers.js                           
    [npmPack] npm notice 9.0kB   esm/operations/cache.js                                
    [npmPack] npm notice 2.8kB   esm/models/cacheMappers.js                             
    [npmPack] npm notice 7.9kB   esm/operations/certificate.js                          
    [npmPack] npm notice 2.8kB   esm/models/certificateMappers.js                       
    [npmPack] npm notice 6.4kB   esm/operations/contentType.js                          
    [npmPack] npm notice 8.4kB   esm/operations/contentTypeContentItem.js               
    [npmPack] npm notice 2.8kB   esm/models/contentTypeContentItemMappers.js            
    [npmPack] npm notice 2.7kB   esm/models/contentTypeMappers.js                       
    [npmPack] npm notice 6.8kB   esm/operations/delegationSettings.js                   
    [npmPack] npm notice 2.8kB   esm/models/delegationSettingsMappers.js                
    [npmPack] npm notice 4.4kB   esm/operations/deletedServices.js                      
    [npmPack] npm notice 2.7kB   esm/models/deletedServicesMappers.js                   
    [npmPack] npm notice 9.3kB   esm/operations/diagnostic.js                           
    [npmPack] npm notice 2.8kB   esm/models/diagnosticMappers.js                        
    [npmPack] npm notice 9.2kB   esm/operations/emailTemplate.js                        
    [npmPack] npm notice 2.8kB   esm/models/emailTemplateMappers.js                     
    [npmPack] npm notice 12.9kB  esm/operations/gateway.js                              
    [npmPack] npm notice 6.5kB   esm/operations/gatewayApi.js                           
    [npmPack] npm notice 2.7kB   esm/models/gatewayApiMappers.js                        
    [npmPack] npm notice 8.7kB   esm/operations/gatewayHostnameConfiguration.js         
    [npmPack] npm notice 2.8kB   esm/models/gatewayHostnameConfigurationMappers.js      
    [npmPack] npm notice 2.9kB   esm/models/gatewayMappers.js                           
    [npmPack] npm notice 9.0kB   esm/operations/group.js                                
    [npmPack] npm notice 2.8kB   esm/models/groupMappers.js                             
    [npmPack] npm notice 6.1kB   esm/operations/groupUser.js                            
    [npmPack] npm notice 2.7kB   esm/models/groupUserMappers.js                         
    [npmPack] npm notice 11.0kB  esm/operations/identityProvider.js                     
    [npmPack] npm notice 2.9kB   esm/models/identityProviderMappers.js                  
    [npmPack] npm notice 345B    esm/models/index.js                                    
    [npmPack] npm notice 2.6kB   esm/operations/index.js                                
    [npmPack] npm notice 3.8kB   esm/operations/issue.js                                
    [npmPack] npm notice 2.7kB   esm/models/issueMappers.js                             
    [npmPack] npm notice 9.1kB   esm/operations/logger.js                               
    [npmPack] npm notice 2.8kB   esm/models/loggerMappers.js                            
    [npmPack] npm notice 326.0kB esm/models/mappers.js                                  
    [npmPack] npm notice 13.3kB  esm/operations/namedValue.js                           
    [npmPack] npm notice 2.9kB   esm/models/namedValueMappers.js                        
    [npmPack] npm notice 3.4kB   esm/operations/networkStatus.js                        
    [npmPack] npm notice 515B    esm/models/networkStatusMappers.js                     
    [npmPack] npm notice 5.0kB   esm/operations/notification.js                         
    [npmPack] npm notice 2.7kB   esm/models/notificationMappers.js                      
    [npmPack] npm notice 5.9kB   esm/operations/notificationRecipientEmail.js           
    [npmPack] npm notice 2.7kB   esm/models/notificationRecipientEmailMappers.js        

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 14, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 14, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@raych1
Copy link
Member

raych1 commented Oct 15, 2020

@solankisamir , please fix the model validation failures that is about the secret annotated as x-ms-secret cannot be returned in response in the examples.

@solankisamir
Copy link
Member Author

@solankisamir , please fix the model validation failures that are about the secret annotated as x-ms-secret cannot be returned in response in the examples.

Please see PR #11227 which fixes the issue.

This api-version is a new api-version and no customers are using it. The contract was designed specifically for listing secrets.

@raych1
Copy link
Member

raych1 commented Oct 16, 2020

@solankisamir , please fix the model validation failures that are about the secret annotated as x-ms-secret cannot be returned in response in the examples.

Please see PR #11227 which fixes the issue.

This api-version is a new api-version and no customers are using it. The contract was designed specifically for listing secrets.

Looks good to me, this PR can be merged after PR#11227 is merged.

…igned to List secrets on POST operation (#11227)

* secret ok in POST operation

* fix prettier
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@solankisamir
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@solankisamir
Copy link
Member Author

Thanks, @raych1.
One more nit change in an example - #11249

@solankisamir
Copy link
Member Author

@raych1 feel free to merge this. We will the example in the master branch

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@solankisamir
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@solankisamir
Copy link
Member Author

@raych1 please merge if things look good to you!

@raych1
Copy link
Member

raych1 commented Oct 19, 2020

/azp run automation - sdk

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@solankisamir
Copy link
Member Author

@raych1 feel free to merge it. We will fix the .NET sdk issues with breaking changes in the SDK as this is a new api-version.

@raych1
Copy link
Member

raych1 commented Oct 20, 2020

@raych1 feel free to merge it. We will fix the .NET sdk issues with breaking changes in the SDK as this is a new api-version.

OK.

@raych1 raych1 merged commit cc483e7 into master Oct 20, 2020
giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
* Adds base for updating Microsoft.ApiManagement from version stable/2019-12-01 to version 2020-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add support in API Management for Availability Zones (Azure#10284)

* apim in azs

* fix prettier check

* PATCH should return 200 OK (Azure#10328)

* add support for PATCH returning 200 OK

* CI fixes

prettier fix

CI fixes part 2

* Password no longer a mandatory property when uploading Certificates

* add missing x-ms-odata extension for filter support

* +gatewayhostnameconfiguration protocol changes (Azure#10292)

* [2020-06-01-preview] Update Oauth Server secrets Contract (Azure#10602)

* Oauth server secrets contract

* fix azureMonitor enum

* API Management Service Deleted Services Resource (Azure#10607)

* API Management Service Deleted Services Resource

* Path fix

* Lint + custom-words fixes

* Location URI parameter for deletedservices Resource

* GET for deletedservices by service name

* Remove resourceGroupName from resource path

* fixes

* schema for purge operation

* perttier applied

* 204 response code added

Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>

* OperationNameFormat property added to Diagnostic contract (Azure#10641)

* OperationNameFormat property added to Diagnostic contract

* add azuremonitor to update contract

Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>

* [Microsoft.ApiManagement][2020-06-01-preview] Change Network Status response contract (Azure#10331)

* Change Network Status response contract

* Update examples for network status contract

* identityClientId support (Azure#10776)

* [2020-06-01-preview] Update namedvalue contract for keyvault (Azure#10604)

* update namedvalue contract for keyvault

* add examples

* separate out create contract

* common create contract

* fix examples

* Data Masking settings for Diagnostic (Azure#11033)

* Data Masking settings for Diagnostic

* Move dataMasking under HttpMessageDiagnostic

Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>

* Add isolated skutype (Azure#11029)

* cache entity (Azure#11098)

* [2020-06-01-preview] update certificate contract for KeyVault (Azure#11097)

* The contract `AuthorizationServerSecretsContract` is specifically designed to List secrets on POST operation (Azure#11227)

* secret ok in POST operation

* fix prettier

* fix example (Azure#11249)

Co-authored-by: maksimkim <maksim.kim@gmail.com>
Co-authored-by: promoisha <feoktistovgg@gmail.com>
Co-authored-by: REDMOND\glfeokti <glfeokti@microsoft.com>
Co-authored-by: RupengLiu <rliu1211@terpmail.umd.edu>
Co-authored-by: JJ <jijohn@microsoft.com>
Co-authored-by: Kacie <35987382+KacieKK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants