Fix Swagger Issues for Microsoft.AAD/DomainServices #11178

jihochang · 2020-10-13T22:54:54Z

Add GET/PROVIDERS/MICROSOFT.AAD/SUBSCRIPTIONS/RESOURCEGROUPS/PROVIDERS/MICROSOFT.AAD/DOMAINSERVICES operation

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

Add GET/PROVIDERS/MICROSOFT.AAD/SUBSCRIPTIONS/RESOURCEGROUPS/PROVIDERS/MICROSOFT.AAD/DOMAINSERVICES operation

openapi-pipeline-app · 2020-10-13T22:55:00Z

Swagger Validation Report

️❌BreakingChange: 23 Errors, 0 Warnings failed [Detail] [Expand]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.1)
- original: stable/2017-01-01/domainservices.json <---> new: stable/2017-01-01/domainservices.json
- original: stable/2017-06-01/domainservices.json <---> new: stable/2017-06-01/domainservices.json
- original: stable/2017-06-01/oucontainer.json <---> new: stable/2017-06-01/oucontainer.json
- original: stable/2020-01-01/domainservices.json <---> new: stable/2020-01-01/domainservices.json
- original: stable/2020-01-01/oucontainer.json <---> new: stable/2020-01-01/oucontainer.json

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.AAD/stable/2017-06-01/domainservices.json#L241:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.AAD/stable/2017-06-01/domainservices.json#L49:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.AAD/stable/2017-06-01/domainservices.json#L282:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.AAD/stable/2017-06-01/domainservices.json#L199:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.AAD/stable/2017-06-01/domainservices.json#L132:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.AAD/stable/2017-06-01/domainservices.json#L89:11
`❌` 1011 - AddingResponseCode	The new version adds a response code 'default'. New: Microsoft.AAD/stable/2017-06-01/domainservices.json#L339:11
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AAD/stable/2017-06-01/domainservices.json#L479:9 Old: Microsoft.AAD/stable/2017-06-01/domainservices.json#L411:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AAD/stable/2017-01-01/domainservices.json#L416:9 Old: Microsoft.AAD/stable/2017-01-01/domainservices.json#L411:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AAD/stable/2020-01-01/domainservices.json#L546:9 Old: Microsoft.AAD/stable/2020-01-01/domainservices.json#L534:9

️️✔️~[Staging] LintDiff succeeded [Detail]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )
Linted configuring files (Based on target branch, openapi-validator v1.5.0 , classic-openapi-validator v1.1.4 )

️️✔️~[Staging] Avocado succeeded [Detail]

Validation passes for Avocado.

️️✔️~[Staging] ModelValidation succeeded [Detail]

Validation passes for ModelValidation.

️️✔️~[Staging] SemanticValidation succeeded [Detail]

Validation passes for SemanticValidation.

️️✔️~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]

There are no breaking changes.

️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]

There are no breaking changes.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-10-13T22:55:13Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-10-13T22:56:37Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-13T22:56:38Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4d281cb with merge commit d110522. SDK Automation 13.0.17.20200918.2

️✔️@azure/arm-domainservices [View full logs] [Release SDK Changes]

azure-arm-domainservices-3.1.0.tgz

Only show 100 items here, please refer to log for details.

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/domainservicesManagementClient.js → ./dist/arm-domainservices.js...
[npmPack] created ./dist/arm-domainservices.js in 318ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/arm-domainservices@3.1.0
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 71.9kB  dist/arm-domainservices.js                                
[npmPack] npm notice 22.5kB  dist/arm-domainservices.min.js                            
[npmPack] npm notice 2.4kB   esm/operations/domainServiceOperations.js                 
[npmPack] npm notice 477B    esm/models/domainServiceOperationsMappers.js              
[npmPack] npm notice 13.3kB  esm/operations/domainServices.js                          
[npmPack] npm notice 1.9kB   esm/domainservicesManagementClient.js                     
[npmPack] npm notice 2.6kB   esm/domainservicesManagementClientContext.js              
[npmPack] npm notice 623B    esm/models/domainServicesMappers.js                       
[npmPack] npm notice 263B    esm/models/index.js                                       
[npmPack] npm notice 435B    esm/operations/index.js                                   
[npmPack] npm notice 23.4kB  esm/models/mappers.js                                     
[npmPack] npm notice 2.3kB   esm/operations/ouContainerOperations.js                   
[npmPack] npm notice 400B    esm/models/ouContainerOperationsMappers.js                
[npmPack] npm notice 12.3kB  esm/operations/ouContainerOperationsOperations.js         
[npmPack] npm notice 563B    esm/models/ouContainerOperationsOperationsMappers.js      
[npmPack] npm notice 1.9kB   esm/models/parameters.js                                  
[npmPack] npm notice 922B    rollup.config.js                                          
[npmPack] npm notice 1.7kB   package.json                                              
[npmPack] npm notice 457B    tsconfig.json                                             
[npmPack] npm notice 142.3kB dist/arm-domainservices.js.map                            
[npmPack] npm notice 20.9kB  dist/arm-domainservices.min.js.map                        
[npmPack] npm notice 1.1kB   esm/operations/domainServiceOperations.d.ts.map           
[npmPack] npm notice 1.5kB   esm/operations/domainServiceOperations.js.map             
[npmPack] npm notice 270B    esm/models/domainServiceOperationsMappers.d.ts.map        
[npmPack] npm notice 283B    esm/models/domainServiceOperationsMappers.js.map          
[npmPack] npm notice 3.3kB   esm/operations/domainServices.d.ts.map                    
[npmPack] npm notice 6.1kB   esm/operations/domainServices.js.map                      
[npmPack] npm notice 753B    esm/domainservicesManagementClient.d.ts.map               
[npmPack] npm notice 906B    esm/domainservicesManagementClient.js.map                 
[npmPack] npm notice 527B    esm/domainservicesManagementClientContext.d.ts.map        
[npmPack] npm notice 1.4kB   esm/domainservicesManagementClientContext.js.map          
[npmPack] npm notice 361B    esm/models/domainServicesMappers.d.ts.map                 
[npmPack] npm notice 374B    esm/models/domainServicesMappers.js.map                   
[npmPack] npm notice 9.8kB   esm/models/index.d.ts.map                                 
[npmPack] npm notice 208B    esm/operations/index.d.ts.map                             
[npmPack] npm notice 126B    esm/models/index.js.map                                   
[npmPack] npm notice 222B    esm/operations/index.js.map                               
[npmPack] npm notice 1.1kB   esm/models/mappers.d.ts.map                               
[npmPack] npm notice 13.0kB  esm/models/mappers.js.map                                 
[npmPack] npm notice 1.1kB   esm/operations/ouContainerOperations.d.ts.map             
[npmPack] npm notice 1.5kB   esm/operations/ouContainerOperations.js.map               
[npmPack] npm notice 237B    esm/models/ouContainerOperationsMappers.d.ts.map          
[npmPack] npm notice 250B    esm/models/ouContainerOperationsMappers.js.map            
[npmPack] npm notice 2.9kB   esm/operations/ouContainerOperationsOperations.d.ts.map   
[npmPack] npm notice 5.5kB   esm/operations/ouContainerOperationsOperations.js.map     
[npmPack] npm notice 366B    esm/models/ouContainerOperationsOperationsMappers.d.ts.map
[npmPack] npm notice 379B    esm/models/ouContainerOperationsOperationsMappers.js.map  
[npmPack] npm notice 494B    esm/models/parameters.d.ts.map                            
[npmPack] npm notice 1.4kB   esm/models/parameters.js.map                              
[npmPack] npm notice 3.3kB   README.md                                                 
[npmPack] npm notice 2.2kB   esm/operations/domainServiceOperations.d.ts               
[npmPack] npm notice 4.4kB   src/operations/domainServiceOperations.ts                 
[npmPack] npm notice 249B    esm/models/domainServiceOperationsMappers.d.ts            
[npmPack] npm notice 432B    src/models/domainServiceOperationsMappers.ts              
[npmPack] npm notice 11.2kB  esm/operations/domainServices.d.ts                        
[npmPack] npm notice 19.6kB  src/operations/domainServices.ts                          
[npmPack] npm notice 1.4kB   esm/domainservicesManagementClient.d.ts                   
[npmPack] npm notice 2.0kB   src/domainservicesManagementClient.ts                     
[npmPack] npm notice 964B    esm/domainservicesManagementClientContext.d.ts            
[npmPack] npm notice 2.4kB   src/domainservicesManagementClientContext.ts              
[npmPack] npm notice 395B    esm/models/domainServicesMappers.d.ts                     
[npmPack] npm notice 607B    src/models/domainServicesMappers.ts                       
[npmPack] npm notice 26.6kB  esm/models/index.d.ts                                     
[npmPack] npm notice 204B    esm/operations/index.d.ts                                 
[npmPack] npm notice 25.3kB  src/models/index.ts                                       
[npmPack] npm notice 403B    src/operations/index.ts                                   
[npmPack] npm notice 1.4kB   esm/models/mappers.d.ts                                   
[npmPack] npm notice 18.5kB  src/models/mappers.ts                                     
[npmPack] npm notice 2.2kB   esm/operations/ouContainerOperations.d.ts                 
[npmPack] npm notice 4.3kB   src/operations/ouContainerOperations.ts                   
[npmPack] npm notice 172B    esm/models/ouContainerOperationsMappers.d.ts              
[npmPack] npm notice 353B    src/models/ouContainerOperationsMappers.ts                
[npmPack] npm notice 9.2kB   esm/operations/ouContainerOperationsOperations.d.ts       
[npmPack] npm notice 16.2kB  src/operations/ouContainerOperationsOperations.ts         
[npmPack] npm notice 335B    esm/models/ouContainerOperationsOperationsMappers.d.ts    
[npmPack] npm notice 526B    src/models/ouContainerOperationsOperationsMappers.ts      
[npmPack] npm notice 554B    esm/models/parameters.d.ts                                
[npmPack] npm notice 1.9kB   src/models/parameters.ts                                  
[npmPack] npm notice 1.1kB   LICENSE.txt                                               
[npmPack] npm notice === Tarball Details === 
[npmPack] npm notice name:          @azure/arm-domainservices               
[npmPack] npm notice version:       3.1.0                                   
[npmPack] npm notice filename:      azure-arm-domainservices-3.1.0.tgz      
[npmPack] npm notice package size:  58.9 kB                                 
[npmPack] npm notice unpacked size: 537.3 kB                                
[npmPack] npm notice shasum:        48bb90fbcadb17b44799c5905ffb46570bd6df96
[npmPack] npm notice integrity:     sha512-NEQ/DpDlbVlFG[...]BMx0DH3m0UmEQ==

openapi-sdkautomation · 2020-10-13T22:56:40Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4d281cb with merge commit d110522. SDK Automation 13.0.17.20200918.2

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DomainServices [View full logs] [Release SDK Changes]

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 09 Nov 2020 02:28:45 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0401:EED8:2282D8B:27CA0F3:5FA8A95C","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-10-13T22:56:42Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4d281cb with merge commit d110522. SDK Automation 13.0.17.20200918.2

️✔️domainservices/mgmt/2017-01-01 [View full logs] [Release SDK Changes]

domainservices.mgmt.2017-01-01.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 09 Nov 2020 02:32:11 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C0:77B5:66B6139:AE27354:5FA8AA2B","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

️✔️domainservices/mgmt/2017-06-01 [View full logs] [Release SDK Changes]

domainservices.mgmt.2017-06-01.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 09 Nov 2020 02:32:22 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C1:47C0:8C72318:E660CD6:5FA8AA36","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

️✔️domainservices/mgmt/2020-01-01 [View full logs] [Release SDK Changes]

domainservices.mgmt.2020-01-01.zip

Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Mon, 09 Nov 2020 02:32:35 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C1:17C6:62F64B1:A313336:5FA8AA43","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

openapi-sdkautomation · 2020-10-13T22:56:44Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-13T22:56:44Z

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-13T22:56:45Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-13T22:56:46Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-10-13T22:56:46Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-10-13T23:11:40Z

Azure Pipelines successfully started running 1 pipeline(s).

zhenglaizhang · 2020-10-14T00:46:21Z

/azp run unifiedPipeline

azure-pipelines · 2020-10-14T00:46:26Z

No pipelines are associated with this pull request.

Add DeploymentId property to DomainServiceProperties

azure-pipelines · 2020-10-14T04:57:41Z

Azure Pipelines successfully started running 1 pipeline(s).

Fix swagger correctness issues

azure-pipelines · 2020-10-14T17:39:51Z

Azure Pipelines successfully started running 1 pipeline(s).

Add description for default error type

azure-pipelines · 2020-10-14T17:46:24Z

Azure Pipelines successfully started running 1 pipeline(s).

Ran Prettier

azure-pipelines · 2020-10-14T22:00:45Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-10-14T23:21:19Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-workflow-bot · 2020-10-26T05:48:45Z

Hi @jihochang, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.

Change format back to date-time

azure-pipelines · 2020-10-26T17:27:15Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-10-26T17:29:14Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-pipeline-app · 2020-11-05T21:31:12Z

Swagger Generation Artifacts

️️✔️~[Staging] ApiDocPreview succeeded [Detail]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-11-05T21:31:23Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-11-05T21:51:51Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-11-05T21:58:28Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-11-05T22:29:17Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-11-06T02:44:21Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-11-06T02:44:54Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-11-06T02:50:23Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-11-06T02:51:11Z

Azure Pipelines successfully started running 1 pipeline(s).

* Update domainservices.json Add GET/PROVIDERS/MICROSOFT.AAD/SUBSCRIPTIONS/RESOURCEGROUPS/PROVIDERS/MICROSOFT.AAD/DOMAINSERVICES operation * Update domainservices.json * Update domainservice.json for 2017-01-01 Add DeploymentId property to DomainServiceProperties * Update domainservice.json for 2017-06-01 Fix swagger correctness issues * Update domainservices.json Add description for default error type * Update DomainService 2017-06-01 Ran Prettier * Update oucontainer.json for 2017-06-01 * Update oucontainer.json for 2020-01-01 * Update domainservice.json for 2020-01-01 * Fix linting issues in domainservice.json 2020-01-01 * Fix spell check error on domainservice.json 2020-01-01 * Update domainservices.json Remove incorrect GET * Update domainservices.json Add x-ms-secret metadata for ResourceForest property * Update domainservices.json Change format back to date-time * update format back to date-time * Update domainservices.json * Update domainservices.json * Update domainservices.json * Update domainservices.json * Update domainservices.json * Update domainservices.json * Update domainservices.json * Update domainservices.json

Update domainservices.json

afa51d8

Add GET/PROVIDERS/MICROSOFT.AAD/SUBSCRIPTIONS/RESOURCEGROUPS/PROVIDERS/MICROSOFT.AAD/DOMAINSERVICES operation

openapi-assignment-bot bot assigned xseeseesee Oct 13, 2020

Update domainservices.json

984b693

Update domainservice.json for 2017-01-01

f7c0e22

Add DeploymentId property to DomainServiceProperties

xseeseesee added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 14, 2020

Update domainservice.json for 2017-06-01

57fb208

Fix swagger correctness issues

Update domainservices.json

9b78cc3

Add description for default error type

Update DomainService 2017-06-01

526e5d4

Ran Prettier

Update oucontainer.json for 2017-06-01

0c93e91

PhoenixHe-NV added BreakingChangeReviewRequired Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Oct 26, 2020

Update domainservices.json

b7477db

Change format back to date-time

update format back to date-time

4ba079a

jihochang requested a review from PhoenixHe-NV October 26, 2020 23:24

Update domainservices.json

7c1aaf1

Update domainservices.json

8c7daa1

Update domainservices.json

fda8092

openapi-pipeline-app bot added the NewApiVersionRequired label Nov 5, 2020

Update domainservices.json

f5719e7

Update domainservices.json

9b98a90

Update domainservices.json

dacc4f7

Update domainservices.json

20c2a6e

Update domainservices.json

4d281cb

JeffreyRichter approved these changes Nov 6, 2020

View reviewed changes

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 6, 2020

xseeseesee merged commit d110522 into Azure:master Nov 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Swagger Issues for Microsoft.AAD/DomainServices #11178

Fix Swagger Issues for Microsoft.AAD/DomainServices #11178

jihochang commented Oct 13, 2020 •

edited

Loading

openapi-pipeline-app bot commented Oct 13, 2020 •

edited

Loading

azure-pipelines bot commented Oct 13, 2020

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

azure-pipelines bot commented Oct 13, 2020

zhenglaizhang commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

openapi-workflow-bot bot commented Oct 26, 2020

azure-pipelines bot commented Oct 26, 2020

azure-pipelines bot commented Oct 26, 2020

openapi-pipeline-app bot commented Nov 5, 2020 •

edited

Loading

azure-pipelines bot commented Nov 5, 2020

azure-pipelines bot commented Nov 5, 2020

azure-pipelines bot commented Nov 5, 2020

azure-pipelines bot commented Nov 5, 2020

azure-pipelines bot commented Nov 6, 2020

azure-pipelines bot commented Nov 6, 2020

azure-pipelines bot commented Nov 6, 2020

azure-pipelines bot commented Nov 6, 2020

Fix Swagger Issues for Microsoft.AAD/DomainServices #11178

Fix Swagger Issues for Microsoft.AAD/DomainServices #11178

Conversation

jihochang commented Oct 13, 2020 • edited Loading

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-pipeline-app bot commented Oct 13, 2020 • edited Loading

Swagger Validation Report

azure-pipelines bot commented Oct 13, 2020

openapi-sdkautomation bot commented Oct 13, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Oct 13, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Oct 13, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Oct 13, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Oct 13, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Oct 13, 2020 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Oct 13, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Oct 13, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Oct 13, 2020 • edited Loading

azure-resource-manager-schemas - Release

azure-pipelines bot commented Oct 13, 2020

zhenglaizhang commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

azure-pipelines bot commented Oct 14, 2020

openapi-workflow-bot bot commented Oct 26, 2020

azure-pipelines bot commented Oct 26, 2020

azure-pipelines bot commented Oct 26, 2020

openapi-pipeline-app bot commented Nov 5, 2020 • edited Loading

Swagger Generation Artifacts

azure-pipelines bot commented Nov 5, 2020

azure-pipelines bot commented Nov 5, 2020

azure-pipelines bot commented Nov 5, 2020

azure-pipelines bot commented Nov 5, 2020

azure-pipelines bot commented Nov 6, 2020

azure-pipelines bot commented Nov 6, 2020

azure-pipelines bot commented Nov 6, 2020

azure-pipelines bot commented Nov 6, 2020

jihochang commented Oct 13, 2020 •

edited

Loading

openapi-pipeline-app bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Oct 13, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 5, 2020 •

edited

Loading