Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.AAD: Add OuContainer Swagger #10508

Merged
merged 18 commits into from
Aug 24, 2020
Merged

Microsoft.AAD: Add OuContainer Swagger #10508

merged 18 commits into from
Aug 24, 2020

Conversation

jihochang
Copy link
Contributor

@jihochang jihochang commented Aug 18, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 18, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 18, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 18, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 18, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 18, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 18, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 97f3f9d with merge commit f758360. SDK Automation 13.0.17.20200807.2
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.DomainServices [View full logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 18, 2020

    azure-resource-manager-schemas - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 18, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 18, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 97f3f9d with merge commit f758360. SDK Automation 13.0.17.20200807.2
    • ️✔️@azure/arm-domainservices [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/domainservicesManagementClient.js → ./dist/arm-domainservices.js...
      [npmPack] created ./dist/arm-domainservices.js in 294ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-domainservices@3.1.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 65.1kB  dist/arm-domainservices.js                                
      [npmPack] npm notice 19.5kB  dist/arm-domainservices.min.js                            
      [npmPack] npm notice 2.4kB   esm/operations/domainServiceOperations.js                 
      [npmPack] npm notice 484B    esm/models/domainServiceOperationsMappers.js              
      [npmPack] npm notice 13.2kB  esm/operations/domainServices.js                          
      [npmPack] npm notice 2.0kB   esm/domainservicesManagementClient.js                     
      [npmPack] npm notice 2.7kB   esm/domainservicesManagementClientContext.js              
      [npmPack] npm notice 593B    esm/models/domainServicesMappers.js                       
      [npmPack] npm notice 345B    esm/models/index.js                                       
      [npmPack] npm notice 520B    esm/operations/index.js                                   
      [npmPack] npm notice 17.5kB  esm/models/mappers.js                                     
      [npmPack] npm notice 2.4kB   esm/operations/ouContainerOperations.js                   
      [npmPack] npm notice 482B    esm/models/ouContainerOperationsMappers.js                
      [npmPack] npm notice 12.3kB  esm/operations/ouContainerOperationsOperations.js         
      [npmPack] npm notice 608B    esm/models/ouContainerOperationsOperationsMappers.js      
      [npmPack] npm notice 2.0kB   esm/models/parameters.js                                  
      [npmPack] npm notice 1.0kB   rollup.config.js                                          
      [npmPack] npm notice 1.7kB   package.json                                              
      [npmPack] npm notice 457B    tsconfig.json                                             
      [npmPack] npm notice 130.1kB dist/arm-domainservices.js.map                            
      [npmPack] npm notice 18.5kB  dist/arm-domainservices.min.js.map                        
      [npmPack] npm notice 1.1kB   esm/operations/domainServiceOperations.d.ts.map           
      [npmPack] npm notice 1.4kB   esm/operations/domainServiceOperations.js.map             
      [npmPack] npm notice 241B    esm/models/domainServiceOperationsMappers.d.ts.map        
      [npmPack] npm notice 254B    esm/models/domainServiceOperationsMappers.js.map          
      [npmPack] npm notice 3.3kB   esm/operations/domainServices.d.ts.map                    
      [npmPack] npm notice 6.0kB   esm/operations/domainServices.js.map                      
      [npmPack] npm notice 753B    esm/domainservicesManagementClient.d.ts.map               
      [npmPack] npm notice 907B    esm/domainservicesManagementClient.js.map                 
      [npmPack] npm notice 527B    esm/domainservicesManagementClientContext.d.ts.map        
      [npmPack] npm notice 1.4kB   esm/domainservicesManagementClientContext.js.map          
      [npmPack] npm notice 309B    esm/models/domainServicesMappers.d.ts.map                 
      [npmPack] npm notice 322B    esm/models/domainServicesMappers.js.map                   
      [npmPack] npm notice 8.4kB   esm/models/index.d.ts.map                                 
      [npmPack] npm notice 208B    esm/operations/index.d.ts.map                             
      [npmPack] npm notice 126B    esm/models/index.js.map                                   
      [npmPack] npm notice 223B    esm/operations/index.js.map                               
      [npmPack] npm notice 893B    esm/models/mappers.d.ts.map                               
      [npmPack] npm notice 9.8kB   esm/models/mappers.js.map                                 
      [npmPack] npm notice 1.1kB   esm/operations/ouContainerOperations.d.ts.map             
      [npmPack] npm notice 1.4kB   esm/operations/ouContainerOperations.js.map               
      [npmPack] npm notice 237B    esm/models/ouContainerOperationsMappers.d.ts.map          
      [npmPack] npm notice 250B    esm/models/ouContainerOperationsMappers.js.map            
      [npmPack] npm notice 2.9kB   esm/operations/ouContainerOperationsOperations.d.ts.map   
      [npmPack] npm notice 5.4kB   esm/operations/ouContainerOperationsOperations.js.map     
      [npmPack] npm notice 343B    esm/models/ouContainerOperationsOperationsMappers.d.ts.map
      [npmPack] npm notice 356B    esm/models/ouContainerOperationsOperationsMappers.js.map  
      [npmPack] npm notice 494B    esm/models/parameters.d.ts.map                            
      [npmPack] npm notice 1.4kB   esm/models/parameters.js.map                              
      [npmPack] npm notice 3.3kB   README.md                                                 
      [npmPack] npm notice 2.2kB   esm/operations/domainServiceOperations.d.ts               
      [npmPack] npm notice 4.4kB   src/operations/domainServiceOperations.ts                 
      [npmPack] npm notice 174B    esm/models/domainServiceOperationsMappers.d.ts            
      [npmPack] npm notice 435B    src/models/domainServiceOperationsMappers.ts              
      [npmPack] npm notice 11.2kB  esm/operations/domainServices.d.ts                        
      [npmPack] npm notice 19.5kB  src/operations/domainServices.ts                          
      [npmPack] npm notice 1.4kB   esm/domainservicesManagementClient.d.ts                   
      [npmPack] npm notice 2.1kB   src/domainservicesManagementClient.ts                     
      [npmPack] npm notice 964B    esm/domainservicesManagementClientContext.d.ts            
      [npmPack] npm notice 2.5kB   src/domainservicesManagementClientContext.ts              
      [npmPack] npm notice 283B    esm/models/domainServicesMappers.d.ts                     
      [npmPack] npm notice 569B    src/models/domainServicesMappers.ts                       
      [npmPack] npm notice 22.4kB  esm/models/index.d.ts                                     
      [npmPack] npm notice 204B    esm/operations/index.d.ts                                 
      [npmPack] npm notice 21.5kB  src/models/index.ts                                       
      [npmPack] npm notice 488B    src/operations/index.ts                                   
      [npmPack] npm notice 1.1kB   esm/models/mappers.d.ts                                   
      [npmPack] npm notice 13.8kB  src/models/mappers.ts                                     
      [npmPack] npm notice 2.2kB   esm/operations/ouContainerOperations.d.ts                 
      [npmPack] npm notice 4.3kB   src/operations/ouContainerOperations.ts                   
      [npmPack] npm notice 172B    esm/models/ouContainerOperationsMappers.d.ts              
      [npmPack] npm notice 435B    src/models/ouContainerOperationsMappers.ts                
      [npmPack] npm notice 9.2kB   esm/operations/ouContainerOperationsOperations.d.ts       
      [npmPack] npm notice 16.2kB  src/operations/ouContainerOperationsOperations.ts         
      [npmPack] npm notice 298B    esm/models/ouContainerOperationsOperationsMappers.d.ts    
      [npmPack] npm notice 567B    src/models/ouContainerOperationsOperationsMappers.ts      
      [npmPack] npm notice 554B    esm/models/parameters.d.ts                                
      [npmPack] npm notice 2.0kB   src/models/parameters.ts                                  
      [npmPack] npm notice 1.1kB   LICENSE.txt                                               
      [npmPack] npm notice === Tarball Details === 
      [npmPack] npm notice name:          @azure/arm-domainservices               
      [npmPack] npm notice version:       3.1.0                                   
      [npmPack] npm notice filename:      azure-arm-domainservices-3.1.0.tgz      
      [npmPack] npm notice package size:  54.2 kB                                 
      [npmPack] npm notice unpacked size: 489.2 kB                                
      [npmPack] npm notice shasum:        0b9a49bad28243e81fcb4190acca140cabe8b281
      [npmPack] npm notice integrity:     sha512-K5/vg03bFDrrf[...]Zyqk9yxAgwBEw==

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 18, 2020

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Copy link
    Member

    @raych1 raych1 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Can you fix the lintDiff check failures? And what's the reason to add these new apis to old api version(2017-06-01)?

    @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 19, 2020
    Copy link
    Contributor

    @ravbhatnagar ravbhatnagar left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @jihochang few comments

    @ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 19, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @raych1
    Copy link
    Member

    raych1 commented Aug 20, 2020

    @jianyexi , can you guide on how to fix the lintDiff error?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @jihochang
    Copy link
    Contributor Author

    @jianyexi , can you guide on how to fix the lintDiff error?

    fixed

    @jihochang jihochang closed this Aug 20, 2020
    @jihochang jihochang reopened this Aug 20, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @raych1 raych1 added WaitForARMRevisit and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 20, 2020
    Copy link
    Contributor

    @ravbhatnagar ravbhatnagar left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @jihochang one comment

    @ravbhatnagar
    Copy link
    Contributor

    signing off hoping you can address the pending comment.

    @ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMRevisit labels Aug 21, 2020
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants