[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #10389
Add alertsMetaData to match ARM Manifest
- Loading branch information
commit 074f80a9d0a3c4b402e1cbc955f78b87e5d05968
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,36 @@ | |
| } | ||
| } | ||
| }, | ||
| "/providers/Microsoft.AlertsManagement/alertsMetaData": { | ||
| "get": { | ||
| "operationId": "Alerts_MetaData", | ||
| "description": "List alerts meta data information based on value of identifier parameter.", | ||
| "parameters": [ | ||
| { | ||
| "$ref": "#/parameters/api-version" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/identifier" | ||
| } | ||
| ], | ||
| "produces": [ | ||
| "application/json" | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "OK. Successfully listed alert meta data.", | ||
| "schema": { | ||
| "$ref": "#/definitions/alertsMetaData" | ||
| } | ||
| } | ||
| }, | ||
| "x-ms-examples": { | ||
| "MonService": { | ||
| "$ref": "./examples/AlertsMetaData_MonitorService.json" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "/{scope}/providers/Microsoft.AlertsManagement/alerts": { | ||
| "get": { | ||
| "operationId": "Alerts_GetAll", | ||
|
|
@@ -1190,6 +1220,34 @@ | |
| } | ||
| } | ||
| }, | ||
| "alertsMetaData": { | ||
| "description": "alert meta data information.", | ||
| "properties": { | ||
| "properties": { | ||
|
There was a problem hiding this comment. Each "alertMetadata" resource should look like a resource with a name, type, and ID. They should also have individual GETs if you are modeling them as a GETable resource. Basically, make the API and definitions look a lot more like /alerts There was a problem hiding this comment. @pilor this change is only documenting the current API that our RP exposes. Would it be OK to approve this change, and we'll open a bug to fix the API in the coming sprints? There was a problem hiding this comment. Any new api-versions for this API need to conform to the RPC. You won't be able to make changes here in the future without implementing that |
||
| "$ref": "#/definitions/alertsMetaDataProperties" | ||
| } | ||
| } | ||
| }, | ||
| "alertsMetaDataProperties": { | ||
| "description": "alert meta data property bag", | ||
| "discriminator": "metadataIdentifier", | ||
| "required": [ | ||
| "metadataIdentifier" | ||
| ], | ||
| "properties": { | ||
| "metadataIdentifier": { | ||
| "type": "string", | ||
| "description": "Identification of the information to be retrieved by API call", | ||
| "enum": [ | ||
| "MonitorServiceList" | ||
| ], | ||
| "x-ms-enum": { | ||
| "name": "metadataIdentifier", | ||
| "modelAsString": true | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "smartGroupsList": { | ||
| "description": "List the alerts.", | ||
| "properties": { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response defined in this spec does not conform to the RPC. This is a collection GET and should follow the "paging response body" schema here: https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#get-resource