Skip to content

JobState defined separately in common.json and questionanswering-authoring.json #21173

Open

Description

Both common.json and questionanswering-authoring.json define a JobState model that has separate defintions. The purpose of common.json is to define common models that all swaggers therein reference. From past discussions, questionanswering-authoring.json was supposed to have ref'd this common JobState, which did not happen prior to 2022-05-01 GA.

This will continue to cause lintdiff errors, however, as seen in PR #21030. We need to find a way to solve this problem. One way, since model names are irrelevant to actual service responses, is to change the mode name but keep the x-ms-class-name the same. SDK devs could also use an autorest transform to rename them.

However, that would still cause a breaking change that could affect any other customer-generated clients so that might not be ideal.

Alternatively, can we align the JobState models in a non-breaking way and then just reference the one in common.json in questionanswering-authoring.json as originally intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions