Skip to content

Commit

Permalink
Fixes for comments
Browse files Browse the repository at this point in the history
  • Loading branch information
LaylaLiu committed Sep 29, 2024
1 parent f1a37cb commit d3337ad
Show file tree
Hide file tree
Showing 11 changed files with 27 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
"default": {
"description": "Error response.",
"schema": {
"$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse"
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ErrorResponse"
}
}
},
Expand Down Expand Up @@ -225,9 +225,6 @@
}
],
"responses": {
"200": {
"description": "Delete operation completed"
},
"204": {
"description": "Certificate does not exist"
},
Expand All @@ -242,7 +239,7 @@
"default": {
"description": "Error response.",
"schema": {
"$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse"
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ErrorResponse"
}
}
},
Expand Down Expand Up @@ -316,7 +313,7 @@
"default": {
"description": "Common error response.",
"schema": {
"$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse"
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ErrorResponse"
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
"default": {
"description": "Common error response.",
"schema": {
"$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse"
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ErrorResponse"
}
}
},
Expand Down Expand Up @@ -224,9 +224,6 @@
}
],
"responses": {
"200": {
"description": "Delete operation completed"
},
"202": {
"description": "Delete operation is accepted",
"headers": {
Expand All @@ -241,7 +238,7 @@
"default": {
"description": "Common error response.",
"schema": {
"$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse"
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ErrorResponse"
}
}
},
Expand Down Expand Up @@ -320,6 +317,11 @@
"items": {
"$ref": "#/definitions/ConnectedEnvironmentDaprComponent"
}
},
"nextLink": {
"description": "Link to next page of resources.",
"type": "string",
"readOnly": true
}
}
},
Expand All @@ -333,7 +335,7 @@
],
"properties": {
"properties": {
"provisioningState": {
"ProvisioningState": {
"description": "Provisioning state of the Connected Environment Dapr Component.",
"enum": [
"Succeeded",
Expand All @@ -348,7 +350,7 @@
"modelAsString": true
}
},
"deploymentErrors": {
"DeploymentErrors": {
"description": "Any errors that occurred during deployment or deployment validation",
"type": "string",
"readOnly": true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
"default": {
"description": "Common error response.",
"schema": {
"$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse"
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ErrorResponse"
}
}
},
Expand Down Expand Up @@ -223,9 +223,6 @@
}
],
"responses": {
"200": {
"description": "OK"
},
"202": {
"description": "Delete operation is accepted",
"headers": {
Expand All @@ -240,7 +237,7 @@
"default": {
"description": "Common error response.",
"schema": {
"$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse"
"$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/ErrorResponse"
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
"type": "Microsoft.App/ConnectedEnvironments/Certificates",
"location": "East US",
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
"ProvisioningState": "Succeeded",
"DeploymentErrors": null,
"subjectName": "my-subject-name.company.country.net",
"subjectAlternativeNames": [
"CN=my-subject-name.com"
Expand All @@ -42,7 +42,7 @@
"type": "Microsoft.App/ConnectedEnvironments/Certificates",
"location": "East US",
"properties": {
"provisioningState": "InProgress",
"ProvisioningState": "InProgress",
"subjectName": "my-subject-name.company.country.net",
"subjectAlternativeNames": [
"CN=my-subject-name.com"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"api-version": "2024-10-02-preview"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/providers/Microsoft.App/localtions/eastus/connectedOperationResults/00000"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@
"name": "reddog",
"type": "Microsoft.App/connectedEnvironments/daprcomponents",
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
"ProvisioningState": "Succeeded",
"DeploymentErrors": null,
"componentType": "state.azure.cosmosdb",
"version": "v1",
"ignoreErrors": false,
Expand Down Expand Up @@ -111,7 +111,7 @@
"name": "reddog",
"type": "Microsoft.App/connectedEnvironments/daprcomponents",
"properties": {
"provisioningState": "InProgress",
"ProvisioningState": "InProgress",
"componentType": "state.azure.cosmosdb",
"version": "v1",
"ignoreErrors": false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"api-version": "2024-10-02-preview"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/providers/Microsoft.App/localtions/eastus/connectedOperationResults/00000"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
"name": "reddog",
"type": "Microsoft.App/connectedEnvironments/daprcomponents",
"properties": {
"ProvisioningState": "Succeeded",
"DeploymentErrors": null,
"componentType": "state.azure.cosmosdb",
"version": "v1",
"ignoreErrors": false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
"name": "reddog",
"type": "Microsoft.App/connectedEnvironments/daprcomponents",
"properties": {
"ProvisioningState": "Succeeded",
"DeploymentErrors": null,
"componentType": "state.azure.cosmosdb",
"version": "v1",
"ignoreErrors": false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
"name": "jlaw-demo1",
"type": "Microsoft.App/connectedEnvironments/storages",
"properties": {
"provisioningState": "Succeeded",
"deploymentErrors": null,
"ProvisioningState": "Succeeded",
"DeploymentErrors": null,
"azureFile": {
"accountName": "account1",
"shareName": "share1",
Expand All @@ -39,7 +39,7 @@
"name": "jlaw-demo1",
"type": "Microsoft.App/connectedEnvironments/storages",
"properties": {
"provisioningState": "Inprogress",
"ProvisioningState": "InProgress",
"azureFile": {
"accountName": "account1",
"shareName": "share1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"api-version": "2024-10-02-preview"
},
"responses": {
"200": {},
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/providers/Microsoft.App/localtions/eastus/connectedOperationResults/00000"
Expand Down

0 comments on commit d3337ad

Please sign in to comment.