Skip to content

Commit

Permalink
BugFix: Set readonly flag to false for non-read only properties in Gu…
Browse files Browse the repository at this point in the history
…est Configuration (#14999)

* Bug-Fix: Remove read-only properties from Guest Configuration objects

* Resolved PR comments. Updated examples

* Add Assignment Type

* Fix Prettier check

Co-authored-by: Aashish Rajaram Salokhe <aasalokh@microsoft.com>
  • Loading branch information
aashish1987 and Aashish Rajaram Salokhe authored Jul 7, 2021
1 parent b471a74 commit c6d70ab
Show file tree
Hide file tree
Showing 9 changed files with 60 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"guestConfiguration": {
"name": "WhitelistedApplication",
"version": "1.*",
"contentUri": "https://thisisfake/pacakge",
"contentHash": "123contenthash",
"assignmentType": "ApplyAndAutoCorrect",
"configurationParameter": [
{
"name": "[InstalledApplication]bwhitelistedapp;Name",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"guestConfiguration": {
"name": "WhitelistedApplication",
"version": "1.*",
"contentUri": "https://thisisfake/pacakge",
"contentHash": "123contenthash",
"assignmentType": "ApplyAndAutoCorrect",
"configurationParameter": [
{
"name": "[InstalledApplication]bwhitelistedapp;Name",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -803,15 +803,27 @@
"description": "Version of the guest configuration."
},
"contentUri": {
"readOnly": true,
"type": "string",
"description": "Uri of the storage where guest configuration package is uploaded."
},
"contentHash": {
"readOnly": true,
"type": "string",
"description": "Combined hash of the guest configuration package and configuration parameters."
},
"assignmentType": {
"type": "string",
"description": "Specifies the assignment type and execution of the configuration. Possible values are Audit, DeployAndAutoCorrect, ApplyAndAutoCorrect and ApplyAndMonitor.",
"x-ms-enum": {
"name": "assignmentType",
"modelAsString": true
},
"enum": [
"Audit",
"DeployAndAutoCorrect",
"ApplyAndAutoCorrect",
"ApplyAndMonitor"
]
},
"configurationParameter": {
"type": "array",
"items": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"guestConfiguration": {
"name": "WhitelistedApplication",
"version": "1.*",
"contentUri": "https://thisisfake/pacakge",
"contentHash": "123contenthash",
"assignmentType": "ApplyAndAutoCorrect",
"configurationParameter": [
{
"name": "[InstalledApplication]bwhitelistedapp;Name",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"guestConfiguration": {
"name": "WhitelistedApplication",
"version": "1.*",
"contentUri": "https://thisisfake/pacakge",
"contentHash": "123contenthash",
"assignmentType": "ApplyAndAutoCorrect",
"configurationParameter": [
{
"name": "[InstalledApplication]bwhitelistedapp;Name",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -803,15 +803,27 @@
"description": "Version of the guest configuration."
},
"contentUri": {
"readOnly": true,
"type": "string",
"description": "Uri of the storage where guest configuration package is uploaded."
},
"contentHash": {
"readOnly": true,
"type": "string",
"description": "Combined hash of the guest configuration package and configuration parameters."
},
"assignmentType": {
"type": "string",
"description": "Specifies the assignment type and execution of the configuration. Possible values are Audit, DeployAndAutoCorrect, ApplyAndAutoCorrect and ApplyAndMonitor.",
"x-ms-enum": {
"name": "assignmentType",
"modelAsString": true
},
"enum": [
"Audit",
"DeployAndAutoCorrect",
"ApplyAndAutoCorrect",
"ApplyAndMonitor"
]
},
"configurationParameter": {
"type": "array",
"items": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"guestConfiguration": {
"name": "WhitelistedApplication",
"version": "1.*",
"contentUri": "https://thisisfake/pacakge",
"contentHash": "123contenthash",
"assignmentType": "ApplyAndAutoCorrect",
"configurationParameter": [
{
"name": "[InstalledApplication]bwhitelistedapp;Name",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"guestConfiguration": {
"name": "WhitelistedApplication",
"version": "1.*",
"contentUri": "https://thisisfake/pacakge",
"contentHash": "123contenthash",
"assignmentType": "ApplyAndAutoCorrect",
"configurationParameter": [
{
"name": "[InstalledApplication]bwhitelistedapp;Name",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1088,15 +1088,27 @@
"description": "Version of the guest configuration."
},
"contentUri": {
"readOnly": true,
"type": "string",
"description": "Uri of the storage where guest configuration package is uploaded."
},
"contentHash": {
"readOnly": true,
"type": "string",
"description": "Combined hash of the guest configuration package and configuration parameters."
},
"assignmentType": {
"type": "string",
"description": "Specifies the assignment type and execution of the configuration. Possible values are Audit, DeployAndAutoCorrect, ApplyAndAutoCorrect and ApplyAndMonitor.",
"x-ms-enum": {
"name": "assignmentType",
"modelAsString": true
},
"enum": [
"Audit",
"DeployAndAutoCorrect",
"ApplyAndAutoCorrect",
"ApplyAndMonitor"
]
},
"configurationParameter": {
"type": "array",
"items": {
Expand Down

0 comments on commit c6d70ab

Please sign in to comment.