fix changeableAttributes property for Manifest and Repository (#14155)

* fix changeableAttributes property for Manifest and Repository * separate resource type attributes Signed-off-by: GitHub <noreply@github.com> * fix patch schema Signed-off-by: GitHub <noreply@github.com> * address comment
Azure · May 4, 2021 · a7292a4 · a7292a4
1 parent b93bd81
commit a7292a4
Show file tree

Hide file tree

Showing 2 changed files with 70 additions and 20 deletions.
diff --git a/...registry/data-plane/Microsoft.ContainerRegistry/preview/2019-08-15/containerregistry.json b/...registry/data-plane/Microsoft.ContainerRegistry/preview/2019-08-15/containerregistry.json
@@ -731,13 +731,7 @@
             "$ref": "#/parameters/ImageName"
           },
           {
-            "name": "value",
-            "in": "body",
-            "description": "Repository attribute value",
-            "required": false,
-            "schema": {
-              "$ref": "#/definitions/ChangeableAttributes"
-            }
+            "$ref": "#/parameters/RepositoryAttributeValue"
           }
         ],
         "responses": {
@@ -858,7 +852,7 @@
             "$ref": "#/parameters/TagReference"
           },
           {
-            "$ref": "#/parameters/RepoValue"
+            "$ref": "#/parameters/TagAttributeValue"
           }
         ],
         "responses": {
@@ -1011,7 +1005,7 @@
             "$ref": "#/parameters/ImageReference"
           },
           {
-            "$ref": "#/parameters/RepoValue"
+            "$ref": "#/parameters/ManifestAttributeValue"
           }
         ],
         "responses": {
@@ -1366,7 +1360,7 @@
         },
         "changeableAttributes": {
           "description": "Changeable attributes",
-          "$ref": "#/definitions/ChangeableAttributes"
+          "$ref": "#/definitions/RepositoryChangeableAttributes"
         }
       },
       "example": {
@@ -1375,7 +1369,8 @@
           "readEnabled": true,
           "listEnabled": true,
           "deleteEnabled": true,
-          "writeEnabled": true
+          "writeEnabled": true,
+          "teleportEnabled": false
         },
         "imageName": "imageName",
         "createdTime": "2018-09-07T16:30:46.6583219Z",
@@ -1495,8 +1490,8 @@
           "description": "Is signed"
         },
         "changeableAttributes": {
-          "$ref": "#/definitions/ChangeableAttributes",
-          "description": "Changeable attributes"
+          "$ref": "#/definitions/TagChangeableAttributes",
+          "description": "Tag Changeable attributes"
         }
       },
       "example": {
@@ -1672,7 +1667,7 @@
           }
         },
         "changeableAttributes": {
-          "$ref": "#/definitions/ChangeableAttributes",
+          "$ref": "#/definitions/ManifestChangeableAttributes",
           "description": "Changeable attributes"
         }
       },
@@ -1932,7 +1927,7 @@
         "digest": "sha256:5d20c808ce198565ff70b3ed23a991dd49afac45dece63474b27ce6ed036adc6"
       }
     },
-    "ChangeableAttributes": {
+    "TagChangeableAttributes": {
       "properties": {
         "deleteEnabled": {
           "type": "boolean",
@@ -2045,11 +2040,13 @@
         },
         "quarantineState": {
           "type": "string",
-          "description": "Quarantine state"
+          "description": "Quarantine state",
+          "x-accessibility": "internal"
         },
         "quarantineDetails": {
           "type": "string",
-          "description": "Quarantine details"
+          "description": "Quarantine details",
+          "x-accessibility": "internal"
         }
       },
       "example": {
@@ -2061,6 +2058,38 @@
         "writeEnabled": true
       }
     },
+    "RepositoryChangeableAttributes": {
+      "description": "Changeable attributes for Repository",
+      "properties": {
+        "deleteEnabled": {
+          "type": "boolean",
+          "description": "Delete enabled"
+        },
+        "writeEnabled": {
+          "type": "boolean",
+          "description": "Write enabled"
+        },
+        "listEnabled": {
+          "type": "boolean",
+          "description": "List enabled"
+        },
+        "readEnabled": {
+          "type": "boolean",
+          "description": "Read enabled"
+        },
+        "teleportEnabled": {
+          "type": "boolean",
+          "description": "Enables Teleport functionality on new images in the repository improving Container startup performance"
+        }
+      },
+      "example": {
+        "readEnabled": true,
+        "listEnabled": true,
+        "deleteEnabled": true,
+        "writeEnabled": true,
+        "teleportEnabled": true
+      }
+    },
     "Manifest": {
       "description": "Returns the requested manifest file",
       "properties": {
@@ -2471,13 +2500,33 @@
       "type": "string",
       "x-ms-parameter-location": "method"
     },
-    "RepoValue": {
+    "RepositoryAttributeValue": {
       "name": "value",
       "in": "body",
       "description": "Repository attribute value",
       "required": false,
       "schema": {
-        "$ref": "#/definitions/ChangeableAttributes"
+        "$ref": "#/definitions/RepositoryChangeableAttributes"
+      },
+      "x-ms-parameter-location": "method"
+    },
+    "TagAttributeValue": {
+      "name": "value",
+      "in": "body",
+      "description": "Tag attribute value",
+      "required": false,
+      "schema": {
+        "$ref": "#/definitions/TagChangeableAttributes"
+      },
+      "x-ms-parameter-location": "method"
+    },
+    "ManifestAttributeValue": {
+      "name": "value",
+      "in": "body",
+      "description": "Manifest attribute value",
+      "required": false,
+      "schema": {
+        "$ref": "#/definitions/ManifestChangeableAttributes"
       },
       "x-ms-parameter-location": "method"
     },

diff --git a/...lane/Microsoft.ContainerRegistry/preview/2019-08-15/examples/GetRepositoryAttributes.json b/...lane/Microsoft.ContainerRegistry/preview/2019-08-15/examples/GetRepositoryAttributes.json
@@ -16,7 +16,8 @@
           "deleteEnabled": true,
           "writeEnabled": true,
           "readEnabled": true,
-          "listEnabled": true
+          "listEnabled": true,
+          "teleportEnabled": true
         }
       }
     }