[Microsoft.StorageSync] 2020-09-01 API version updates (#10983)

* Adds base for updating Microsoft.StorageSync from version stable/2020-03-01 to version 2020-09-01 * Updates readme * Updates API version in new specs and examples * Bug 8240091: [Swagger spec] Health state enum in swagger is out of date. Switch to general health state enum * Update registered server properties and fix Bug 8240060: [Swagger spec] Registered server structure in swagger is missing agent version status * Bug 8240048: [Swagger spec] Health properties in swagger are missing recently added fields * Bug 8240067: [Swagger spec] Workflow object in swagger is missing some properties * Update workflow get example * Bug 8240076: [Swagger spec] Operations resources for azure monitor integration have “properties” which is not defined in swagger. Add missing properties to operations API specification * Bug 8240032: [Swagger spec] Error structure returned for some failed requests does not match swagger spec. Add missing properties to specification * remove debug.log file * Add serverName property to registered server and server endpoint properties * Fix missing ServerEndpointSyncMode * run prettier * Update common types reference to v2 * Review and update which properties should be read-only for RegisteredServerProperties * Fix examples for registered server and undo v2 references * Fix typo
Azure · Oct 7, 2020 · 79b7964 · 79b7964
1 parent 7d25a39
commit 79b7964
Show file tree

Hide file tree

Showing 10 changed files with 1,010 additions and 107 deletions.
diff --git a/...c/resource-manager/Microsoft.StorageSync/preview/2020-09-01/examples/Operations_List.json b/...c/resource-manager/Microsoft.StorageSync/preview/2020-09-01/examples/Operations_List.json
diff --git a/...e-manager/Microsoft.StorageSync/preview/2020-09-01/examples/RegisteredServers_Create.json b/...e-manager/Microsoft.StorageSync/preview/2020-09-01/examples/RegisteredServers_Create.json
@@ -3,14 +3,15 @@
     "subscriptionId": "52b8da2f-61e0-4a1f-8dde-336911f367fb",
     "resourceGroupName": "SampleResourceGroup_1",
     "storageSyncServiceName": "SampleStorageSyncService_1",
-    "serverId": "\"080d4133-bdb5-40a0-96a0-71a6057bfe9a\"",
+    "serverId": "080d4133-bdb5-40a0-96a0-71a6057bfe9a",
     "parameters": {
       "properties": {
         "serverRole": "Standalone",
-        "serverCertificate": "\"MIIDFjCCAf6gAwIBAgIQQS+DS8uhc4VNzUkTw7wbRjANBgkqhkiG9w0BAQ0FADAzMTEwLwYDVQQDEyhhbmt1c2hiLXByb2QzLnJlZG1vbmQuY29ycC5taWNyb3NvZnQuY29tMB4XDTE3MDgwMzE3MDQyNFoXDTE4MDgwNDE3MDQyNFowMzExMC8GA1UEAxMoYW5rdXNoYi1wcm9kMy5yZWRtb25kLmNvcnAubWljcm9zb2Z0LmNvbTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALDRvV4gmsIy6jGDPiHsXmvgVP749NNP7DopdlbHaNhjFmYINHl0uWylyaZmgJrROt2mnxN/zEyJtGnqYHlzUr4xvGq/qV5pqgdB9tag/sw9i22gfe9PRZ0FmSOZnXMbLYgLiDFqLtut5gHcOuWMj03YnkfoBEKlFBxWbagvW2yxz/Sxi9OVSJOKCaXra0RpcIHrO/KFl6ho2eE1/7Ykmfa8hZvSdoPd5gHdLiQcMB/pxq+mWp1fI6c8vFZoDu7Atn+NXTzYPKUxKzaisF12TsaKpohUsJpbB3Wocb0F5frn614D2pg14ERB5otjAMWw1m65csQWPI6dP8KIYe0+QPkCAwEAAaMmMCQwIgYDVR0lAQH/BBgwFgYIKwYBBQUHAwIGCisGAQQBgjcKAwwwDQYJKoZIhvcNAQENBQADggEBAA4RhVIBkw34M1RwakJgHvtjsOFxF1tVQA941NtLokx1l2Z8+GFQkcG4xpZSt+UN6wLerdCbnNhtkCErWUDeaT0jxk4g71Ofex7iM04crT4iHJr8mi96/XnhnkTUs+GDk12VgdeeNEczMZz+8Mxw9dJ5NCnYgTwO0SzGlclRsDvjzkLo8rh2ZG6n/jKrEyNXXo+hOqhupij0QbRP2Tvexdfw201kgN1jdZify8XzJ8Oi0bTS0KpJf2pNPOlooK2bjMUei9ANtEdXwwfVZGWvVh6tJjdv6k14wWWJ1L7zhA1IIVb1J+sQUzJji5iX0DrezjTz1Fg+gAzITaA/WsuujlM=\"",
-        "lastHeartBeat": "\"2017-08-08T18:29:06.470652Z\"",
+        "serverCertificate": "MIIDFjCCAf6gAwIBAgIQQS+DS8uhc4VNzUkTw7wbRjANBgkqhkiG9w0BAQ0FADAzMTEwLwYDVQQDEyhhbmt1c2hiLXByb2QzLnJlZG1vbmQuY29ycC5taWNyb3NvZnQuY29tMB4XDTE3MDgwMzE3MDQyNFoXDTE4MDgwNDE3MDQyNFowMzExMC8GA1UEAxMoYW5rdXNoYi1wcm9kMy5yZWRtb25kLmNvcnAubWljcm9zb2Z0LmNvbTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALDRvV4gmsIy6jGDPiHsXmvgVP749NNP7DopdlbHaNhjFmYINHl0uWylyaZmgJrROt2mnxN/zEyJtGnqYHlzUr4xvGq/qV5pqgdB9tag/sw9i22gfe9PRZ0FmSOZnXMbLYgLiDFqLtut5gHcOuWMj03YnkfoBEKlFBxWbagvW2yxz/Sxi9OVSJOKCaXra0RpcIHrO/KFl6ho2eE1/7Ykmfa8hZvSdoPd5gHdLiQcMB/pxq+mWp1fI6c8vFZoDu7Atn+NXTzYPKUxKzaisF12TsaKpohUsJpbB3Wocb0F5frn614D2pg14ERB5otjAMWw1m65csQWPI6dP8KIYe0+QPkCAwEAAaMmMCQwIgYDVR0lAQH/BBgwFgYIKwYBBQUHAwIGCisGAQQBgjcKAwwwDQYJKoZIhvcNAQENBQADggEBAA4RhVIBkw34M1RwakJgHvtjsOFxF1tVQA941NtLokx1l2Z8+GFQkcG4xpZSt+UN6wLerdCbnNhtkCErWUDeaT0jxk4g71Ofex7iM04crT4iHJr8mi96/XnhnkTUs+GDk12VgdeeNEczMZz+8Mxw9dJ5NCnYgTwO0SzGlclRsDvjzkLo8rh2ZG6n/jKrEyNXXo+hOqhupij0QbRP2Tvexdfw201kgN1jdZify8XzJ8Oi0bTS0KpJf2pNPOlooK2bjMUei9ANtEdXwwfVZGWvVh6tJjdv6k14wWWJ1L7zhA1IIVb1J+sQUzJji5iX0DrezjTz1Fg+gAzITaA/WsuujlM=",
         "serverOSVersion": "10.0.14393.0",
-        "agentVersion": "1.0.277.0"
+        "agentVersion": "1.0.277.0",
+        "friendlyName": "afscv-2304-139",
+        "serverId": "080d4133-bdb5-40a0-96a0-71a6057bfe9a"
       }
     },
     "api-version": "2020-09-01"
@@ -27,21 +28,24 @@
         "name": "ankushb-prod3.redmond.corp.microsoft.com",
         "properties": {
           "agentVersion": "3.1.5.0",
+          "agentVersionStatus": "Ok",
+          "agentVersionExpirationDate": "2018-06-11T21:50:40.5840543Z",
           "serverOSVersion": "10.0.14393.0",
           "serverManagementErrorCode": 0,
-          "lastHeartBeat": "\"2018-06-11T21:50:40.5840543Z\"",
+          "lastHeartBeat": "2018-06-11T21:50:40.5840543Z",
           "provisioningState": "Succeeded",
           "serverRole": "Standalone",
-          "clusterId": "\"00000000-0000-0000-0000-000000000000\"",
+          "clusterId": "00000000-0000-0000-0000-000000000000",
           "clusterName": "",
-          "serverId": "\"3635ca8b-5cc8-4a5c-bd43-c2de5ad8dc64\"",
-          "storageSyncServiceUid": "\"4aa14534-1c61-483b-b6a6-9630a76f109a\"",
+          "serverId": "3635ca8b-5cc8-4a5c-bd43-c2de5ad8dc64",
+          "storageSyncServiceUid": "4aa14534-1c61-483b-b6a6-9630a76f109a",
           "lastWorkflowId": "storageSyncServices/CV_FileStore_F1D485AA/workflows/4eecfbcf-9537-4b61-8fee-aaa3ace11c44",
           "lastOperationName": "ICreateRegisteredServerWorkflow",
           "friendlyName": "afscv-2304-139",
-          "managementEndpointUri": "\"https://kailanitest99.one.microsoft.com:443/\"",
-          "monitoringEndpointUri": "\"https://kailanitest99.one.microsoft.com:443/\"",
-          "discoveryEndpointUri": "\"https://kailanitest99.one.microsoft.com:443\"",
+          "serverName": "afscv-2304-139",
+          "managementEndpointUri": "https://kailanitest99.one.microsoft.com:443/",
+          "monitoringEndpointUri": "https://kailanitest99.one.microsoft.com:443/",
+          "discoveryEndpointUri": "https://kailanitest99.one.microsoft.com:443",
           "resourceLocation": "westus",
           "serviceLocation": "westus"
         }

diff --git a/...urce-manager/Microsoft.StorageSync/preview/2020-09-01/examples/RegisteredServers_Get.json b/...urce-manager/Microsoft.StorageSync/preview/2020-09-01/examples/RegisteredServers_Get.json
@@ -16,21 +16,24 @@
         "name": "SampleRegisteredServer_1.redmond.corp.microsoft.com",
         "properties": {
           "agentVersion": "3.1.5.0",
+          "agentVersionStatus": "Ok",
+          "agentVersionExpirationDate": "2018-06-11T21:50:40.5840543Z",
           "serverOSVersion": "10.0.14393.0",
           "serverManagementErrorCode": 0,
-          "lastHeartBeat": "\"2018-06-11T21:50:40.5840543Z\"",
+          "lastHeartBeat": "2018-06-11T21:50:40.5840543Z",
           "provisioningState": "Succeeded",
           "serverRole": "Standalone",
-          "clusterId": "\"00000000-0000-0000-0000-000000000000\"",
+          "clusterId": "00000000-0000-0000-0000-000000000000",
           "clusterName": "",
-          "serverId": "\"3635ca8b-5cc8-4a5c-bd43-c2de5ad8dc64\"",
-          "storageSyncServiceUid": "\"4aa14534-1c61-483b-b6a6-9630a76f109a\"",
+          "serverId": "3635ca8b-5cc8-4a5c-bd43-c2de5ad8dc64",
+          "storageSyncServiceUid": "4aa14534-1c61-483b-b6a6-9630a76f109a",
           "lastWorkflowId": "storageSyncServices/CV_FileStore_F1D485AA/workflows/4eecfbcf-9537-4b61-8fee-aaa3ace11c44",
           "lastOperationName": "ICreateRegisteredServerWorkflow",
           "friendlyName": "afscv-2304-139",
-          "managementEndpointUri": "\"https://kailanitest99.one.microsoft.com:443/\"",
-          "monitoringEndpointUri": "\"https://kailanitest99.one.microsoft.com:443/\"",
-          "discoveryEndpointUri": "\"https://kailanitest99.one.microsoft.com:443\"",
+          "serverName": "afscv-2304-139",
+          "managementEndpointUri": "https://kailanitest99.one.microsoft.com:443/",
+          "monitoringEndpointUri": "https://kailanitest99.one.microsoft.com:443/",
+          "discoveryEndpointUri": "https://kailanitest99.one.microsoft.com:443",
           "resourceLocation": "westus",
           "serviceLocation": "westus"
         },

diff --git a/...t.StorageSync/preview/2020-09-01/examples/RegisteredServers_ListByStorageSyncService.json b/...t.StorageSync/preview/2020-09-01/examples/RegisteredServers_ListByStorageSyncService.json
@@ -17,21 +17,24 @@
             "name": "SampleRegisteredServer_1.redmond.corp.microsoft.com",
             "properties": {
               "agentVersion": "3.1.5.0",
+              "agentVersionStatus": "Ok",
+              "agentVersionExpirationDate": "2018-06-11T21:50:40.5840543Z",
               "serverOSVersion": "10.0.14393.0",
               "serverManagementErrorCode": 0,
-              "lastHeartBeat": "\"2018-06-11T21:50:40.5840543Z\"",
+              "lastHeartBeat": "2018-06-11T21:50:40.5840543Z",
               "provisioningState": "Succeeded",
               "serverRole": "Standalone",
-              "clusterId": "\"00000000-0000-0000-0000-000000000000\"",
+              "clusterId": "00000000-0000-0000-0000-000000000000",
               "clusterName": "",
-              "serverId": "\"3635ca8b-5cc8-4a5c-bd43-c2de5ad8dc64\"",
-              "storageSyncServiceUid": "\"4aa14534-1c61-483b-b6a6-9630a76f109a\"",
+              "serverId": "3635ca8b-5cc8-4a5c-bd43-c2de5ad8dc64",
+              "storageSyncServiceUid": "4aa14534-1c61-483b-b6a6-9630a76f109a",
               "lastWorkflowId": "storageSyncServices/CV_FileStore_F1D485AA/workflows/4eecfbcf-9537-4b61-8fee-aaa3ace11c44",
               "lastOperationName": "ICreateRegisteredServerWorkflow",
               "friendlyName": "afscv-2304-139",
-              "managementEndpointUri": "\"https://kailanitest99.one.microsoft.com:443/\"",
-              "monitoringEndpointUri": "\"https://kailanitest99.one.microsoft.com:443/\"",
-              "discoveryEndpointUri": "\"https://kailanitest99.one.microsoft.com:443\"",
+              "serverName": "afscv-2304-139",
+              "managementEndpointUri": "https://kailanitest99.one.microsoft.com:443/",
+              "monitoringEndpointUri": "https://kailanitest99.one.microsoft.com:443/",
+              "discoveryEndpointUri": "https://kailanitest99.one.microsoft.com:443",
               "resourceLocation": "westus",
               "serviceLocation": "westus"
             },

diff --git a/...rce-manager/Microsoft.StorageSync/preview/2020-09-01/examples/ServerEndpoints_Create.json b/...rce-manager/Microsoft.StorageSync/preview/2020-09-01/examples/ServerEndpoints_Create.json
@@ -33,6 +33,7 @@
           "cloudTiering": "off",
           "volumeFreeSpacePercent": 100,
           "friendlyName": "somemachine.redmond.corp.microsoft.com",
+          "serverName": "somemachine.redmond.corp.microsoft.com",
           "serverResourceId": "/subscriptions/52b8da2f-61e0-4a1f-8dde-336911f367fb/resourceGroups/SampleResourceGroup_1/providers/Microsoft.StorageSync/storageSyncServices/SampleStorageSyncService_1/registeredServers/080d4133-bdb5-40a0-96a0-71a6057bfe9a",
           "provisioningState": "Succeeded",
           "lastWorkflowId": "storageSyncServices/healthDemo1/workflows/569afb5c-7172-4cf8-a8ea-d987f727f11a",

diff --git a/...source-manager/Microsoft.StorageSync/preview/2020-09-01/examples/ServerEndpoints_Get.json b/...source-manager/Microsoft.StorageSync/preview/2020-09-01/examples/ServerEndpoints_Get.json
@@ -20,6 +20,7 @@
           "cloudTiering": "on",
           "volumeFreeSpacePercent": 100,
           "friendlyName": "somemachine.redmond.corp.microsoft.com",
+          "serverName": "somemachine.redmond.corp.microsoft.com",
           "serverResourceId": "/subscriptions/52b8da2f-61e0-4a1f-8dde-336911f367fb/resourceGroups/SampleResourceGroup_1/providers/Microsoft.StorageSync/storageSyncServices/SampleStorageSyncService_1/registeredServers/080d4133-bdb5-40a0-96a0-71a6057bfe9a",
           "provisioningState": "Succeeded",
           "lastWorkflowId": "storageSyncServices/healthDemo1/workflows/569afb5c-7172-4cf8-a8ea-d987f727f11a",

diff --git a/...er/Microsoft.StorageSync/preview/2020-09-01/examples/ServerEndpoints_ListBySyncGroup.json b/...er/Microsoft.StorageSync/preview/2020-09-01/examples/ServerEndpoints_ListBySyncGroup.json
@@ -21,6 +21,7 @@
               "cloudTiering": "off",
               "volumeFreeSpacePercent": 100,
               "friendlyName": "somemachine.redmond.corp.microsoft.com",
+              "serverName": "somemachine.redmond.corp.microsoft.com",
               "serverResourceId": "/subscriptions/52b8da2f-61e0-4a1f-8dde-336911f367fb/resourceGroups/SampleResourceGroup_1/providers/Microsoft.StorageSync/storageSyncServices/SampleStorageSyncService_1/registeredServers/080d4133-bdb5-40a0-96a0-71a6057bfe9a",
               "provisioningState": "Succeeded",
               "lastWorkflowId": "storageSyncServices/healthDemo1/workflows/569afb5c-7172-4cf8-a8ea-d987f727f11a",
@@ -72,6 +73,7 @@
               "cloudTiering": "on",
               "volumeFreeSpacePercent": 80,
               "friendlyName": "somemachine2.redmond.corp.microsoft.com",
+              "serverName": "somemachine2.redmond.corp.microsoft.com",
               "serverResourceId": "/subscriptions/52b8da2f-61e0-4a1f-8dde-336911f367fb/resourceGroups/SampleResourceGroup_1/providers/Microsoft.StorageSync/storageSyncServices/SampleStorageSyncService_1/registeredServers/f94e2944-b48d-4e5b-bdc7-c48ab3712659",
               "provisioningState": "Succeeded",
               "lastWorkflowId": "storageSyncServices/healthDemo1/workflows/40b1dc00-d7d9-4721-a1e9-ab60139b830a",

diff --git a/...rce-manager/Microsoft.StorageSync/preview/2020-09-01/examples/ServerEndpoints_Update.json b/...rce-manager/Microsoft.StorageSync/preview/2020-09-01/examples/ServerEndpoints_Update.json
@@ -31,6 +31,7 @@
           "volumeFreeSpacePercent": 20,
           "tierFilesOlderThanDays": 0,
           "friendlyName": "somemachine2.redmond.corp.microsoft.com",
+          "serverName": "somemachine2.redmond.corp.microsoft.com",
           "serverResourceId": "/subscriptions/3a048283-338f-4002-a9dd-a50fdadcb392/resourceGroups/anpintDemoRG/providers/kailanitest07.one.microsoft.com/storageSyncServices/healthdemo1/registeredServers/f94e2944-b48d-4e5b-bdc7-c48ab3712659",
           "provisioningState": "Succeeded",
           "lastWorkflowId": "storageSyncServices/healthDemo1/workflows/569afb5c-7172-4cf8-a8ea-d987f727f11b",

diff --git a/...ync/resource-manager/Microsoft.StorageSync/preview/2020-09-01/examples/Workflows_Get.json b/...ync/resource-manager/Microsoft.StorageSync/preview/2020-09-01/examples/Workflows_Get.json
@@ -19,7 +19,10 @@
           "lastOperationId": "\"fe680c98-5725-49c8-b0dc-5e29745f752b\"",
           "operation": "do",
           "lastStepName": "runServerJob",
-          "steps": "[{\"name\":\"validateInput\",\"friendlyName\":\"validateInput\",\"status\":\"Succeeded\",\"error\":null},{\"name\":\"newServerEndpoint\",\"friendlyName\":\"newServerEndpoint\",\"status\":\"Succeeded\",\"error\":null},{\"name\":\"updateReplicaGroupCertificates\",\"friendlyName\":\"updateReplicaGroupCertificates\",\"status\":\"Succeeded\",\"error\":null},{\"name\":\"runServerJob\",\"friendlyName\":\"runServerJob\",\"status\":\"Succeeded\",\"error\":null}]"
+          "steps": "[{\"name\":\"validateInput\",\"friendlyName\":\"validateInput\",\"status\":\"Succeeded\",\"error\":null},{\"name\":\"newServerEndpoint\",\"friendlyName\":\"newServerEndpoint\",\"status\":\"Succeeded\",\"error\":null},{\"name\":\"updateReplicaGroupCertificates\",\"friendlyName\":\"updateReplicaGroupCertificates\",\"status\":\"Succeeded\",\"error\":null},{\"name\":\"runServerJob\",\"friendlyName\":\"runServerJob\",\"status\":\"Succeeded\",\"error\":null}]",
+          "commandName": "ICreateServerEndpointWorkflow",
+          "createdTimestamp": "2019-04-17T19:04:59.1959227Z",
+          "lastStatusTimestamp": "2019-04-17T19:04:59.1959227Z"
         },
         "id": "/subscriptions/3a048283-338f-4002-a9dd-a50fdadcb392/resourceGroups/SampleResourceGroup_1/providers/Microsoft.StorageSync/storageSyncServices/SampleStorageSyncService_1/workflows/828219ea-083e-48b5-89ea-8fd9991b2e75",
         "type": "Microsoft.StorageSync/storageSyncServices/workflows"