Fix S360 swagger error, certificateId not required (#22339)

* Fix S360 swagger error, certificateId not required Fix S360 swagger error, certificateId not required per service behavior * Update ContainerApps_ListCustomHostNameAnalysisErrorResponse.json fix example error --------- Co-authored-by: Nan Jiang <naji@microsoft.com>
Azure · Feb 3, 2023 · 638734a · 638734a
1 parent 9f33c53
commit 638734a
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 13 deletions.
diff --git a/...fication/app/resource-manager/Microsoft.App/preview/2022-01-01-preview/ContainerApps.json b/...fication/app/resource-manager/Microsoft.App/preview/2022-01-01-preview/ContainerApps.json
@@ -737,8 +737,7 @@
       "description": "Custom Domain of a Container App",
       "type": "object",
       "required": [
-        "name",
-        "certificateId"
+        "name"
       ],
       "properties": {
         "name": {
@@ -758,7 +757,7 @@
           }
         },
         "certificateId": {
-          "description": "Resource Id of the Certificate to be bound to this hostname. Must exist in the Managed Environment.",
+          "description": "Resource Id of the Certificate to be bound to this hostname.",
           "type": "string"
         }
       }

diff --git a/...fication/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/ContainerApps.json b/...fication/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/ContainerApps.json
@@ -860,8 +860,7 @@
       "description": "Custom Domain of a Container App",
       "type": "object",
       "required": [
-        "name",
-        "certificateId"
+        "name"
       ],
       "properties": {
         "name": {
@@ -881,7 +880,7 @@
           }
         },
         "certificateId": {
-          "description": "Resource Id of the Certificate to be bound to this hostname. Must exist in the Managed Environment.",
+          "description": "Resource Id of the Certificate to be bound to this hostname.",
           "type": "string"
         }
       }

diff --git a/specification/app/resource-manager/Microsoft.App/stable/2022-03-01/ContainerApps.json b/specification/app/resource-manager/Microsoft.App/stable/2022-03-01/ContainerApps.json
@@ -741,8 +741,7 @@
       "description": "Custom Domain of a Container App",
       "type": "object",
       "required": [
-        "name",
-        "certificateId"
+        "name"
       ],
       "properties": {
         "name": {
@@ -762,7 +761,7 @@
           }
         },
         "certificateId": {
-          "description": "Resource Id of the Certificate to be bound to this hostname. Must exist in the Managed Environment.",
+          "description": "Resource Id of the Certificate to be bound to this hostname.",
           "type": "string"
         }
       }

diff --git a/...App/stable/2022-03-01/examples/ContainerApps_ListCustomHostNameAnalysisErrorResponse.json b/...App/stable/2022-03-01/examples/ContainerApps_ListCustomHostNameAnalysisErrorResponse.json
@@ -4,7 +4,7 @@
     "resourceGroupName": "rg",
     "containerAppName": "testcontainerApp0",
     "customHostname": "my.name.corp",
-    "api-version": "2022-03-03"
+    "api-version": "2022-03-01"
   },
   "responses": {
     "200": {

diff --git a/specification/app/resource-manager/Microsoft.App/stable/2022-10-01/ContainerApps.json b/specification/app/resource-manager/Microsoft.App/stable/2022-10-01/ContainerApps.json
@@ -882,8 +882,7 @@
       "description": "Custom Domain of a Container App",
       "type": "object",
       "required": [
-        "name",
-        "certificateId"
+        "name"
       ],
       "properties": {
         "name": {
@@ -903,7 +902,7 @@
           }
         },
         "certificateId": {
-          "description": "Resource Id of the Certificate to be bound to this hostname. Must exist in the Managed Environment.",
+          "description": "Resource Id of the Certificate to be bound to this hostname.",
           "type": "string"
         }
       }