Skip to content

Commit

Permalink
[Azure Search] Add missing $select parameter to List APIs (#7371)
Browse files Browse the repository at this point in the history
The Azure Search REST API has always supported $select across all List APIs,
but we forgot to specify it in the Swagger spec for all but List Indexes.
  • Loading branch information
brjohnstmsft authored and sarangan12 committed Oct 1, 2019
1 parent 3e5c0e9 commit 12cfa96
Show file tree
Hide file tree
Showing 6 changed files with 34 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"parameters": {
"searchServiceName": "myservice",
"searchDnsSuffix": "search.windows.net",
"$select": "*",
"api-version": "2019-05-06"
},
"responses": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"parameters": {
"searchServiceName": "myservice",
"searchDnsSuffix": "search.windows.net",
"$select": "*",
"api-version": "2019-05-06"
},
"responses": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"parameters": {
"searchServiceName": "myservice",
"searchDnsSuffix": "search.windows.net",
"$select": "name",
"$select": "*",
"api-version": "2019-05-06"
},
"responses": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"parameters": {
"searchServiceName": "myservice",
"searchDnsSuffix": "search.windows.net",
"$select": "*",
"api-version": "2019-05-06"
},
"responses": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"parameters": {
"searchServiceName": "myservice",
"searchDnsSuffix": "search.windows.net",
"$select": "*",
"api-version": "2019-05-06"
},
"responses": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,13 @@
"url": "https://docs.microsoft.com/rest/api/searchservice/List-Data-Sources"
},
"parameters": [
{
"name": "$select",
"in": "query",
"required": false,
"type": "string",
"description": "Selects which top-level properties of the data sources to retrieve. Specified as a comma-separated list of JSON property names, or '*' for all properties. The default is all properties."
},
{
"$ref": "#/parameters/ClientRequestIdParameter"
},
Expand Down Expand Up @@ -492,6 +499,13 @@
"url": "https://docs.microsoft.com/rest/api/searchservice/List-Indexers"
},
"parameters": [
{
"name": "$select",
"in": "query",
"required": false,
"type": "string",
"description": "Selects which top-level properties of the indexers to retrieve. Specified as a comma-separated list of JSON property names, or '*' for all properties. The default is all properties."
},
{
"$ref": "#/parameters/ClientRequestIdParameter"
},
Expand Down Expand Up @@ -745,6 +759,13 @@
"url": "https://docs.microsoft.com/rest/api/searchservice/list-skillset"
},
"parameters": [
{
"name": "$select",
"in": "query",
"required": false,
"type": "string",
"description": "Selects which top-level properties of the skillsets to retrieve. Specified as a comma-separated list of JSON property names, or '*' for all properties. The default is all properties."
},
{
"$ref": "#/parameters/ClientRequestIdParameter"
},
Expand Down Expand Up @@ -969,6 +990,13 @@
"url": "https://docs.microsoft.com/rest/api/searchservice/List-Synonym-Maps"
},
"parameters": [
{
"name": "$select",
"in": "query",
"required": false,
"type": "string",
"description": "Selects which top-level properties of the synonym maps to retrieve. Specified as a comma-separated list of JSON property names, or '*' for all properties. The default is all properties."
},
{
"$ref": "#/parameters/ClientRequestIdParameter"
},
Expand Down Expand Up @@ -1090,7 +1118,7 @@
"in": "query",
"required": false,
"type": "string",
"description": "Selects which properties of the index definitions to retrieve. Specified as a comma-separated list of JSON property names, or '*' for all properties. The default is all properties."
"description": "Selects which top-level properties of the index definitions to retrieve. Specified as a comma-separated list of JSON property names, or '*' for all properties. The default is all properties."
},
{
"$ref": "#/parameters/ClientRequestIdParameter"
Expand Down

0 comments on commit 12cfa96

Please sign in to comment.