Azure RT PR for Sprint 44 #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/ResourceManager/StreamAnalytics/Commands.StreamAnalytics/Microsoft.Azure.Commands.StreamAnalytics.dll-Help.xml
… to the build folder
…o dev Conflicts: src/ServiceManagement/Compute/Commands.ServiceManagement.Test/FunctionalTests/ServiceManagementCmdletTestHelper.cs src/ServiceManagement/Compute/Commands.ServiceManagement.Test/FunctionalTests/VMTemplateTests.cs
| Console.WriteLine("Error occurred during cleaning up reserved ips.."); | ||
| } | ||
| } | ||
| //vmPowershellCmdlets = new ServiceManagementCmdletTestHelper(); |
There was a problem hiding this comment.
Remove commented code if it's not used.
fix vm image verification
Address CR
| @@ -76,8 +76,8 @@ public void CleanupTest() | |||
| { | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| [TestCategory(Category.Functional)] | |||
| //[TestMethod] | |||
There was a problem hiding this comment.
do not comment the code, please remove the tests altogether
Re-activate unit tests.
| vmPowershellCmdlets.RunPSScript("Get-AzureService | Remove-AzureService -Force"); | ||
| Utilities.RetryActionUntilSuccess(() => vmPowershellCmdlets.RemoveAzureVNetConfig(), "in use", 5, 30); | ||
| } | ||
| //if (vnetConfig.Count > 0) |
akromm-zz
pushed a commit
to akromm-zz/azure-powershell
that referenced
this pull request
Apr 18, 2015
Revert changes made for Set-AzureRoleDefinition and New-AzureRoleDefinition command let
AzureRT
referenced
this pull request
in AzureRT/azure-powershell
Sep 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.