Skip to content

AzureRT S54 PR #2 - Record Debug Messages & Fix Add-AzureVhd #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 15, 2015
Merged

AzureRT S54 PR #2 - Record Debug Messages & Fix Add-AzureVhd #905

merged 13 commits into from
Sep 15, 2015

Conversation

huangpf
Copy link
Contributor

@huangpf huangpf commented Sep 14, 2015

No description provided.

huangpf added 11 commits September 9, 2015 23:15
@huangpf
Merge pull request #84 from Azure/release-0.9.8
9c465b4 
Release 0.9.8
@huangpf
throw AggregateException in case of exceptions in Add-AzureVhd
56d8303
@huangpf
Truncate extension id string if too long
cbe36d2
@huangpf
Merge branch 'release-0.9.8' of https://github.com/Azure/azure-powers…
2026031 
…hell into r098
@huangpf
Fix #387
c0a2938 
```
Role                 : MicrosoftContosoDepartmentProjectCodeNameWorker
Extension            : RDP
ProviderNameSpace    : Microsoft.Windows.Azure.Extensions
Version              : 1.*
Id                   : MicrosoftContosoDepartmentProjectCodeNa-RDP-Production-Ext-0
...
```
@huangpf
Merge pull request #85 from Azure/dev
4c1be82 
.
@huangpf
RecordDebugMessages
7431ee7
@huangpf
Merge pull request #86 from Azure/dev
a14b114 
.
@huangpf
Merge pull request #87 from Azure/dev
d7a961c 
.
@huangpf
Merge branch 'dev' of https://github.com/huangpf/azure-powershell int…
8038643 
…o r098

Conflicts:
	src/Common/AzurePSCmdlet.cs
@huangpf
update
d8f76ce
@azurecla
Copy link

Hi @huangpf, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (phuang). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@huangpf huangpf changed the title [do not merge] AzureRT S54 PR #1 - Record Debug Messages AzureRT S54 PR #1 - Record Debug Messages & Fix Add-AzureVhd Sep 14, 2015
@huangpf huangpf changed the title AzureRT S54 PR #1 - Record Debug Messages & Fix Add-AzureVhd AzureRT S54 PR #2 - Record Debug Messages & Fix Add-AzureVhd Sep 14, 2015
@huangpf
Copy link
Contributor Author

huangpf commented Sep 14, 2015

Fix #387

ogail
ogail reviewed Sep 15, 2015
View reviewed changes
src/Common/AzurePSCmdlet.cs
@@ -254,7 +257,7 @@ protected bool IsVerbose()

protected new void WriteError(ErrorRecord errorRecord)
{
FlushDebugMessages();
FlushDebugMessages(IsDataCollectionAllowed());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to pass IsDataCollectionAllowed() just use it in FlushDebugMessages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we only want to log when there is an exception. Do you mean you want to log everything if data collection is allowed?

@ogail
Copy link
Contributor

ogail commented Sep 15, 2015

added a nit

ogail added a commit that referenced this pull request Sep 15, 2015
@ogail
Merge pull request #905 from huangpf/r098
a0a0390 
AzureRT S54 PR #2 - Record Debug Messages & Fix Add-AzureVhd
@ogail ogail merged commit a0a0390 into Azure:dev Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huangpf @azurecla @ogail